From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Tue, 19 Dec 2017 21:58:41 +0100 Message-ID: References: <20171204191506.GC28066@jasmine.lan> <87609h3dzk.fsf@gmail.com> <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1144f6c6668aeb0560b7bb45" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eROyL-0008Tm-N3 for guix-devel@gnu.org; Tue, 19 Dec 2017 15:58:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eROyK-0001LG-7p for guix-devel@gnu.org; Tue, 19 Dec 2017 15:58:45 -0500 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:40105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eROyK-0001L5-0J for guix-devel@gnu.org; Tue, 19 Dec 2017 15:58:44 -0500 Received: by mail-it0-x22b.google.com with SMTP id f190so4337398ita.5 for ; Tue, 19 Dec 2017 12:58:43 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel --001a1144f6c6668aeb0560b7bb45 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2017-12-19 10:11 GMT+01:00 G=C3=A1bor Boskovits : > > > 2017-12-19 9:07 GMT+01:00 Chris Marusich : > >> Hi G=C3=A1bor and Ricardo, >> >> I see that G=C3=A1bor made this GitHub issue to track their work: >> >> https://github.com/Boskovits/guix/issues/16 >> >> At this point, can I help with anything in particular, or should I wait >> until after G=C3=A1bor pushes the fix(es) for java-hamcrest-core, so we = can >> build the covering of icedtea-8 after that and see what still breaks? >> >> > I'm quite near to get a fix for java-hamcrest-core. Only java-jarjar has > to be modified now, so I think you can wait until I get this done. > I have now pushed the fix for java-hamcrest-core to my branch. Now I have another blocking issue: https://github.com/Boskovits/guix/issues/24 Error message: BUILD FAILED /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.xml:654: Problem: failed to create task or type junit Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUnitTask was not found. This looks like one of Ant's optional components. Action: Check that the appropriate optional JAR exists in -/gnu/store/6lzf3cp16m0xgwr00lymqd3v6fgpvzxv-ant-1.10.1/lib -/.ant/lib -a directory added on the command line with the -lib argument Do not panic, this is a common problem. The commonest cause is a missing JAR. This is not a bug; it is a configuration problem End of error message. It seems that this is an ant configuration issue. Should we add junit with -lib to the ant command line? > > >> G=C3=A1bor Boskovits writes: >> >> > I've found the problem with java-hamcrest-core. >> > The root cause of this is that java-jarjar uses a bundled copy of asm, >> > version 4.0. >> > This asm version does not support icedtea8. >> > >> > I propose to use java-asm instead of the bundled one. >> > >> > In my opinion the best course of action should be: >> > 1. create a package: java-asm-notest with tests diabled to break the >> > dependency cycle on java-hamcrest-core >> > 2. modify java-jarjar to use java-asm-notest instead of the bundled as= m. >> > 3. test if java-hamcrest-core now builds. >> > >> > It is a question if we want to iterate this cycle once more, with a >> > tests-enabled java-asm. >> > WDYT? >> >> Sounds good to me. >> >> G=C3=A1bor Boskovits writes: >> >> > It seems, that it is aslo safe to apply this on master. >> > This is the patch: >> > >> > ... >> > >> > Subject: [PATCH] gnu: Clean up depencies of java-asm. >> >> This patch seems fine to me. I briefly looked but could not find it in >> the Guix Git repo; have you not pushed it yet? > > G=C3=A1bor Boskovits writes: >> >> > We now have an upstream fix for classpathx, it is pushed as revision >> 1244 >> > to the savannah subversion repo. >> > May I change the source to use this revision? >> > Or should I use a patch? >> > >> > I think using the upstream revision is a better option. >> > WDYT? >> >> I agree: using the upstream revision sounds like a better plan. The >> only reason I can think why we would not want to do that is if it is >> going to take a long time for it to get released. >> >> -- >> Chris >> > > --001a1144f6c6668aeb0560b7bb45 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2017= -12-19 10:11 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com&g= t;:


2017-12-19 9:07 GMT+01:00 Chris Marusich = <cmmarusich@gm= ail.com>:
https://github.com/Boskovits/guix/issues/16

At this point, can I help with anything in particular, or should I wait
until after G=C3=A1bor pushes the fix(es) for java-hamcrest-core, so we can=
build the covering of icedtea-8 after that and see what still breaks?


I'm quite near= to get a fix for java-hamcrest-core. Only java-jarjar has to be modified n= ow, so I think you can wait until I get this done.

I have now pushed the fix for java-hamcrest-core= to my branch.
Now I have another blocking issue:

Error message:

BUILD FAILED
/tmp/guix-build-java-bsh-2.0b6.drv-= 0/beanshell-2.0b6/build.xml:654: Problem: failed to create task or type jun= it
Cause: the class org.apache.tools.ant.taskdefs.optional.junit.= JUnitTask was not found.
This looks like one of Ant's optiona= l components.
Action: Check that the appropriate optional JAR exi= sts in
-/gnu/store/6lzf3cp16m0xgwr00lymqd3v6fgpvzxv-ant-1.10.1/li= b
-/.ant/lib
-a directory added on the command line wit= h the -lib argument

Do not panic, this is a common= problem.
The commonest cause is a missing JAR.

This is not a bug; it is a configuration problem
End of error message.

It seems that t= his is an ant configuration issue.
Should w= e add junit with -lib to the ant command line?
=C2=A0
= =C2=A0
G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> I've found the problem with java-hamcrest-core.
> The root cause of this is that java-jarjar uses a bundled copy of asm,=
> version 4.0.
> This asm version does not support icedtea8.
>
> I propose to use java-asm instead of the bundled one.
>
> In my opinion the best course of action should be:
> 1. create a package: java-asm-notest with tests diabled to break the > dependency cycle on java-hamcrest-core
> 2. modify java-jarjar to use java-asm-notest instead of the bundled as= m.
> 3. test if java-hamcrest-core now builds.
>
> It is a question if we want to iterate this cycle once more, with a > tests-enabled java-asm.
> WDYT?

Sounds good to me.

G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> It seems, that it is aslo safe to apply this on master.
> This is the patch:
>
> ...
>
> Subject: [PATCH] gnu: Clean up depencies of java-asm.

This patch seems fine to me.=C2=A0 I briefly looked but could not fi= nd it in
the Guix Git repo; have you not pushed it yet?
G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> We now have an upstream fix for classpathx, it is pushed as revision 1= 244
> to the savannah subversion repo.
> May I change the source to use this revision?
> Or should I use a patch?
>
> I think using the upstream revision is a better option.
> WDYT?

I agree: using the upstream revision sounds like a better plan.=C2= =A0 The
only reason I can think why we would not want to do that is if it is
going to take a long time for it to get released.
<= br> --
Chris


--001a1144f6c6668aeb0560b7bb45--