From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Subject: bug#39394: vis editor doesn't respect user configuration Date: Sun, 2 Feb 2020 23:56:58 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003abe1d059d9fbade" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43966) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyOBn-0003vx-OL for bug-guix@gnu.org; Sun, 02 Feb 2020 17:58:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyOBm-0007Z7-L0 for bug-guix@gnu.org; Sun, 02 Feb 2020 17:58:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyOBm-0007YY-FD for bug-guix@gnu.org; Sun, 02 Feb 2020 17:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyOBm-0007P0-EI for bug-guix@gnu.org; Sun, 02 Feb 2020 17:58:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: tsmish Cc: 39394@debbugs.gnu.org --0000000000003abe1d059d9fbade Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tsmish ezt =C3=ADrta (id=C5=91pont: 2020. febr. 2., Vas = 22:08): > > I would go for renaming it like visrc.lua.example, or similar. > > I don't really like this solution because while this particular > problem will be fixed, underlying issue of system paths having higher > priority than user ones will stay. > From what I can figure out from the > code( > https://github.com/martanne/vis/blob/a4b64c5c396646bb2f14db3b4145a5482a2f= f8bf/vis-lua.c#L2650 > ) > $VIS_PATH is at the top of package.path which will make requires from > user configuration go there in case of files with same name. > Also this will probably make commands such as "set theme" ignore user > files from configuration directory when there is a file in system one > Ok, as a real user of vis, I believe you got a better understanding. I will have a look at the package tomorrow. > > Also there is VIS_PATH #define which seems to be intended way to set > path to system directory. It is set to /usr/local/share/vis by > default, but I don't see it > in help, which probably means it gets overwritten with some kind of guix > magic. > --0000000000003abe1d059d9fbade Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


tsmish <tsymsh@= gmail.com> ezt =C3=ADrta (id=C5=91pont: 2020. febr. 2., Vas 22:08):<= br>
> I would go for renaming it lik= e visrc.lua.example, or similar.

I don't really like this solution because while this particular
problem will be fixed, underlying issue of system paths having higher
priority than user ones will stay.
>From what I can figure out from the
code(https://github.com/martanne/vis/blob/a4b64c5c396646bb2f14db3b4145a= 5482a2ff8bf/vis-lua.c#L2650)
$VIS_PATH is at the top of package.path which will make requires from
user configuration go there in case of files with same name.
Also this will probably make commands such as "set theme" ignore = user
files from configuration directory when there is a file in system one
Ok, as a real user of vis, I belie= ve you got a better understanding. I will have a look at the package tomorr= ow.

Also there is VIS_PATH #define which seems to be intended way to set
path to system directory. It is set to /usr/local/share/vis by
default, but I don't see it
in help, which probably means it gets overwritten with some kind of guix ma= gic.
--0000000000003abe1d059d9fbade--