From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDpkf-0005I4-Cy for guix-patches@gnu.org; Sat, 20 Oct 2018 07:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDpkc-0006B6-6d for guix-patches@gnu.org; Sat, 20 Oct 2018 07:49:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDpkc-0006A3-0X for guix-patches@gnu.org; Sat, 20 Oct 2018 07:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDpkb-0000za-Or for guix-patches@gnu.org; Sat, 20 Oct 2018 07:49:01 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> In-Reply-To: From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sat, 20 Oct 2018 13:48:26 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: Laura Lazzati , 33099@debbugs.gnu.org Hello guix, G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont: 201= 8. okt. 20., Szo, 13:05): > > Hello Laura, > > G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont: 2= 018. okt. > 20., Szo, 10:43): > > > > Hello Laura, > > > > Ricardo Wurmus ezt =C3=ADrta (id=C5=91po= nt: 2018. > > okt. 20., Szo, 10:17): > > > > > > > > > Hi Laura, > > > > > > congratulations on your first patch to Guix! > > > > > > What follows are a few comments on minor changes that I would like to > > > see before applying the patch to Guix. > > > > > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2= 001 > > > > From: laura > > > > Date: Fri, 19 Oct 2018 19:15:37 -0300 > > > > Subject: [PATCH] I add r-aspi package appended to cran.scm file > > > > > > > > --- > > > > gnu/packages/cran.scm | 19 +++++++++++++++++++ > > > > 1 file changed, 19 insertions(+) > > > > > > For commits to Guix, we use a somewhat strict commit message format. > > > You can take a look at the commit log to get a feel for it. In the c= ase > > > of adding r-aspi to cran.scm this would be the expected commit messag= e: > > > > > > --8<---------------cut here---------------start------------->8--- > > > gnu: Add r-aspi. > > > > > > * gnu/packages/cran.scm (r-aspi): New variable. > > > --8<---------------cut here---------------end--------------->8--- > > > > > > The first line is always a concise summary. This is followed by a > > > change log listing modified files and how they were modified. > > > > > > > You can also see git log for examples. > > > > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > > > > index efcc2dccb..0d8ee6a97 100644 > > > > --- a/gnu/packages/cran.scm > > > > +++ b/gnu/packages/cran.scm > > > > @@ -6256,3 +6256,22 @@ a header row or not. The dataset should con= tain > > > > only one independent variable > > > > (x) and one dependent variable (y) and can contain a weight for ea= ch > > > > observation.") > > > > (license license:gpl2))) > > > > + > > > > +(define-public r-aspi > > > > + (package > > > > + (name "r-aspi") > > > > + (version "0.2.0") > > > > + (source > > > > + (origin > > > > + (method url-fetch) > > > > + (uri (cran-uri "aspi" version)) > > > > + (sha256 > > > > + (base32 > > > > + "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87")))= ) > > > > + (build-system r-build-system) > > > > + (home-page "https://cran.r-project.org/web/packages/aspi/") > > > > + (synopsis "Analysis of Symmetry of Parasitic Infections") > > > > > > Please use lowercase for all words except for the first. CRAN synops= es > > > are usually in titlecase and the importer can=E2=80=99t automatically= figure out > > > which words should be converted, so this needs to be done manually. > > > > > > > + (description > > > > + "Tools for the analysis and visualization of bilateral asymme= try in > > > > + parasitic infections.") > > > > > > Please use a complete sentence for the description. The easiest way = is > > > probably to just prepend =E2=80=9CThis package provides=E2=80=9D. > > > > > > > + (license license:gpl3))) > > > > > > I checked the source files and noticed that it=E2=80=99s actually GPL= 3 or > > > later. Here=E2=80=99s an except from the header of aspi.R: > > > > > > --8<---------------cut here---------------start------------->8--- > > > # Analysis of Symmetry of Parasitic Infections is free software: you= can # > > > # redistribute it and/or modify it under the terms of the GNU Genera= l Public # > > > # License as published by the Free Software Foundation, either versi= on 3 of # > > > # the License, or (at your option) any later version. = # > > > --8<---------------cut here---------------end--------------->8--- > > > > > > So this really should be =E2=80=9Clicense:gpl3+=E2=80=9D. > > > > > > (I haven=E2=80=99t tried building the package yet.) > > > > > > > I will try this and report back. > > > > It builds for me fine, so with the suggestions Ricardo mentioned I think > it is good to go. > > > > I think it=E2=80=99s fine to apply the patch with these minor changes= . > > > > > > -- > > > Ricardo > > I had problem with applying this directly with git am, it > kept telling me the patch is corrupt on line 10. > Can someone have a look? > My bad, but it seems that at least partially debbugs is responsible for thi= s, It broke the long line in the patch, and it simply wrapped it around. I downloaded the message from there using mbox. As there was no space before the start of the line, the patch became corrupted. Do you think this is bug? I believe debbugs should not alter line endings. > > > > Thanks Ricardo for the fast review! > > > > Best regards, > > g_bor > > Best regards, > g_bor Best regards, g_bor