From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecRnO-0007It-6X for guix-patches@gnu.org; Fri, 19 Jan 2018 03:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecRnJ-0000jS-TX for guix-patches@gnu.org; Fri, 19 Jan 2018 03:13:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecRnJ-0000jI-PZ for guix-patches@gnu.org; Fri, 19 Jan 2018 03:13:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecRnJ-0005Qn-Hb for guix-patches@gnu.org; Fri, 19 Jan 2018 03:13:01 -0500 Subject: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <87efmmtky1.fsf@gmail.com> References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Fri, 19 Jan 2018 09:11:58 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c05921a71bf3205631ca28f" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: Ricardo Wurmus , 29896@debbugs.gnu.org --94eb2c05921a71bf3205631ca28f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Actually I did forget to check if it is used runtime. It is used to build and OSGi bundle. At first I tried to fake the dependency like for the ant tasks, but I got compilation errors. 2018-01-19 7:35 GMT+01:00 Chris Marusich : > G=C3=A1bor Boskovits writes: > > > + (inputs > > + `(("java-aqute-bndlib" ,java-aqute-bndlib) > > + ("java-aqute-libg" ,java-aqute-libg))) > > (arguments > > `(#:build-target "compile" > > ;; The tests require an old version of Janino, which no longer > compiles > > @@ -2679,7 +2682,9 @@ archives (jar).") > > #:tests? #f > > ;; We don't need these extra ant tasks, but the build system > asks us to > > ;; provide a path anyway. > > - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3D > foo")) > > + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3D > foo") > > + (string-append "-Dbiz.aQute.bnd.path=3D" > > + (assoc-ref %build-inputs > "java-aqute-bndlib"))) > > Even though we added some inputs, there appear to be no retained > references in the output, as shown by this command: > > guix gc --referrers $(./pre-inst-env guix build java-asm) > > Is this expected? At first blush, this seems reasonable only if > java-aqute-bndlib and java-aqute-libg are not required at runtime. > Perhaps Ricardo knows more, since he has more experience working with > the ant-build-system. > > -- > Chris > --94eb2c05921a71bf3205631ca28f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Actually I did forget to check if it is used runtime.
= It is used to build and OSGi bundle.
At first I tried to fake the= dependency like for the ant tasks,
but I got compilation errors.=

2018-= 01-19 7:35 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
G=C3=A1bor Boskovits = <boskovits@gmail.com> writ= es:

> +=C2=A0 =C2=A0 (inputs
> +=C2=A0 =C2=A0 =C2=A0`(("java-aqute-bndlib" ,java-aqute-bndl= ib)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("java-aqute-libg" ,java-aqute-l= ibg)))
>=C2=A0 =C2=A0 =C2=A0 (arguments
>=C2=A0 =C2=A0 =C2=A0 =C2=A0`(#:build-target "compile"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; The tests require an old version o= f Janino, which no longer compiles
> @@ -2679,7 +2682,9 @@ archives (jar).")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:tests? #f
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; We don't need these extra ant = tasks, but the build system asks us to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; provide a path anyway.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags (list (string-append "-D= objectweb.ant.tasks.path=3Dfoo"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags (list (string-append "-D= objectweb.ant.tasks.path=3Dfoo")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 (string-append "-Dbiz.aQute.bnd.path=3D" > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(assoc-ref %build-inputs "java-aqute-bndlib")))

Even though we added some inputs, there appear to be no retained
references in the output, as shown by this command:

=C2=A0 guix gc --referrers $(./pre-inst-env guix build java-asm)

Is this expected?=C2=A0 At first blush, this seems reasonable only if
java-aqute-bndlib and java-aqute-libg are not required at runtime.
Perhaps Ricardo knows more, since he has more experience working with
the ant-build-system.

--
Chris

--94eb2c05921a71bf3205631ca28f--