From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIaMp-0008DL-Ek for guix-patches@gnu.org; Fri, 02 Nov 2018 10:24:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIaMk-0007tj-Kx for guix-patches@gnu.org; Fri, 02 Nov 2018 10:24:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIaMk-0007ta-Fg for guix-patches@gnu.org; Fri, 02 Nov 2018 10:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gIaMk-00026A-Am for guix-patches@gnu.org; Fri, 02 Nov 2018 10:24:02 -0400 Subject: [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) Resent-Message-ID: MIME-Version: 1.0 References: <20181029212738.75de1734@alma-ubu> <20181102143154.555e711f@alma-ubu> In-Reply-To: <20181102143154.555e711f@alma-ubu> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Fri, 2 Nov 2018 15:23:04 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: Lakshmi Prasannakumar , 33214@debbugs.gnu.org Bj=C3=B6rn H=C3=B6fling ezt =C3=ADrta (= id=C5=91pont: 2018. nov. 2., P, 14:31): > > Hi Lakshmi, > > On Fri, 2 Nov 2018 18:25:49 +0530 > Lakshmi Prasannakumar wrote: > > > Sure, I'll rebase it to the current master and try to bring in the > > change for commit message . > > > > Regards, > > > > (For the reference, applied it on top of > 7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble= ). > > I have some more remarks: > > * Could you please keep the bug-tracker on CC. In that way other people > can follow the discussions and it is saved for later reference. That is > especially useful if the patch gets forgotten and is only later being > picked up again (though I don't think that will be the case here): > > 33214@debbugs.gnu.org > > * As Gabor already said, the period "." was missing. See other commit > messages to get used to the strict rules. > > * License field should look like this: > > (license license:gpl2+))) > > I.e. it is prefixed by "license:". That is because in line 31 the > license module was imported with that prefix: > > #:use-module ((guix licenses) #:prefix license:) > > Some package modules use this syntax to prevent namespace pollution, > others not. > > * Did you execute `guix lint` before submitting the patch? I have > found some linter complaints: > > /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: sente= nces in description should be followed by two spaces; possible infractions = at 197, 389 > /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: line = 6671 is way too long (468 characters) > > * The first one just means what it says. That is because the > descriptions use texinfo syntax and there are two spaces used. > > * The second can be solved by breaking long lines of the description > before 80 characters. See how it was done in other packages above. > > * Homepage: > > gnu/packages/cran.scm:6652:0: r-weights@1.0: permanent redirect > from http://cran.r-project.org/web/packages/weights > to http://cran.r-project.org/web/packages/weights/ > > So please add a trailing "/" to the URL. > > Also could you use "https"? instead of just plain "http"? We use the > encrypted URL wherever it is available. > Thanks Bj=C3=B6rn. It seems that currently Lakshmi has no working guix, because of problems related to missing substiutes. > * I'm currently trying to build it but that looks like it takes more > time than usual because substitutes are missing. If anything goes > wrong, I will report back. Did you try to build the package? > > Thank you, > > Bj=C3=B6rn