From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: [outreach] Help trying to create R package Date: Fri, 19 Oct 2018 23:25:41 +0200 Message-ID: References: <20181016074412.54757b18@alma-ubu> <20181016082350.75757e6b@alma-ubu> <20181017001851.71543cc9@alma-ubu> <20181017091750.1c408b8d@alma-ubu> <20181018085424.541e9287@alma-ubu> <87va5zktpa.fsf@elephly.net> <87r2gml8ec.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDcHP-0000ZP-Hz for guix-devel@gnu.org; Fri, 19 Oct 2018 17:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDcHN-0006PA-Ij for guix-devel@gnu.org; Fri, 19 Oct 2018 17:25:59 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:42518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDcHL-0006BW-E9 for guix-devel@gnu.org; Fri, 19 Oct 2018 17:25:57 -0400 Received: by mail-oi1-x241.google.com with SMTP id w81-v6so27915549oiw.9 for ; Fri, 19 Oct 2018 14:25:54 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Laura Lazzati Cc: Guix-devel Hello Laura, Laura Lazzati ezt =C3=ADrta (id=C5=91pont: 201= 8. okt. 19., P, 22:35): > > On Fri, Oct 19, 2018 at 3:45 PM G=C3=A1bor Boskovits wrote: > > > > Hello Laura, > > > > Laura Lazzati ezt =C3=ADrta (id=C5=91pont:= 2018. > > okt. 19., P, 20:37): > > > > > > On Fri, Oct 19, 2018 at 4:29 AM G=C3=A1bor Boskovits wrote: > > > > > > > > Hello Ricardo, > > > > > > > > Ricardo Wurmus ezt =C3=ADrta (id=C5=91pont: 20= 18. okt. 19., P 9:10): > > > >> > > > >> > > > >> Hi Laura, > > > >> > > > >> > with guix environment --pure guix --ad-hoc coreutils findutils w= hich (or -C) > > > >> > I get, the output: > > > >> > Command 'lesspipe' is available in the following places > > > >> > * /bin/lesspipe > > > >> > * /usr/bin/lesspipe > > > >> > The command could not be located because '/bin:/usr/bin' is not > > > >> > included in the PATH environment variable. > > > >> > lesspipe: command not found > > > >> > > > >> This is because your shell initialization code (e.g. to set up the > > > >> prompt) refers to lesspipe. You can ignore this or remove the fan= cy > > > >> initialization. > > > >> > > > >> > There, I run which guix and get: > > > >> > which: no guix in > > > >> > (/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/bin:/gnu/st= ore/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/sbin) > > > >> > > > >> That=E2=80=99s because =E2=80=9C--pure=E2=80=9D resets the PATH; t= hat=E2=80=99s by design. The only > > > >> problem you have is that your Guix is located elsewhere. But why = do you > > > >> need Guix itself inside of an environment to build Guix? > > > >> > > > >> The point of using =E2=80=9Cguix environment --pure guix=E2=80=9D = is only to enter a > > > >> clean environment containing everything you need to build Guix fro= m > > > >> source. So once you=E2=80=99re inside of this environment you can= run the > > > >> bootstrap and configure scripts, and run make to compile the sourc= es. > > > >> > > > >> To *use* that Guix you just built you need to use =E2=80=9C./pre-i= nst-env guix=E2=80=9D > > > >> from the source directory. > > > >> > > > >> > The closest I got was by setting: > > > >> > PATH=3D$PATH:/usr/bin/:/bin > > > >> > PATH=3D$PATH:/usr/local/bin > > > >> > > > >> This defeats the purpose of using =E2=80=9C--pure=E2=80=9D as thes= e directories contain > > > >> all sorts of things on a foreign distro, so you lose control over = the > > > >> environment. > > > > > > I am glad to tell you that I have followed all the commands, I will > > > copy some of them here just in case, and saved the output in my daily > > > journal of everything :) > > > > > > guix environment --pure guix --ad-hoc coreutils findutils which > > > ./bootstrap > > > ./configure --localstatedir=3D/var > > > make > > > echo $? ->got 0 > > > which guix -> got > > > no guix in (/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/bin:/= gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/sbin) > > > ./pre-inst-env guix package --help -> worked fine! > > > ./pre-inst-env guix package -i hello -> the same > > > ./pre-inst-env guix package -i emacs > > > export PATH=3D"/home/laura/.guix-profile/bin${PATH:+:}$PATH" > > > export INFOPATH=3D"/home/laura/.guix-profile/share/info${INFOPATH:+:}= $INFOPATH" > > > (with this two exports, I could run hello and emacs without problems) > > > ./pre-inst-env guix package -i nss-certs > > > Played a lot with > > > ./pre-inst-env guix build r-aspi > > > and > > > emacs gnu/packages/cran.scm > > > until I found out that there were syntax errors, mismatches in > > > parenthesis and so on, and in the last > > > ./pre-inst-env guix build r-aspi got: > > > ;;; note: source file /home/laura/guix/gnu/packages/cran.scm > > > ;;; newer than compiled /home/laura/guix/gnu/packages/cran.go > > > (still that) but: > > > > This is not a problem, it just indicates that you modified cran.scm, an= d it will > > use the .scm file instead, as the .go file was compiled from an older s= ource. > > > > > successfully built /gnu/store/bmapswnk9li1nscfpirgzsy3npw9hyql-r-aspi= -0.2.0.drv > > > /gnu/store/a3apqwf4hy67ms462hn802gk89x99mzh-r-aspi-0.2.0 > > > > > > > That's great! > > > > > I am following the contribution guide now, to send the patch, I ran > > > ./pre-inst-env guix lint r-aspi > > > ;;; note: source file /home/laura/guix/gnu/packages/cran.scm > > > ;;; newer than compiled /home/laura/guix/gnu/packages/cran.go > > > fetching CVE database for 2018... > > > fetching CVE database for 2017... > > > fetching CVE database for 2016... > > > fetching CVE database for 2015... > > > > > > Is this output OK? > > > > > > > Yes, this output is just fine. > I have already run all the commands suggested in > https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.= html#Submitting-Patches > I have never used git format-patch before, I am reading documentation > about it but I am not very sure about how to apply it to my package, > could you help me in clarifying this last step? Once you made a commit, and you are statisfied with it, then you can run: git format-patch -1 to create a patch form the last commit. I would store it somewhere outside the repository, so that it does not get in your way later as an utracked file. You can also specify the output directory directly with -o. Once this is done, a patch file is created, with a name resembling the commit message. You can then do: git send-email It will ask for the e-mail address you want to send to, you should specify the guix-patches mailinglist. Hope that helps. > > > > > > > > > > > > > > Sorry, my bad, I missed that. > > > > > > > >> > > > >> -- > > > >> Ricardo > > > > > > > > g_bor > > > > > > Regards! > > > Laura > > Best regards, > > g_bor > > Regards :) > Laura Best regards, g_bor