From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Wed, 3 Jan 2018 14:06:31 +0100 Message-ID: References: <87609h3dzk.fsf@gmail.com> <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> <877etiz7uu.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f4f5e8067b98625d8d0561dee2c7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWike-0007Bc-G6 for guix-devel@gnu.org; Wed, 03 Jan 2018 08:06:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWikc-0004Np-ST for guix-devel@gnu.org; Wed, 03 Jan 2018 08:06:36 -0500 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:33737) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWikc-0004Mk-Lp for guix-devel@gnu.org; Wed, 03 Jan 2018 08:06:34 -0500 Received: by mail-io0-x236.google.com with SMTP id t63so2036470iod.0 for ; Wed, 03 Jan 2018 05:06:33 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --f4f5e8067b98625d8d0561dee2c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2017-12-21 8:53 GMT+01:00 G=C3=A1bor Boskovits : > 2017-12-20 13:29 GMT+01:00 G=C3=A1bor Boskovits : > >> 2017-12-20 11:34 GMT+01:00 G=C3=A1bor Boskovits : >> >>> 2017-12-19 23:11 GMT+01:00 Ricardo Wurmus : >>> >>>> >>>> G=C3=A1bor Boskovits writes: >>>> >>>> > Now I have another blocking issue: >>>> > https://github.com/Boskovits/guix/issues/24 >>>> >>>> > Error message: >>>> > >>>> > BUILD FAILED >>>> > /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.xml:654: >>>> > Problem: failed to create task or type junit >>>> > Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUnitT= ask >>>> was >>>> > not found. >>>> >>>> Is it not just enough to add junit to the inputs of java-bsh? >>>> >>>> No, unfortunately it seems to affect all packages using junit. >>> I guess it is because I use ant/java8, and maybe that is more fussy >>> about this... >>> >>> It seems, that we should add the lib flag to the nat commend line, if w= e >> have >> junit as input. However junit has quite a big dependency graph with the >> new >> hamcrest-core fix, but that is needed for junit. I think we should >> discuss our options here, >> I don't feel comfortable to make such a decision without prior discussio= n. >> >> Regarding this issue, in my opinion we cloud do the following: > Add two parameters to ant build system: > junit? > junit > If junit? then force use of junit, if not, then force not to use it, if > unspecified check if we have junit in build.inputs, and use it if it is. > junit should default to java-junit, like we have for icedtea, and ant. > Can something like this be done? > It would be nice if the ant-build-system needed junit only if it is in > build-inputs, or explicitly requested, so > that we can still use it while we don't have junit. > WDYT? > Ok, i've settled the issue with junit, it boils down to the following things: 1. We need to add ant-junit as a native-input to the packages using junit. 2. We need to add ant-junit4.jar to ant-junit, so that junit4 can find the tests. Now I have the following problem, it is in java-asm: If I understand well, then the check phase in ant-build-system runs without make-flags. In the definition of java-asm we configure the build with make-flags, so the build system does not complain about missing configuration. This configuration is still needed for the test target, so building that fails. We could do two things: 1. Patch build.xml to not perform these checks. (Then we can also remove the make-flags all togethet) 2. Do something, so that we can pass make-flags to check phase, maybe by introducing test-make-flags, or something like that to ant-build-system. For now I will just disable test, so that I can go on, but I would be glad if you could recommend me an approch on this, I this that #2 worth it only, if it affects multiple packages. I will have a look at that. > > >> In the meanwhile I will create an integration branch, and start to creat= e >> a list of patches that >> can be merged to core-updates. >> >> Where should I send those? >> >> >>> >>> >>>> -- >>>> Ricardo >>>> >>>> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC >>>> https://elephly.net >>>> >>>> >>>> >>> >> > --f4f5e8067b98625d8d0561dee2c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2017= -12-21 8:53 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com><= /span>:
2017-12-20 13:29 GMT+01:00 G=C3=A1bor Boskovits <= boskovits@gmail.co= m>:
20= 17-12-20 11:34 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com&g= t;:
2017-12-1= 9 23:11 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> Now I have another blocking issue:
> https://github.com/Boskovits/guix/issues/24=

> Error message:
>
> BUILD FAILED
> /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.x= ml:654:
> Problem: failed to create task or type junit
> Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUn= itTask was
> not found.

Is it not just enough to add junit to the inputs of java-bsh?

No, = unfortunately it seems to affect all packages using junit.
I gues= s it is because I use ant/java8, and maybe that is more fussy about this...=

It seems, that we should add the lib flag to the nat commend line, if we = have
junit as input. However junit has quite a big dependency gra= ph with the new
hamcrest-core fix, but that is needed for junit. = I think we should discuss our options here,
I don't feel comf= ortable to make such a decision without prior discussion.

Regarding this issue, in my o= pinion we cloud do the following:
Add two parameters to ant build= system:
junit?
junit
If junit? then force us= e of junit, if not, then force not to use it, if unspecified check if we ha= ve junit in build.inputs, and use it if it is.
junit should defau= lt to java-junit, like we have for icedtea, and ant.
Can somethin= g like this be done?
It would be nice if the ant-build-system nee= ded junit only if it is in build-inputs, or explicitly requested, so
<= div>that we can still use it while we don't have junit.
WDYT?=

Ok, i've settled the issue with junit, it boils down = to the following things:

1. We need to add ant-junit as = a native-input to the packages using junit.
2. We need to add ant= -junit4.jar to ant-junit, so that junit4 can find the tests.

=
Now I have the following problem, it is in java-asm:
<= br>
If I understand well, then the check phase in ant-build-syste= m
runs without make-flags.
In the definition of java-as= m we configure the build with make-flags, so the build system
doe= s not complain about missing configuration.
This configuration is= still needed for the test target, so building that fails.

We could do two things:
1. Patch build.xml to not perfor= m these checks. (Then we can also remove the make-flags all togethet)
=
2. Do something, so that we can pass make-flags to check phase, maybe = by introducing test-make-flags, or something like that to ant-build-system.=

For now I will just disable test, so that I can g= o on, but I would be glad if you could recommend me an approch on this,
I this that #2 worth it only, if it affects multiple packages. I wil= l have a look at that.
=C2=A0
=C2=A0
In the meanwhile I will create= an integration branch, and start to create a list of patches that
can be merged to core-updates.

Where should I se= nd those?
=C2=A0
=C2=A0
--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net






--f4f5e8067b98625d8d0561dee2c7--