From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Next steps Date: Tue, 26 Jun 2018 22:01:51 +0200 Message-ID: References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net> <02e1a59a-ebc1-dfce-e1d6-22e97e742214@swecha.net> <874lifypeb.fsf@elephly.net> <648f81fc-0607-2c3b-f9a3-ca3b29cd637b@swecha.net> <87bmck22uz.fsf@elephly.net> <8736xv1xvq.fsf@elephly.net> <64dfaf0c-3bcf-7b76-5831-b1c41d3f5563@swecha.net> <877en4ccut.fsf@elephly.net> <2b03fcec-c2d8-0604-156c-70fe7643a6cb@swecha.net> <87zhzzbqn6.fsf@elephly.net> <8f509759-c798-a150-bf5a-9b13cd07ac5b@swecha.net> <87lgbibir5.fsf@elephly.net> <564233bd-9511-7f84-3350-6a3a905534a8@swecha.net> <87r2l767sg.fsf@elephly.net> <874lhwtn5a.fsf@elephly.net> <204a32d1-f216-dedd-2234-cd05e3d406a9@swecha.net> <4b5ce9b0-a2d1-30e3-489b-a0028d227c5c@swecha.net> <87k1qmmx0m.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d6f43f056f90f808" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXuAC-00044U-TB for guix-devel@gnu.org; Tue, 26 Jun 2018 16:02:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXuAB-0005e1-Kv for guix-devel@gnu.org; Tue, 26 Jun 2018 16:02:08 -0400 In-Reply-To: <87k1qmmx0m.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Sahitihi , guix-devel --000000000000d6f43f056f90f808 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ricardo Wurmus ezt =C3=ADrta (id=C5=91pont: 2018. j=C3= =BAn. 25., H 22:29): > > Hi Sahithi, > > > I think I am done with basic changes for 4th task. File is attached. As > > mentioned in IRC output is in escape code sequence when I tried in REPL= . > > Great. Please change ui.scm directly and send a patch that can be > applied to the wip-sahithi branch. > Hello Sahithi, Any update on this? Please also pay attention to these things: > > * indent the lines properly (Emacs does the right thing when you hit TAB) > * don=E2=80=99t leave extraneous comments or dead code > * make sure long expressions are broken up > > >> I am done with 2nd task out of given 4 tasks and that was included in = my > >> previous patch. > >> I am currently working on 4th task. > > I am able to filter lines. > > I am trying out to*only* filter lines when =E2=80=9Cguix package=E2=80= =9D is used but > > not when =E2=80=9Cguix build=E2=80=9D by adding other port. > > The next step here would be to not print a dot for each line but to > display a spinner instead, i.e. a sequence of characters that look like > a spinning animation. For each line the animation could be advanced by > one (so it will spin really fast). > > Danny previously suggested this implementation: > > https://lists.gnu.org/archive/html/guix-patches/2017-07/msg00068.html > > You may be able to take a part of that patch and adapt it. The key here > is really: keep track of the animation position and use backspace to > delete the previously printed character before displaying the next. > > If you don=E2=80=99t like the spinner animation you could also pick one o= f > these and try implementing them instead: > > https://stackoverflow.com/questions/2685435/cooler-ascii-spinners > > Have fun! > > -- > Ricardo > > --000000000000d6f43f056f90f808 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= Ricardo Wurmus <rekado@elephly.net= > ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn. 25., H 22:29):

Hi Sahithi,

> I think I am done with basic changes for 4th task. File is attached. A= s
> mentioned in IRC output is in escape code sequence when I tried in REP= L.

Great.=C2=A0 Please change ui.scm directly and send a patch that can be
applied to the wip-sahithi branch.


Hello Sahithi= ,
Any update on this?

Please also pay attention to these things:

* indent the lines properly (Emacs does the right thing when you hit TAB) * don=E2=80=99t leave extraneous comments or dead code
* make sure long expressions are broken up

>> I am done with 2nd task out of given 4 tasks and that was included= in my
>> previous patch.
>> I am currently working on 4th task.
> I am able to filter lines.
> I am trying out to*only* filter lines when =E2=80=9Cguix package=E2=80= =9D is used but
> not when =E2=80=9Cguix build=E2=80=9D by adding other port.

The next step here would be to not print a dot for each line but to
display a spinner instead, i.e. a sequence of characters that look like
a spinning animation.=C2=A0 For each line the animation could be advanced b= y
one (so it will spin really fast).

Danny previously suggested this implementation:

=C2=A0 =C2=A0https:/= /lists.gnu.org/archive/html/guix-patches/2017-07/msg00068.html

You may be able to take a part of that patch and adapt it.=C2=A0 The key he= re
is really: keep track of the animation position and use backspace to
delete the previously printed character before displaying the next.

If you don=E2=80=99t like the spinner animation you could also pick one of<= br> these and try implementing them instead:

=C2=A0 =C2=A0https://sta= ckoverflow.com/questions/2685435/cooler-ascii-spinners

Have fun!

--
Ricardo

--000000000000d6f43f056f90f808--