From: "Gábor Boskovits" <boskovits@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 29700-done@debbugs.gnu.org
Subject: bug#29700: Java packages need to retain references
Date: Fri, 15 Dec 2017 07:44:36 +0100 [thread overview]
Message-ID: <CAE4v=pgRq8kpyducM+7AcCYOrS78w_GSbR9m65-29t+O1fkung@mail.gmail.com> (raw)
In-Reply-To: <87mv2kvrud.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]
Do we know the impact of disabling compression?
I don't think it is really a big problem.
You are right with this, I'm still a bit stuck in another mindset, where we
usually know, that we have only one version of a package...
If we later decide that compression is desired we can still go with a text
file with references.
Anyway, do you think that extending the reference scanner would be a good
idea?
2017-12-14 23:59 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:
> Hi Gábor,
>
> The manifest file would not be sufficient. Take the example of
> “java-usb4java”. It provides a file “share/java/usb4java.jar”, which
> contains this manifest:
>
> --8<---------------cut here---------------start------------->8---
> Manifest-Version: 1.0
> Created-By: 1.7.0_161 (Oracle Corporation)
>
> --8<---------------cut here---------------end--------------->8---
>
> When you open the Loader.class file that is included in the archive you
> will notice that it contains this string:
>
> /gnu/store/iwjqaqr98daqbgwswqi5fi4w891bqh7d-libusb4java-0-1.396d642a5/
> lib/libusb4java.so
>
> This reference is currently dropped because it cannot be detected in a
> compressed archive. The reference is not contained in the manifest, and
> at build time we could only guess which references should be added to
> the manifest.
>
> Unless we extend the reference scanner to deal with compressed files I
> think that disabling compression in jars is the best approach.
>
> I’ll push this to master.
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>
[-- Attachment #2: Type: text/html, Size: 2223 bytes --]
next prev parent reply other threads:[~2017-12-15 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 22:48 bug#29700: Java packages need to retain references Ricardo Wurmus
2017-12-13 23:09 ` bug#29700: [PATCH] guix: ant-build-system: Do not compress jars Ricardo Wurmus
2017-12-14 8:23 ` Danny Milosavljevic
2017-12-14 22:59 ` bug#29700: Java packages need to retain references Ricardo Wurmus
2017-12-15 6:44 ` Gábor Boskovits [this message]
2017-12-15 7:49 ` Ricardo Wurmus
2017-12-15 14:55 ` Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2017-12-13 22:28 bug#29705: " Ricardo Wurmus
2017-12-14 7:07 ` Gábor Boskovits
2017-12-14 22:22 ` bug#29700: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=pgRq8kpyducM+7AcCYOrS78w_GSbR9m65-29t+O1fkung@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=29700-done@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.