bug#30569: Packages count as installed twice

bug#30569: Packages count as installed twice

[Andreas Enge]

Hello,

trying to upgrade my packages, I notice something curious:

$ ./pre-inst-env guix package -n -u
The following packages would be upgraded:
...
   gnutls	3.5.13 -> 3.5.13	/gnu/store/1ah3fd12w6v66q6yjdmd39xbisqi0gpw-gnutls-3.5.13
   gnutls	3.5.13 -> 3.5.13	/gnu/store/1ah3fd12w6v66q6yjdmd39xbisqi0gpw-gnutls-3.5.13
...

There is twice the exactly same package!

$ ./pre-inst-env guix package -I gnutls
gnutls	3.5.13	out	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13
gnutls	3.5.13	out	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13

This looks like a bug to me...

Andreas

bug#30569: Packages count as installed twice

[Ricardo Wurmus]

Hi Andreas,

> trying to upgrade my packages, I notice something curious:
>
> $ ./pre-inst-env guix package -n -u
> The following packages would be upgraded:
> ...
>    gnutls	3.5.13 -> 3.5.13	/gnu/store/1ah3fd12w6v66q6yjdmd39xbisqi0gpw-gnutls-3.5.13
>    gnutls	3.5.13 -> 3.5.13	/gnu/store/1ah3fd12w6v66q6yjdmd39xbisqi0gpw-gnutls-3.5.13
> ...

Does the package appear twice in the profile’s “manifest” file
(e.g. ~/.guix-profile/manifest)?

I’m not sure how it could have ended up there, but one possibility might
be that you had two different versions of gnutls and they have both been
upgraded to the latest version.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#30569: Packages count as installed twice

[Andreas Enge]

Hello,

On Wed, Feb 21, 2018 at 08:52:28PM +0100, Ricardo Wurmus wrote:
> Does the package appear twice in the profile’s “manifest” file
> (e.g. ~/.guix-profile/manifest)?

no, I am not using a manifest and do things by hand all the time.

> I’m not sure how it could have ended up there, but one possibility might
> be that you had two different versions of gnutls and they have both been
> upgraded to the latest version.

This is a plausible explanation.

I ended up running this command:

$ ./pre-inst-env guix package -r gnutls -i gnutls
guile: warning: failed to install locale
warning: failed to install locale: Invalid argument
guix package: warning: Consider running 'guix pull' followed by
'guix package -u' to get up-to-date packages and security updates.

The following packages will be removed:
   gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13
   gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13

The following package will be upgraded:
   gnutls	3.5.13 -> 3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13

Then I ended up with only one listed.

Anyway, I do not think it did any harm, but it could indicate a bug somewhere
in the code.

Andreas

bug#30569: Packages count as installed twice

[Ricardo Wurmus]

Andreas Enge <andreas@enge.fr> writes:

> On Wed, Feb 21, 2018 at 08:52:28PM +0100, Ricardo Wurmus wrote:
>> Does the package appear twice in the profile’s “manifest” file
>> (e.g. ~/.guix-profile/manifest)?
>
> no, I am not using a manifest and do things by hand all the time.

Even so, you’ll have a file called “manifest” in the profile directory.
This is unrelated to whether you used a manifest to create the profile
or not.

(This is the second naming conflict in Guix.  The other is “services”
for system services and shepherd services.)

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#30569: Packages count as installed twice

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

On Wed, Feb 21, 2018 at 10:34:53PM +0100, Andreas Enge wrote:
> $ ./pre-inst-env guix package -r gnutls -i gnutls
> guile: warning: failed to install locale
> warning: failed to install locale: Invalid argument
> guix package: warning: Consider running 'guix pull' followed by
> 'guix package -u' to get up-to-date packages and security updates.
> 
> The following packages will be removed:
>    gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13
>    gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13
> 
> The following package will be upgraded:
>    gnutls	3.5.13 -> 3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13

It would be interesting to see the profile history. Was the second
gnutls introduced after the first one, or were they introduced together?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#30569: Packages count as installed twice

[Andreas Enge]

On Wed, Feb 21, 2018 at 11:14:21PM +0100, Ricardo Wurmus wrote:
> Even so, you’ll have a file called “manifest” in the profile directory.
> This is unrelated to whether you used a manifest to create the profile
> or not.

I see! Yes, it appeared twice.

On Wed, Feb 21, 2018 at 05:14:58PM -0500, Leo Famulari wrote:
> It would be interesting to see the profile history. Was the second
> gnutls introduced after the first one, or were they introduced together?

Unfortunately I cannot tell any more. I only kept the last ten profiles,
and all of the corresponding manifest entries contain two copies of the
same gnutls. Once both of them were updated.

Andreas

bug#30569: Packages count as installed twice

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Wed, Feb 21, 2018 at 11:14:21PM +0100, Ricardo Wurmus wrote:
>> Even so, you’ll have a file called “manifest” in the profile directory.
>> This is unrelated to whether you used a manifest to create the profile
>> or not.
>
> I see! Yes, it appeared twice.

Looking more closely, it’s actually possible even now to create a
profile with the exact same entry twice:

--8<---------------cut here---------------start------------->8---
$ guix package -p foo -i gnutls gnutls
La jenaj pakoj estos instalataj:
    gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13
   gnutls	3.5.13	/gnu/store/g09is0bw144d8zrd059fiarqmjq7vr8a-gnutls-3.5.13

substitute: updating list of substitutes from 'https://berlin.guixsd.org'... 100.0%
substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
La jenaj derivoj estos konstruataj:
   /gnu/store/viykf0jcxc9c51yl0p1023b75khad7jn-profile.drv
   /gnu/store/yi996sf93p8n15ijf27hcck1b6prywrl-info-dir.drv
   /gnu/store/ki7jrd29isi0l1zk93vrqd1p4by08nw7-fonts-dir.drv
   /gnu/store/0xkp49578vpjc7q96kyg052v4jhx439m-ca-certificate-bundle.drv
   /gnu/store/yxbrnjbxjcdx6nvs8l0wm8236mvx14l7-manual-database.drv
Creating manual page database...
144 entries processed in 0.1 s
pakoj 2 en profilo
La jenaj medi-variablaj difinoj povos esti necesaj:
   export PATH="foo/bin${PATH:+:}$PATH"
--8<---------------cut here---------------end--------------->8---

Weird, but no big deal since they are really the same entry.

(What’s *not* permitted is installing several “gnutls” packages having a
different store file name.  See ‘check-for-collisions’ in (guix
profiles).)

What should we do?  Status quo?  Throwing a ‘delete-duplicates’ call?
Let’s have a poll!  ;-)

Ludo’.

bug#30569: Packages count as installed twice

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 2428 bytes --]

2018-02-27 22:55 GMT+01:00 Ludovic Courtès <ludo@gnu.org>:

> Andreas Enge <andreas@enge.fr> skribis:
>
> > On Wed, Feb 21, 2018 at 11:14:21PM +0100, Ricardo Wurmus wrote:
> >> Even so, you’ll have a file called “manifest” in the profile directory.
> >> This is unrelated to whether you used a manifest to create the profile
> >> or not.
> >
> > I see! Yes, it appeared twice.
>
> Looking more closely, it’s actually possible even now to create a
> profile with the exact same entry twice:
>
> --8<---------------cut here---------------start------------->8---
> $ guix package -p foo -i gnutls gnutls
> La jenaj pakoj estos instalataj:
>     gnutls      3.5.13  /gnu/store/g09is0bw144d8zrd059fiarqmjq7vr
> 8a-gnutls-3.5.13
>    gnutls       3.5.13  /gnu/store/g09is0bw144d8zrd059fiarqmjq7vr
> 8a-gnutls-3.5.13
>
> substitute: updating list of substitutes from 'https://berlin.guixsd.org'...
> 100.0%
> substitute: updating list of substitutes from '
> https://mirror.hydra.gnu.org'... 100.0%
> La jenaj derivoj estos konstruataj:
>    /gnu/store/viykf0jcxc9c51yl0p1023b75khad7jn-profile.drv
>    /gnu/store/yi996sf93p8n15ijf27hcck1b6prywrl-info-dir.drv
>    /gnu/store/ki7jrd29isi0l1zk93vrqd1p4by08nw7-fonts-dir.drv
>    /gnu/store/0xkp49578vpjc7q96kyg052v4jhx439m-ca-certificate-bundle.drv
>    /gnu/store/yxbrnjbxjcdx6nvs8l0wm8236mvx14l7-manual-database.drv
> Creating manual page database...
> 144 entries processed in 0.1 s
> pakoj 2 en profilo
> La jenaj medi-variablaj difinoj povos esti necesaj:
>    export PATH="foo/bin${PATH:+:}$PATH"
> --8<---------------cut here---------------end--------------->8---
>
> Weird, but no big deal since they are really the same entry.
>
> (What’s *not* permitted is installing several “gnutls” packages having a
> different store file name.  See ‘check-for-collisions’ in (guix
> profiles).)
>
> What should we do?  Status quo?  Throwing a ‘delete-duplicates’ call?
> Let’s have a poll!  ;-)
>
>
I think if the manifest is generated automatically, then
duplicates can be removed automatically reducing clobber,
(most probably the user doesn't care anyways),
but when using a manifest file there should be a warning
about it, so the problem will not be retained.
(These users most probably care about this,
I think this can point to problematic manifest
authoring practices.)


> Ludo’.
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 3423 bytes --]

bug#30569: Packages count as installed twice

[Andreas Enge]

On Tue, Feb 27, 2018 at 10:55:05PM +0100, Ludovic Courtès wrote:
> What should we do?  Status quo?  Throwing a ‘delete-duplicates’ call?
> Let’s have a poll!  ;-)

The thing is confusing, and delete-duplicates should be essentially for free,
so I would support to call it. (Well, I filed the bug since I consider this
behaviour to be a bug, no big surprise then!)

Andreas

bug#30569: Packages count as installed twice

[Ricardo Wurmus]

Andreas Enge <andreas@enge.fr> writes:

> On Tue, Feb 27, 2018 at 10:55:05PM +0100, Ludovic Courtès wrote:
>> What should we do?  Status quo?  Throwing a ‘delete-duplicates’ call?
>> Let’s have a poll!  ;-)
>
> The thing is confusing, and delete-duplicates should be essentially for free,
> so I would support to call it. (Well, I filed the bug since I consider this
> behaviour to be a bug, no big surprise then!)

I agree.  I don’t see a reason to allow for the same package to appear
more than once in the manifest.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

bug#30569: Packages count as installed twice

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Andreas Enge <andreas@enge.fr> writes:
>
>> On Tue, Feb 27, 2018 at 10:55:05PM +0100, Ludovic Courtès wrote:
>>> What should we do?  Status quo?  Throwing a ‘delete-duplicates’ call?
>>> Let’s have a poll!  ;-)
>>
>> The thing is confusing, and delete-duplicates should be essentially for free,
>> so I would support to call it. (Well, I filed the bug since I consider this
>> behaviour to be a bug, no big surprise then!)
>
> I agree.  I don’t see a reason to allow for the same package to appear
> more than once in the manifest.

Alright, fixed in 435603a1d6106b535cf143d17cb030b2d0795b54, thanks!

Ludo’.