From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Thu, 21 Dec 2017 08:53:36 +0100 Message-ID: References: <87609h3dzk.fsf@gmail.com> <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> <877etiz7uu.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113949f0653e1d0560d4ff01" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRvfg-00031R-IA for guix-devel@gnu.org; Thu, 21 Dec 2017 02:53:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRvff-0000oC-8h for guix-devel@gnu.org; Thu, 21 Dec 2017 02:53:40 -0500 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]:37610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRvff-0000nk-2F for guix-devel@gnu.org; Thu, 21 Dec 2017 02:53:39 -0500 Received: by mail-io0-x22d.google.com with SMTP id d16so20120378iob.4 for ; Wed, 20 Dec 2017 23:53:38 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --001a113949f0653e1d0560d4ff01 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2017-12-20 13:29 GMT+01:00 G=C3=A1bor Boskovits : > 2017-12-20 11:34 GMT+01:00 G=C3=A1bor Boskovits : > >> 2017-12-19 23:11 GMT+01:00 Ricardo Wurmus : >> >>> >>> G=C3=A1bor Boskovits writes: >>> >>> > Now I have another blocking issue: >>> > https://github.com/Boskovits/guix/issues/24 >>> >>> > Error message: >>> > >>> > BUILD FAILED >>> > /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.xml:654: >>> > Problem: failed to create task or type junit >>> > Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUnitTa= sk >>> was >>> > not found. >>> >>> Is it not just enough to add junit to the inputs of java-bsh? >>> >>> No, unfortunately it seems to affect all packages using junit. >> I guess it is because I use ant/java8, and maybe that is more fussy abou= t >> this... >> >> It seems, that we should add the lib flag to the nat commend line, if we > have > junit as input. However junit has quite a big dependency graph with the n= ew > hamcrest-core fix, but that is needed for junit. I think we should discus= s > our options here, > I don't feel comfortable to make such a decision without prior discussion= . > > Regarding this issue, in my opinion we cloud do the following: Add two parameters to ant build system: junit? junit If junit? then force use of junit, if not, then force not to use it, if unspecified check if we have junit in build.inputs, and use it if it is. junit should default to java-junit, like we have for icedtea, and ant. Can something like this be done? It would be nice if the ant-build-system needed junit only if it is in build-inputs, or explicitly requested, so that we can still use it while we don't have junit. WDYT? > In the meanwhile I will create an integration branch, and start to create > a list of patches that > can be merged to core-updates. > > Where should I send those? > > >> >> >>> -- >>> Ricardo >>> >>> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC >>> https://elephly.net >>> >>> >>> >> > --001a113949f0653e1d0560d4ff01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2017= -12-20 13:29 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com&g= t;:
2017-12-20 11:34 = GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com>:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div class=3D"gmail_quote">2017-12-19 23:11 GMT+01:00 Ricardo Wurmus <= span dir=3D"ltr"><rekado@elephly.net>:

G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> Now I have another blocking issue:
> https://github.com/Boskovits/guix/issues/24=

> Error message:
>
> BUILD FAILED
> /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.x= ml:654:
> Problem: failed to create task or type junit
> Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUn= itTask was
> not found.

Is it not just enough to add junit to the inputs of java-bsh?

No, unfortunately it seems to affect all packages using ju= nit.
I guess it is because I use ant/java8, and maybe that is mor= e fussy about this...

It seems, that we should add the lib flag to the nat= commend line, if we have
junit as input. However junit has quite= a big dependency graph with the new
hamcrest-core fix, but that = is needed for junit. I think we should discuss our options here,
= I don't feel comfortable to make such a decision without prior discussi= on.

Regarding this = issue, in my opinion we cloud do the following:
Add two parameter= s to ant build system:
junit?
junit
If junit?= then force use of junit, if not, then force not to use it, if unspecified = check if we have junit in build.inputs, and use it if it is.
juni= t should default to java-junit, like we have for icedtea, and ant.
Can something like this be done?
It would be nice if the ant-bu= ild-system needed junit only if it is in build-inputs, or explicitly reques= ted, so
that we can still use it while we don't have junit.
WDYT?
=C2=A0
=
In the meanwhile I will create an integration branch, and start to cre= ate a list of patches that
can be merged to core-updates.

Where should I send those?
=C2= =A0
=C2=A0
--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net





--001a113949f0653e1d0560d4ff01--