From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44107) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTAsS-0001Dm-BK for guix-patches@gnu.org; Fri, 08 Nov 2019 15:29:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTAsQ-0004ci-Bw for guix-patches@gnu.org; Fri, 08 Nov 2019 15:29:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTAsQ-0004cU-1o for guix-patches@gnu.org; Fri, 08 Nov 2019 15:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTAsP-0001qa-RL for guix-patches@gnu.org; Fri, 08 Nov 2019 15:29:01 -0500 Subject: [bug#38075] [PATCH] services: mpd: add pulseaudio support Resent-Message-ID: MIME-Version: 1.0 References: <20191105224645.12269-1-robertsmith@posteo.net> <87eeyl8d1m.fsf@gnu.org> <87zhh6w3ey.fsf@nckx> In-Reply-To: <87zhh6w3ey.fsf@nckx> From: Peter Mikkelsen Date: Fri, 8 Nov 2019 21:28:05 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000006c54340596db9f80" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: Robert Smith , 38075@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Leo Famulari --0000000000006c54340596db9f80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Tobias, Unfortunately I don't use mpd anymore and I don't have a good understanding of how it works anymore. Cheers, Peter Mikkelsen fre. 8. nov. 2019 20.53 skrev Tobias Geerinckx-Rice : > Peter [CC'd], > > I see that you added the Guix MPD service in 2017, and wrote then > that it =E2=80=98uses pulseaudio for output=E2=80=99[0]. Do you have an = opinion > on this patch[1]? Did something change? > > Kind regards, > > T G-R > > [0]: http://guix.gnu.org/manual/en/html_node/Audio-Services.html > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38075 > > Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A > > Robert Smith skribis: > > > >> Set the XDG_RUNTIME_PATH environment variable in the mpd > >> service so > >> that it can detect pulseaudio when run under a user account. > >> --- > >> gnu/services/audio.scm | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm > >> index 471c5fd95f..424ccc7c8f 100644 > >> --- a/gnu/services/audio.scm > >> +++ b/gnu/services/audio.scm > >> @@ -140,6 +140,12 @@ audio_output { > >> "--no-daemon" > >> #$(mpd-config->file config)) > >> #:pid-file #$(mpd-file-name config "pid") > >> + #:environment-variables > >> + '(#$(string-append > >> + "XDG_RUNTIME_DIR=3D/run/user/" > >> + (number->string > >> + (passwd:uid > >> + (getpwnam (mpd-configuration-user > >> config)))))) > >> #:log-file #$(mpd-file-name config "log"))) > > > > I suppose this is meant for the libpulse client library, right? > > (I=E2=80=99m > > surprised it=E2=80=99s not the default, but apparently that=E2=80=99s t= he way it > > is.) > > > > Note that this also has an effect on mpd itself from what I can > > see in > > the source: mpd will listen to $XDG_RUNTIME_DIR/mpd/socket > > instead of > > (in addition to?) listening on TCP. > > > > I don=E2=80=99t use mpd myself; could you ensure that the socket change > > is also > > fine and doesn=E2=80=99t cause any troubles for mpd clients? > --0000000000006c54340596db9f80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Tobias,

U= nfortunately I don't use mpd anymore and I don't have a good unders= tanding of how it works anymore.=C2=A0

Cheers,
Peter Mikkelsen
fre. 8. = nov. 2019 20.53 skrev Tobias Geerinckx-Rice <me@tobias.gr>:
Peter [C= C'd],

I see that you added the Guix MPD service in 2017, and wrote then
that it =E2=80=98uses pulseaudio for output=E2=80=99[0].=C2=A0 Do you have = an opinion
on this patch[1]?=C2=A0 Did something change?

Kind regards,

T G-R

[0]: http://guix.gnu.org/manua= l/en/html_node/Audio-Services.html
[1]: https://debbugs.gnu.org/cgi/bu= greport.cgi?bug=3D38075

Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A
> Robert Smith <robertsmith@posteo.net> skribis:
>
>> Set the XDG_RUNTIME_PATH environment variable in the mpd
>> service so
>> that it can detect pulseaudio when run under a user account.
>> ---
>>=C2=A0 gnu/services/audio.scm | 6 ++++++
>>=C2=A0 1 file changed, 6 insertions(+)
>>
>> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
>> index 471c5fd95f..424ccc7c8f 100644
>> --- a/gnu/services/audio.scm
>> +++ b/gnu/services/audio.scm
>> @@ -140,6 +140,12 @@ audio_output {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0"--no-daemon"
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0#$(mpd-config->file config))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:pid-file #= $(mpd-file-name config "pid")
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:environment-var= iables
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'(#$(string-a= ppend
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0"XDG_RUNTIME_DIR=3D/run/user/"
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(number->string
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0(passwd:uid
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(getpwnam (mpd-configuration-user
>> config))))))
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:log-file #= $(mpd-file-name config "log")))
>
> I suppose this is meant for the libpulse client library, right?
> (I=E2=80=99m
> surprised it=E2=80=99s not the default, but apparently that=E2=80=99s = the way it
> is.)
>
> Note that this also has an effect on mpd itself from what I can
> see in
> the source: mpd will listen to $XDG_RUNTIME_DIR/mpd/socket
> instead of
> (in addition to?) listening on TCP.
>
> I don=E2=80=99t use mpd myself; could you ensure that the socket chang= e
> is also
> fine and doesn=E2=80=99t cause any troubles for mpd clients?
--0000000000006c54340596db9f80--