From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbCPa-0008Vg-Fp for guix-patches@gnu.org; Fri, 28 Jul 2017 17:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbCPX-0001Yx-9y for guix-patches@gnu.org; Fri, 28 Jul 2017 17:03:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbCPX-0001Yd-67 for guix-patches@gnu.org; Fri, 28 Jul 2017 17:03:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbCPW-0001CP-Cr for guix-patches@gnu.org; Fri, 28 Jul 2017 17:03:02 -0400 Subject: [bug#27856] [PATCH] gnu: erlang: Fix install-doc phase. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <874ltwl1pn.fsf@gnu.org> References: <20170728001051.1778-1-petermikkelsen10@gmail.com> <874ltwl1pn.fsf@gnu.org> From: Peter Mikkelsen Date: Fri, 28 Jul 2017 23:02:16 +0200 Message-ID: Content-Type: multipart/alternative; boundary="001a1144a22607074b055566ff08" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27856@debbugs.gnu.org --001a1144a22607074b055566ff08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Den 28. jul. 2017 22.57 skrev "Ludovic Court=C3=A8s" : Hi, Peter Mikkelsen skribis: > * gnu/packages/erlang.scm (erlang): Install > the man-pages to the correct directory. > --- > gnu/packages/erlang.scm | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm > index 07f117e28..6c702a2ba 100644 > --- a/gnu/packages/erlang.scm > +++ b/gnu/packages/erlang.scm > @@ -153,16 +153,15 @@ > (lambda* (#:key inputs outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (manpages (assoc-ref inputs "erlang-manpages")) > - (share (string-append out "/share/"))) > - (mkdir-p share) > - (mkdir-p (string-append share "/misc/erlang")) > - (with-directory-excursion share > + (release-dir (string-append out "/lib/erlang"))) > + (with-directory-excursion release-dir > (and > (zero? (system* "tar" "xvf" manpages)) > (rename-file "COPYRIGHT" > - (string-append share "/misc/erlang/COPYRIGHT")) > - ;; Delete superfluous file. > - (delete-file "PR.template"))))))))) > + (string-append release-dir "/misc/COPYRIGHT")) IIUC, this installs man pages and =E2=80=98COPYRIGHT=E2=80=99 to OUT/lib/er= lang, right? Shouldn=E2=80=99t it go to OUT/share/erlang instead? Thanks, Ludo=E2=80=99. Yes it does, and I found out that Erlang looks for man pages in /gnu/store/.....erlang../lib/erlang/man This can be verified by the output of running "erl -man -w" You are right it seems a bit odd, but to my understanding that is just how it is :) --001a1144a22607074b055566ff08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Den 28. jul. 2017 22.57 skrev "Ludovic Court=C3=A8s" &l= t;ludo@gnu.org>:
Hi,
Peter Mikkelsen <petermikkelsen10@gmail.com> skribis:

> * gnu/packages/erlang.scm (erlang): Install
>=C2=A0 =C2=A0the man-pages to the correct directory.
> ---
>=C2=A0 gnu/packages/erlang.scm | 13 ++++++-------
>=C2=A0 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index 07f117e28..6c702a2ba 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -153,16 +153,15 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda* (#:key inputs = outputs #:allow-other-keys)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let* ((out (ass= oc-ref outputs "out"))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (manpages (assoc-ref inputs "erlang-manpages"))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (share (string-append out "/share/")))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(mkdir-p share)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(mkdir-p (string-appe= nd share "/misc/erlang"))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(with-directory-excur= sion share
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (release-dir (string-append out "/lib/erlang")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(with-directory-excur= sion release-dir
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(and
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(z= ero? (system* "tar" "xvf" manpages))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r= ename-file "COPYRIGHT"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (string-append share "/misc/erlang= /COPYRIGHT"))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Dele= te superfluous file.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete= -file "PR.template")))))))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (string-append release-dir "/misc/= COPYRIGHT"))

IIUC, this installs man pages and =E2=80=98COPYRIGHT=E2=80=99 to OUT/= lib/erlang, right?
Shouldn=E2=80=99t it go to OUT/share/erlang instead?

Thanks,
Ludo=E2=80=99.
Yes it does, and I found out that Erlang looks for man p= ages in /gnu/store/.....erlang../lib/erlang/man

T= his can be verified by the output of running "erl -man -w"
<= div class=3D"gmail_extra" dir=3D"auto">
You are right it seems a bit odd, but to my understanding tha= t is just how it is :)
--001a1144a22607074b055566ff08--