Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Vijayalakshmi Vedantham]

[-- Attachment #1.1.1: Type: text/plain, Size: 3935 bytes --]

Got it. CC-ing them.

I created a patch file for the package definition of python-logwrap that
I'm including here. I'm a little unsure if my patch is right because my ./
pre-inst-env.in guix build r-abbyyR fails with some error.


Also, since we are going to be communicating regularly now,
1. I'd like to know the best times to contact you.
2. I need some help finishing my Outreachy application, so anytime in the
next 2 days if you could set aside an hour for us to discuss the goals of
the project etc it'll be great.

Thanks,
Vijayalakshmi

On Mon, Mar 19, 2018 at 6:10 AM, Ricardo Wurmus <rekado@elephly.net> wrote:

>
> Hi Vijayalakshmi,
>
> Thanks again for your first successful contribution to Guix!  Don’t
> forget to record your contribution on the Outreachy website.
>
> You may have noticed that there was a lot of output when running “guix
> build r-abbyyr”.  The same is true when running “guix package -i
> r-abbyyr”, which will install the package into your default profile
> after building it (when no pre-built package is offered by our build
> farm).  The project’s goal – among others — is to make all this output
> less intimidating, especially when using “guix package -i”.
>
> > I'm excited to continue working. What other tasks do you have in mind?
> > Should I add more packages or do something else?
>
> Let’s take a closer look at the package you created.
>
> The whole thing is a variable definition.  You defined the public
> variable “r-abbyyr” and bound a package value to it.  In Scheme that’s
> how you define a variable with the name “a” and a value of 12:
>
>     (define a 12)
>
> Your package definition is not so different from that:
>
>     (define r-abbyyr (package …))
>
> In Scheme whatever thing comes first in a parenthetical expression is
> usually either a procedure or a special form.  If it is a procedure,
> everything that follows is an argument.  Here’s an example:
>
>     (+ 1 2 3 4 5 10)
>
> The first element in this expression is “+”, which is a procedure that
> adds its arguments.  All the numbers that follow are arguments to that
> procedure.  When this expression is evaluated, the result is the sum of
> all these numbers: 15.
>
> “package” is a special form that takes a bunch of fields and values and
> produces a package object.  Let’s look at one particular field that the
> “package” form provides: the “build-system” field.
>
> As an R package “r-abbyyr” used the “r-build-system”.  The value of the
> “r-build-system” variable is defined in “guix/build-system/r.scm”, and
> it completely describes how an R package is to be built with Guix.  We
> support more build systems in Guix, but all of them have the same
> features in common: they all provide so-called build phases that are
> executed in order.  Each build phase is just a procedure.
>
> As a next task I would suggest to browse the source code of Guix to see
> what build systems are offered by Guix.  The build phases for the R
> build system, for example, are defined as “%standard-phases” in
> “guix/build/r-build-system.scm”.
>
> Maybe you can try to create a package definition for another application
> that uses a different build system.  How about a simple Python package
> from pypi?  Where are the build phases for a Python package defined?
> What is the build system that is used for Python packages?
>
> PS: what do you think about Cc-ing the public guix-devel@gnu.org mailing
> list for future communication?  The benefit is that this list is
> archived and accessible by anyone, such as future contributors.  And in
> case I make a mistake and explain something poorly others will have a
> chance to correct me :)
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>

[-- Attachment #1.1.2: Type: text/html, Size: 4805 bytes --]

[-- Attachment #1.2: image.png --]
[-- Type: image/png, Size: 79575 bytes --]

[-- Attachment #2: 0002-gnu-Add-python-logwrap.patch --]
[-- Type: text/x-patch, Size: 2026 bytes --]

From 8251cc84c314ec575f4ec40da56939a2defe75f0 Mon Sep 17 00:00:00 2001
From: Vijayalakshmi <vijimay12@gmail.com>
Date: Mon, 19 Mar 2018 22:20:25 +0530
Subject: [PATCH 2/2] gnu: Add python-logwrap

* gnu/packages/python.scm (python-logwrap): New variable.
---
 gnu/packages/python.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 05d3390..bb3a0b2 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -47,7 +47,8 @@
 ;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley@openmailbox.org>
 ;;; Copyright © 2018 Ethan R. Jones <ethanrjones97@gmail.com
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
-;;;
+;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12@gmail.com>
+
 ;;; This file is part of GNU Guix.
 ;;;
 ;;; GNU Guix is free software; you can redistribute it and/or modify it
@@ -524,6 +525,28 @@ pidof, tty, taskset, pmap.")
 planar geometric objects.  It is based on the @code{GEOS} library.")
     (license license:bsd-3)))
 
+(define-public python-logwrap
+  (package
+    (name "python-logwrap")
+    (version "3.2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "logwrap" version))
+       (sha256
+        (base32
+         "1d2k0hvpbi51vl410y8fbs5m0nxnlh2k7gr2nrh3k81ibhzscsra"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+      ("python-typing" ,python-typing)))
+    (home-page "https://github.com/penguinolog/logwrap")
+    (synopsis "Decorator for logging function arguments and return value by human-readable way")
+    (description "This package provides tools to decorate logging function arguments and return their value in human-readable way.
+    	For more information on how to use this see @url{https://pypi.python.org/pypi/logwrap/3.2.1}")
+    (license license:asl2.0)))
+
+
 (define-public python2-shapely
   (package-with-python2 python-shapely))
 
-- 
2.7.4

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Ricardo Wurmus]

Hi Vijayalakshmi,

> I created a patch file for the package definition of python-logwrap that
> I'm including here. I'm a little unsure if my patch is right because my ./
> pre-inst-env.in guix build r-abbyyR fails with some error.

This looks like you haven’t actually built Guix.  The “.in” files are
templates containing @PLACEHOLDERS@; they are turned into their target
files at configuration time.

In short you need to do this:

    guix environment guix
    ./bootstrap
    ./configure --localstatedir=/var
    make

At that point you’ll have “pre-inst-env”, an actual executable script.

> Also, since we are going to be communicating regularly now,
> 1. I'd like to know the best times to contact you.

I’m checking mails daily, but not always able to respond within 6 hours.
I’ll try to get a reply out within 12 hours.  I’m located in Central
Europe, so my timezone is CET.

> 2. I need some help finishing my Outreachy application, so anytime in the
> next 2 days if you could set aside an hour for us to discuss the goals of
> the project etc it'll be great.

Sure; I have some days off this week, so I can reserve some time to
discuss this.  Have you read the full project description on the
Outreachy page already?  If so, do you have any questions about the
project description?

As you build and install packages with Guix you will probably notice
that often there is a lot of dense output.  I think you can get a better
appreciation for this project when you play a little with Guix and
observe in what situations it spews out a lot of text.

The project schedule isn’t totally rigid; if you find a part of this
project particularly interesting we can adapt and focus on that part
more.  But before we can decide this I think you need to become a little
more familiar with the problem first.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]


Hi Vijayalakshmi,

> I created a patch file for the package definition of python-logwrap that
> I'm including here. I'm a little unsure if my patch is right because my ./
> pre-inst-env.in guix build r-abbyyR fails with some error.

Have you been able to build Guix already and try building the package
using “./pre-inst-env guix build”?

I looked over your patch for python-logwrap.  I had to append “.zip”
because Pypi didn’t have a “.tar.gz” file for the sources, so the uri
field now is:

   (pypi-uri "logwrap" version ".zip")

Having a zip archive requires the “unzip” command during the “unpack”
phase, so I also added “unzip” to the native-inputs field.

I also noticed that the sources include files that were generated with
Cython.  Instead of reusing those, we build them from source.  Luckily
all we have to do in this case is to add “python-cython” to the
native-inputs field.

Finally, the tests. At first the tests wouldn’t run.  So I looked up the
error message online and found that I need to use “python-pytest-runner”
in addition to “python-pytest”.  This allows the tests to run up to a
point until it wants to do coverage tests.  For those I needed to add
“python-pytest-cov”.

I changed the description, because I think it wasn’t quite correct.

Attached is my modified version.  What do you think?  Do you have any
questions about my changes?


[-- Attachment #2: 0001-gnu-Add-python-logwrap.patch --]
[-- Type: text/x-patch, Size: 2255 bytes --]

From 520d4cd8d9246ec4a1601906404194610f3905bd Mon Sep 17 00:00:00 2001
From: Vijayalakshmi <vijimay12@gmail.com>
Date: Mon, 19 Mar 2018 22:20:25 +0530
Subject: [PATCH] gnu: Add python-logwrap.

* gnu/packages/python.scm (python-logwrap): New variable.

Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
---
 gnu/packages/python.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 76b5460f6..ff250a1ea 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -47,7 +47,8 @@
 ;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley@openmailbox.org>
 ;;; Copyright © 2018 Ethan R. Jones <ethanrjones97@gmail.com
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
-;;;
+;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12@gmail.com>
+
 ;;; This file is part of GNU Guix.
 ;;;
 ;;; GNU Guix is free software; you can redistribute it and/or modify it
@@ -524,6 +525,33 @@ pidof, tty, taskset, pmap.")
 planar geometric objects.  It is based on the @code{GEOS} library.")
     (license license:bsd-3)))
 
+(define-public python-logwrap
+  (package
+    (name "python-logwrap")
+    (version "3.2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "logwrap" version ".zip"))
+       (sha256
+        (base32
+         "1d2k0hvpbi51vl410y8fbs5m0nxnlh2k7gr2nrh3k81ibhzscsra"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-typing" ,python-typing)))
+    (native-inputs
+     `(("unzip" ,unzip)
+       ("python-cython" ,python-cython)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-pytest-runner" ,python-pytest-runner)))
+    (home-page "https://github.com/penguinolog/logwrap")
+    (synopsis "Decorator for logging function arguments")
+    (description "This package provides a decorator to log function arguments
+and function call return values in a human-readable way.")
+    (license license:asl2.0)))
+
 (define-public python2-shapely
   (package-with-python2 python-shapely))
 
-- 
2.16.2


[-- Attachment #3: Type: text/plain, Size: 89 bytes --]


--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Vijayalakshmi Vedantham]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Hi,

I'm really sorry about the effort you had to put into this patch. I'll try
not to do it again.

I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
> sources, so the uri
> field now is:
>
>    (pypi-uri "logwrap" version ".zip")
>

Did you do this because only .zip is available here (
https://pypi.python.org/pypi/logwrap#downloads)?


>
> I also noticed that the sources include files that were generated with
> Cython.  Instead of reusing those, we build them from source.  Luckily
> all we have to do in this case is to add “python-cython” to the
> native-inputs field.
>

Can I know how you knew this?


> Finally, the tests. At first the tests wouldn’t run.  So I looked up the
> error message online and found that I need to use “python-pytest-runner”
> in addition to “python-pytest”.  This allows the tests to run up to a
> point until it wants to do coverage tests.  For those I needed to add
> “python-pytest-cov”.
>
> I changed the description, because I think it wasn’t quite correct.
>

Again, I'm sorry.


     Have you been able to build Guix already and try building the package
using “./pre-inst-env guix build”?

No, I tried last night but I faced some issues, I'll try again tonight.

Thanks,
Vijayalakshmi

[-- Attachment #2: Type: text/html, Size: 2130 bytes --]

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Ricardo Wurmus]

Hi Vijayalakshmi,

> I'm really sorry about the effort you had to put into this patch. I'll try
> not to do it again.

Oh, you misunderstood.  This kind of reworking of patches is very
normal.  It happens all the time and is a normal part of patch
review.

Some of these problems, however, could have been found before sending
the patch.  It is good to first try to actually build the package.  This
can give you error messages that can guide your way to a working package
definition.

> I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
>> sources, so the uri
>> field now is:
>>
>>    (pypi-uri "logwrap" version ".zip")
>>
>
> Did you do this because only .zip is available here (
> https://pypi.python.org/pypi/logwrap#downloads)?

That’s correct.

>> I also noticed that the sources include files that were generated with
>> Cython.  Instead of reusing those, we build them from source.  Luckily
>> all we have to do in this case is to add “python-cython” to the
>> native-inputs field.
>>
>
> Can I know how you knew this?

I looked at the included “setup.py” as I was trying to understand how
the tests are supposed to be run.  There I stumbled upon a check for
Cython, which is optional.  Usually, this means that the archive
includes generated files and it will only regenerate them from source if
Cython is found.  By adding “python-cython” to the native-inputs I make
sure that Cython is found when the package is built.

>> Finally, the tests. At first the tests wouldn’t run.  So I looked up the
>> error message online and found that I need to use “python-pytest-runner”
>> in addition to “python-pytest”.  This allows the tests to run up to a
>> point until it wants to do coverage tests.  For those I needed to add
>> “python-pytest-cov”.
>>
>> I changed the description, because I think it wasn’t quite correct.
>>
>
> Again, I'm sorry.

No worries!

>      Have you been able to build Guix already and try building the package
> using “./pre-inst-env guix build”?
>
> No, I tried last night but I faced some issues, I'll try again tonight.

You’re welcome to share your progress and the exact error messages (text
is better than screenshots) here if you feel stuck.  Being able to build
packages with your modified version of Guix is pretty important for all
development work in Guix.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

Hi Vijayalakshmi,

welcome to Guix!


On Tue, 20 Mar 2018 20:45:02 +0530
Vijayalakshmi Vedantham <vijimay12@gmail.com> wrote:

> Hi,
> 
> I'm really sorry about the effort you had to put into this patch.
> I'll try not to do it again.

Seriously: I hope you are not discouraged by that. And I hope you do it
again and again. Including the errs. Guix is tough stuff and we all
did and do our mistakes. And each one helps to understand the system a
bit better.

And I really like this community because it is so soft and helpful
and polite :-)


> >
> > I also noticed that the sources include files that were generated
> > with Cython.  Instead of reusing those, we build them from source.
> > Luckily all we have to do in this case is to add “python-cython” to
> > the native-inputs field.
> >  
> 
> Can I know how you knew this?

I can't speak for Ricardo but only for me: There is some
intrinsic knowledge about each build system and each programming
language, how they generate things, and how this relates to "building
your software really from source in a FSF-compliant way".

Just look at how others have done it in their package definitions.
Present your package definition and get it reviewed. People will hint
you politeful to this knowledge.



>      Have you been able to build Guix already and try building the
> package using “./pre-inst-env guix build”?
> 
> No, I tried last night but I faced some issues, I'll try again
> tonight.

Before submitting a patch, try to build it at least twice. If you have
trouble to build it, submit it anyway and tell why it doesn't build
(twice, because of reproducibility).

Take a look at the Manual at

https://www.gnu.org/software/guix/manual/guix.html#Packaging-Guidelines

and


https://www.gnu.org/software/guix/manual/guix.html#Submitting-Patches

The latter one is like a checklist to go through before submitting.

Happy Guix-ing,

Björn



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]

On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote:
> Hi,
> 
> I'm really sorry about the effort you had to put into this patch. I'll try
> not to do it again.
> 
> I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
> > sources, so the uri
> > field now is:
> >
> >    (pypi-uri "logwrap" version ".zip")
> >
> 
> Did you do this because only .zip is available here (
> https://pypi.python.org/pypi/logwrap#downloads)?
> 

$ guix import pypi logwrap

Starting download of /tmp/guix-file.BdwXcD
From https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e145852895509fddc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip...
 …3.2.1.zip  241KiB                   869KiB/s 00:00 [##################] 100.0%

In this case the importer grabbed a zip file, so I guess it falls into
tribal knowledge, definately something that should be documented better.

> 
> >
> > I also noticed that the sources include files that were generated with
> > Cython.  Instead of reusing those, we build them from source.  Luckily
> > all we have to do in this case is to add “python-cython” to the
> > native-inputs field.
> >
> 
> Can I know how you knew this?

For files that are generated by Cython they generally have a line at the
top that reads: "Generated by Cython 0.x.y" or something along those
lines. If you unzip the downloaded source and run 'grep Cython . -R'
inside the folder it'll show any files generated by Cython.

> 
> 
> > Finally, the tests. At first the tests wouldn’t run.  So I looked up the
> > error message online and found that I need to use “python-pytest-runner”
> > in addition to “python-pytest”.  This allows the tests to run up to a
> > point until it wants to do coverage tests.  For those I needed to add
> > “python-pytest-cov”.
> >
> > I changed the description, because I think it wasn’t quite correct.
> >
> 
> Again, I'm sorry.

No worries, the test suite wasn't so easy. The release tarball/zip
didn't include good directions for running the test suite, I had to go
to the actual repository and see how the tests were run with 'tox' and
then try recreating the commands; I wasn't successful.

As far as the description goes, it's my least favorite part :).

> 
> 
>      Have you been able to build Guix already and try building the package
> using “./pre-inst-env guix build”?
> 
> No, I tried last night but I faced some issues, I'll try again tonight.
> 
> Thanks,
> Vijayalakshmi

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Vijayalakshmi Vedantham]

[-- Attachment #1: Type: text/plain, Size: 3375 bytes --]

Thank you so much to everyone who replied. This project truly has the
kindest and most polite people.

I wanted to know what kind of system most people work on. My ubuntu is
giving me Locale errors so I was thinking of creating a virtual environment
and working on that. Do you think that will work out?

Also, has the patch been applied yet?

Thanks,
Vijayalakshmi

On Wed, Mar 21, 2018 at 2:05 PM, Efraim Flashner <efraim@flashner.co.il>
wrote:

> On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote:
> > Hi,
> >
> > I'm really sorry about the effort you had to put into this patch. I'll
> try
> > not to do it again.
> >
> > I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
> > > sources, so the uri
> > > field now is:
> > >
> > >    (pypi-uri "logwrap" version ".zip")
> > >
> >
> > Did you do this because only .zip is available here (
> > https://pypi.python.org/pypi/logwrap#downloads)?
> >
>
> $ guix import pypi logwrap
>
> Starting download of /tmp/guix-file.BdwXcD
> From https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e145852895509fd
> dc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip...
>  …3.2.1.zip  241KiB                   869KiB/s 00:00 [##################]
> 100.0%
>
> In this case the importer grabbed a zip file, so I guess it falls into
> tribal knowledge, definately something that should be documented better.
>
> >
> > >
> > > I also noticed that the sources include files that were generated with
> > > Cython.  Instead of reusing those, we build them from source.  Luckily
> > > all we have to do in this case is to add “python-cython” to the
> > > native-inputs field.
> > >
> >
> > Can I know how you knew this?
>
> For files that are generated by Cython they generally have a line at the
> top that reads: "Generated by Cython 0.x.y" or something along those
> lines. If you unzip the downloaded source and run 'grep Cython . -R'
> inside the folder it'll show any files generated by Cython.
>
> >
> >
> > > Finally, the tests. At first the tests wouldn’t run.  So I looked up
> the
> > > error message online and found that I need to use
> “python-pytest-runner”
> > > in addition to “python-pytest”.  This allows the tests to run up to a
> > > point until it wants to do coverage tests.  For those I needed to add
> > > “python-pytest-cov”.
> > >
> > > I changed the description, because I think it wasn’t quite correct.
> > >
> >
> > Again, I'm sorry.
>
> No worries, the test suite wasn't so easy. The release tarball/zip
> didn't include good directions for running the test suite, I had to go
> to the actual repository and see how the tests were run with 'tox' and
> then try recreating the commands; I wasn't successful.
>
> As far as the description goes, it's my least favorite part :).
>
> >
> >
> >      Have you been able to build Guix already and try building the
> package
> > using “./pre-inst-env guix build”?
> >
> > No, I tried last night but I faced some issues, I'll try again tonight.
> >
> > Thanks,
> > Vijayalakshmi
>
> --
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
>

[-- Attachment #2: Type: text/html, Size: 4692 bytes --]

Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 3772 bytes --]

2018-03-21 18:03 GMT+01:00 Vijayalakshmi Vedantham <vijimay12@gmail.com>:

> Thank you so much to everyone who replied. This project truly has the
> kindest and most polite people.
>
> I wanted to know what kind of system most people work on. My ubuntu is
> giving me Locale errors so I was thinking of creating a virtual environment
> and working on that. Do you think that will work out?
>
>
Most of the time I use a laptop with Ubuntu as a host system, and GuixSD
running in a KVM/qemu virtual machine. It works fine for me.


> Also, has the patch been applied yet?
>
>
Yes, I see that the patch has been applied already.


> Thanks,
> Vijayalakshmi
>
> On Wed, Mar 21, 2018 at 2:05 PM, Efraim Flashner <efraim@flashner.co.il>
> wrote:
>
>> On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote:
>> > Hi,
>> >
>> > I'm really sorry about the effort you had to put into this patch. I'll
>> try
>> > not to do it again.
>> >
>> > I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
>> > > sources, so the uri
>> > > field now is:
>> > >
>> > >    (pypi-uri "logwrap" version ".zip")
>> > >
>> >
>> > Did you do this because only .zip is available here (
>> > https://pypi.python.org/pypi/logwrap#downloads)?
>> >
>>
>> $ guix import pypi logwrap
>>
>> Starting download of /tmp/guix-file.BdwXcD
>> From https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e14585
>> 2895509fddc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip...
>>  …3.2.1.zip  241KiB                   869KiB/s 00:00 [##################]
>> 100.0%
>>
>> In this case the importer grabbed a zip file, so I guess it falls into
>> tribal knowledge, definately something that should be documented better.
>>
>> >
>> > >
>> > > I also noticed that the sources include files that were generated with
>> > > Cython.  Instead of reusing those, we build them from source.  Luckily
>> > > all we have to do in this case is to add “python-cython” to the
>> > > native-inputs field.
>> > >
>> >
>> > Can I know how you knew this?
>>
>> For files that are generated by Cython they generally have a line at the
>> top that reads: "Generated by Cython 0.x.y" or something along those
>> lines. If you unzip the downloaded source and run 'grep Cython . -R'
>> inside the folder it'll show any files generated by Cython.
>>
>> >
>> >
>> > > Finally, the tests. At first the tests wouldn’t run.  So I looked up
>> the
>> > > error message online and found that I need to use
>> “python-pytest-runner”
>> > > in addition to “python-pytest”.  This allows the tests to run up to a
>> > > point until it wants to do coverage tests.  For those I needed to add
>> > > “python-pytest-cov”.
>> > >
>> > > I changed the description, because I think it wasn’t quite correct.
>> > >
>> >
>> > Again, I'm sorry.
>>
>> No worries, the test suite wasn't so easy. The release tarball/zip
>> didn't include good directions for running the test suite, I had to go
>> to the actual repository and see how the tests were run with 'tox' and
>> then try recreating the commands; I wasn't successful.
>>
>> As far as the description goes, it's my least favorite part :).
>>
>> >
>> >
>> >      Have you been able to build Guix already and try building the
>> package
>> > using “./pre-inst-env guix build”?
>> >
>> > No, I tried last night but I faced some issues, I'll try again tonight.
>> >
>> > Thanks,
>> > Vijayalakshmi
>>
>> --
>> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
>> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
>> Confidentiality cannot be guaranteed on emails sent or received
>> unencrypted
>>
>
>

[-- Attachment #2: Type: text/html, Size: 5710 bytes --]