From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijayalakshmi Vedantham Subject: Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy) Date: Tue, 20 Mar 2018 20:45:02 +0530 Message-ID: References: <87fu5pch36.fsf@elephly.net> <87h8pfy56s.fsf@elephly.net> <87tvtdthda.fsf@elephly.net> <87k1u8uccr.fsf@elephly.net> <87in9qdcws.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11475a56ea3baf0567d989c3" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyIyi-0003IO-Es for guix-devel@gnu.org; Tue, 20 Mar 2018 11:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyIye-00074l-8f for guix-devel@gnu.org; Tue, 20 Mar 2018 11:15:08 -0400 Received: from mail-ua0-x22b.google.com ([2607:f8b0:400c:c08::22b]:37600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyIye-00074R-2c for guix-devel@gnu.org; Tue, 20 Mar 2018 11:15:04 -0400 Received: by mail-ua0-x22b.google.com with SMTP id q12so1254465uae.4 for ; Tue, 20 Mar 2018 08:15:03 -0700 (PDT) In-Reply-To: <87in9qdcws.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a11475a56ea3baf0567d989c3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I'm really sorry about the effort you had to put into this patch. I'll try not to do it again. I had to append =E2=80=9C.zip=E2=80=9D because Pypi didn=E2=80=99t have a = =E2=80=9C.tar.gz=E2=80=9D file for the > sources, so the uri > field now is: > > (pypi-uri "logwrap" version ".zip") > Did you do this because only .zip is available here ( https://pypi.python.org/pypi/logwrap#downloads)? > > I also noticed that the sources include files that were generated with > Cython. Instead of reusing those, we build them from source. Luckily > all we have to do in this case is to add =E2=80=9Cpython-cython=E2=80=9D = to the > native-inputs field. > Can I know how you knew this? > Finally, the tests. At first the tests wouldn=E2=80=99t run. So I looked= up the > error message online and found that I need to use =E2=80=9Cpython-pytest-= runner=E2=80=9D > in addition to =E2=80=9Cpython-pytest=E2=80=9D. This allows the tests to= run up to a > point until it wants to do coverage tests. For those I needed to add > =E2=80=9Cpython-pytest-cov=E2=80=9D. > > I changed the description, because I think it wasn=E2=80=99t quite correc= t. > Again, I'm sorry. Have you been able to build Guix already and try building the package using =E2=80=9C./pre-inst-env guix build=E2=80=9D? No, I tried last night but I faced some issues, I'll try again tonight. Thanks, Vijayalakshmi --001a11475a56ea3baf0567d989c3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I'm really sorry about the effor= t you had to put into this patch. I'll try not to do it again.

I had to append =E2=80=9C.zip=E2=80=9D because Pypi didn=E2=80=99t have a = =E2=80=9C.tar.gz=E2=80=9D file for the sources, so the uri
field now is:

=C2=A0 =C2=A0(pypi-uri "logwrap" version ".zip")

Did you do this because only .zip is availabl= e here (https://= pypi.python.org/pypi/logwrap#downloads)?
=C2=A0
=

I also noticed that the sources include files that were generated with
Cython.=C2=A0 Instead of reusing those, we build them from source.=C2=A0 Lu= ckily
all we have to do in this case is to add =E2=80=9Cpython-cython=E2=80=9D to= the
native-inputs field.

Can I know how you= knew this?
=C2=A0
Finally, the tests. At first the tests wouldn=E2=80=99t run.=C2=A0 So I loo= ked up the
error message online and found that I need to use =E2=80=9Cpython-pytest-ru= nner=E2=80=9D
in addition to =E2=80=9Cpython-pytest=E2=80=9D.=C2=A0 This allows the tests= to run up to a
point until it wants to do coverage tests.=C2=A0 For those I needed to add<= br> =E2=80=9Cpython-pytest-cov=E2=80=9D.

I changed the description, because I think it wasn=E2=80=99t quite correct.=

Again, I'm sorry.


=C2= =A0=C2=A0=C2=A0=C2=A0 Have you been able to build Guix already and try buil= ding the package using =E2=80=9C./pre-inst-env guix build=E2=80=9D?

=
No, I tried last night but I faced some issues, I'll try aga= in tonight.

Thanks,
Vijayalakshmi
=


--001a11475a56ea3baf0567d989c3--