From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ra Subject: Re: [PATCH] gnu: Add perl-parallel-forkmanager. Date: Thu, 12 Jan 2017 23:45:43 +0000 Message-ID: References: <87tw9458ib.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1148bb5a76691a0545ee5179 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRp49-0003n1-LS for guix-devel@gnu.org; Thu, 12 Jan 2017 18:45:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRp47-00057Q-VE for guix-devel@gnu.org; Thu, 12 Jan 2017 18:45:57 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:36860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRp47-00057D-PV for guix-devel@gnu.org; Thu, 12 Jan 2017 18:45:55 -0500 Received: by mail-qk0-x241.google.com with SMTP id a20so4926333qkc.3 for ; Thu, 12 Jan 2017 15:45:55 -0800 (PST) In-Reply-To: <87tw9458ib.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke , guix-devel --001a1148bb5a76691a0545ee5179 Content-Type: multipart/alternative; boundary=001a1148bb5a7669150545ee5177 --001a1148bb5a7669150545ee5177 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Marius, On Thu, Jan 12, 2017 at 9:27 PM Marius Bakke wrote: > Ra writes: > > > * gnu/packages/perl.scm (perl-parallel-forkmanager): New variable. > > Thanks! This looks mostly good, see comments below. Can you send an > updated patch that also includes copyright information? Thanks in > advance! > > > --- > > gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > > index 8f103ec..532e360 100644 > > --- a/gnu/packages/perl.scm > > +++ b/gnu/packages/perl.scm > > @@ -7770,3 +7770,29 @@ interface to File::Find::Object.") > > (description "Test::TrailingSpace tests for trailing spaces > > in Perl source files.") > > (license x11))) > > + > > +(define-public perl-parallel-forkmanager > > There is a pledge at the top of perl.scm asking to add packages in > alphabetic order. Can you adjust the location of this expression > accordingly? > > > + (package > > + (name "perl-parallel-forkmanager") > > + (version "1.19") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + > "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-" > > + version > > + ".tar.gz")) > > + (sha256 > > + (base32 > > + "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi")))) > > + (build-system perl-build-system) > > + (native-inputs > > + `(("perl-test-warn" ,perl-test-warn))) > > + (home-page > > + "http://search.cpan.org/dist/Parallel-ForkManager") > > + (synopsis > > + "A simple parallel processing fork manager") > > Synopsis should not start with an article. `guix lint` will complain > about this ;-) > > Also, the line breaks after home-page and synopsis are not necessary. > > > + (description "Parallel::ForkManager is intended for use in > ^^^ > Please use @code{Parallel::ForkManager} here. > > > +operations that can be done in parallel where the number of > > +processes to be forked off should be limited.") > > + (license (package-license perl)))) > > Otherwise LGTM! > Thanks for helping me in creating a right patch. I think I did everything, below and attached the patch. * gnu/packages/perl.scm (perl-parallel-forkmanager): New variable. --- gnu/packages/perl.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 8f103ec..4e8ed9a 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -12,6 +12,7 @@ ;;; Copyright =C2=A9 2016 Roel Janssen ;;; Copyright =C2=A9 2016 Ben Woodcroft ;;; Copyright =C2=A9 2016 Jan Nieuwenhuizen +;;; Copyright @ 2017 Raoul J.P. Bonnal ;;; ;;; This file is part of GNU Guix. ;;; @@ -5014,6 +5015,30 @@ show those variables which are in scope at the point of the call. PadWalker is particularly useful for debugging.") (license (package-license perl)))) +(define-public perl-parallel-forkmanager + (package + (name "perl-parallel-forkmanager") + (version "1.19") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-" + version + ".tar.gz")) + (sha256 + (base32 + "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi")))) + (build-system perl-build-system) + (native-inputs + `(("perl-test-warn" ,perl-test-warn))) + (home-page "http://search.cpan.org/dist/Parallel-ForkManager") + (synopsis "Simple parallel processing fork manager") + (description "@code{Parallel::ForkManager} is intended for use in +operations that can be done in parallel where the number of +processes to be forked off should be limited.") + (license (package-license perl)))) + (define-public perl-params-util (package (name "perl-params-util") -- 1.9.1 Ciao -- Ra --001a1148bb5a7669150545ee5177 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Marius,

On Thu, Jan 12, 2017 at 9:27 PM Marius Bakke <mbakke@fastmail.com> wrote:
Ra <ilpuccio.febo@gmail.com> writes:
>=C2=A0 =C2=A0 =C2=A0* gnu/packages/perl.scm (perl-parallel-forkmanager)= : New variable.

Thanks! This looks mostly good, see comments below. Can you send an
updated patch that also includes copyright information? Thanks in
advance!

> ---
>=C2=A0 gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
>=C2=A0 1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 8f103ec..532e360 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -7770,3 +7770,29 @@ interface to File::Find::Object.")
>=C2=A0 =C2=A0 (description "Test::TrailingSpace tests for trailing= spaces
>=C2=A0 in Perl source files.")
>=C2=A0 =C2=A0 (license x11)))
> +
> +(define-public perl-parallel-forkmanager

There is a pledge at the top of perl.scm asking to add packages in
alphabetic order. Can you adjust the location of this expression
accordingly?

> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "perl-parallel-forkmanager")
> +=C2=A0 =C2=A0 (version "1.19")
> +=C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method url-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (string-append
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"mirror://cpan/a= uthors/id/Y/YA/YANICK/Parallel-ForkManager-"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0version
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0".tar.gz"))=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"0wm4wp6p3ah5z212jl12728z68nmx= mfr0f03z1jpvdzffnc2xppi"))))
> +=C2=A0 =C2=A0 (build-system perl-build-system)
> +=C2=A0 =C2=A0 (native-inputs
> +=C2=A0 =C2=A0 =C2=A0`(("perl-test-warn" ,perl-test-warn)))<= br class=3D"gmail_msg"> > +=C2=A0 =C2=A0 (home-page
> +=C2=A0 =C2=A0 =C2=A0"= http://search.cpan.org/dist/Parallel-ForkManager")
> +=C2=A0 =C2=A0 (synopsis
> +=C2=A0 =C2=A0 =C2=A0"A simple parallel processing fork manager&q= uot;)

Synopsis should not start with an article. `guix lint` will complain
about this ;-)

Also, the line breaks after home-page and synopsis are not necessary.

> +=C2=A0 (description "Parallel::ForkManager is intended for use i= n
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Please= use @code{Parallel::ForkManager} here.

> +operations that can be done in parallel where the number of
> +processes to be forked off should be limited.")
> +=C2=A0 (license (package-license perl))))

Otherwise LGTM!
Thanks for helping= me in creating a right patch.=C2=A0
I think I did everything, be= low and attached the patch.=C2=A0

* gnu/packa= ges/perl.scm (perl-parallel-forkmanager): New variable.
---
=
=C2=A0gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
= =C2=A01 file changed, 25 insertions(+)

diff --git = a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 8f103ec..4e= 8ed9a 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/pack= ages/perl.scm
@@ -12,6 +12,7 @@
=C2=A0;;; Copyright =C2= =A9 2016 Roel Janssen <roel@gnu.org&= gt;
=C2=A0;;; Copyright =C2=A9 2016 Ben Woodcroft <donttrustben@gmail.com>
=C2= =A0;;; Copyright =C2=A9 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;; Copyright @ 2017 Raoul J.= P. Bonnal <ilpuccio.febo@gmai= l.com>
=C2=A0;;;
=C2=A0;;; This file is part of = GNU Guix.
=C2=A0;;;
@@ -5014,6 +5015,30 @@ show those v= ariables which are in scope at the point of the call.=C2=A0 PadWalker
=
=C2=A0is particularly useful for debugging.")
=C2=A0 = =C2=A0 =C2=A0(license (package-license perl))))

+(= define-public perl-parallel-forkmanager
+ =C2=A0(package
+ =C2=A0 =C2=A0(name "perl-parallel-forkmanager")
+ = =C2=A0 =C2=A0(version "1.19")
+ =C2=A0 =C2=A0(source
+ =C2=A0 =C2=A0 (origin
+ =C2=A0 =C2=A0 =C2=A0 (method ur= l-fetch)
+ =C2=A0 =C2=A0 =C2=A0 (uri (string-append
+ = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "mirror://cpan/authors/id/Y/= YA/YANICK/Parallel-ForkManager-"
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 version
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ".tar.gz"))
+ =C2=A0 =C2=A0 =C2=A0 (sha256
=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi"))))=
+ =C2=A0 =C2=A0(build-system perl-build-system)
+ =C2= =A0 =C2=A0(native-inputs
+ =C2=A0 =C2=A0 `(("perl-test-warn&= quot; ,perl-test-warn)))
+ =C2=A0 =C2=A0(synopsis &= quot;Simple parallel processing fork manager")
+ =C2=A0 =C2= =A0(description "@code{Parallel::ForkManager} is intended for use in
+operations that can be done in parallel where the number of
=
+processes to be forked off should be limited.")
+ =C2= =A0(license (package-license perl))))
+
=C2=A0(define-p= ublic perl-params-util
=C2=A0 =C2=A0(package
=C2=A0 =C2= =A0 =C2=A0(name "perl-params-util")
--
1.9.1<= /div>

Ciao
--
Ra
--001a1148bb5a7669150545ee5177-- --001a1148bb5a76691a0545ee5179 Content-Type: application/octet-stream; name="0001-gnu-Add-perl-parallel-forkmanager.patch" Content-Disposition: attachment; filename="0001-gnu-Add-perl-parallel-forkmanager.patch" Content-Transfer-Encoding: base64 Content-ID: <1599512528eb9d2bfa61> X-Attachment-Id: 1599512528eb9d2bfa61 RnJvbSA4NmRiZGM2ZDUwOTcxMTViMzkzZDlkZjJmYmIyMTM5ZmM3YWU0OGIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW91bCBKZWFuIFBpZXJyZSBCb25uYWwgPGlscHVjY2lvLmZl Ym9AZ21haWwuY29tPgpEYXRlOiBGcmksIDEzIEphbiAyMDE3IDAwOjI5OjIzICswMTAwClN1Ympl Y3Q6IFtQQVRDSF0gZ251OiBBZGQgcGVybC1wYXJhbGxlbC1mb3JrbWFuYWdlci4KCiogZ251L3Bh Y2thZ2VzL3Blcmwuc2NtIChwZXJsLXBhcmFsbGVsLWZvcmttYW5hZ2VyKTogTmV3IHZhcmlhYmxl LgotLS0KIGdudS9wYWNrYWdlcy9wZXJsLnNjbSB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysr KysKIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3Bh Y2thZ2VzL3Blcmwuc2NtIGIvZ251L3BhY2thZ2VzL3Blcmwuc2NtCmluZGV4IDhmMTAzZWMuLjRl OGVkOWEgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9wZXJsLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvcGVybC5zY20KQEAgLTEyLDYgKzEyLDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBSb2Vs IEphbnNzZW4gPHJvZWxAZ251Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBCZW4gV29vZGNy b2Z0IDxkb250dHJ1c3RiZW5AZ21haWwuY29tPgogOzs7IENvcHlyaWdodCDCqSAyMDE2IEphbiBO aWV1d2VuaHVpemVuIDxqYW5uZWtlQGdudS5vcmc+Cis7OzsgQ29weXJpZ2h0IEAgMjAxNyBSYW91 bCBKLlAuIEJvbm5hbCA8aWxwdWNjaW8uZmVib0BnbWFpbC5jb20+CiA7OzsKIDs7OyBUaGlzIGZp bGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNTAxNCw2ICs1MDE1LDMwIEBAIHNob3cg dGhvc2UgdmFyaWFibGVzIHdoaWNoIGFyZSBpbiBzY29wZSBhdCB0aGUgcG9pbnQgb2YgdGhlIGNh bGwuICBQYWRXYWxrZXIKIGlzIHBhcnRpY3VsYXJseSB1c2VmdWwgZm9yIGRlYnVnZ2luZy4iKQog ICAgIChsaWNlbnNlIChwYWNrYWdlLWxpY2Vuc2UgcGVybCkpKSkKIAorKGRlZmluZS1wdWJsaWMg cGVybC1wYXJhbGxlbC1mb3JrbWFuYWdlcgorICAocGFja2FnZQorICAgIChuYW1lICJwZXJsLXBh cmFsbGVsLWZvcmttYW5hZ2VyIikKKyAgICAodmVyc2lvbiAiMS4xOSIpCisgICAgKHNvdXJjZQor ICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAgICAgKHVyaSAoc3Ry aW5nLWFwcGVuZAorICAgICAgICAgICAgICJtaXJyb3I6Ly9jcGFuL2F1dGhvcnMvaWQvWS9ZQS9Z QU5JQ0svUGFyYWxsZWwtRm9ya01hbmFnZXItIgorICAgICAgICAgICAgIHZlcnNpb24KKyAgICAg ICAgICAgICAiLnRhci5neiIpKQorICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAg ICAgICAgIjB3bTR3cDZwM2FoNXoyMTJqbDEyNzI4ejY4bm14bWZyMGYwM3oxanB2ZHpmZm5jMnhw cGkiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gcGVybC1idWlsZC1zeXN0ZW0pCisgICAgKG5hdGl2 ZS1pbnB1dHMKKyAgICAgYCgoInBlcmwtdGVzdC13YXJuIiAscGVybC10ZXN0LXdhcm4pKSkKKyAg ICAoaG9tZS1wYWdlICJodHRwOi8vc2VhcmNoLmNwYW4ub3JnL2Rpc3QvUGFyYWxsZWwtRm9ya01h bmFnZXIiKQorICAgIChzeW5vcHNpcyAiU2ltcGxlIHBhcmFsbGVsIHByb2Nlc3NpbmcgZm9yayBt YW5hZ2VyIikKKyAgICAoZGVzY3JpcHRpb24gIkBjb2Rle1BhcmFsbGVsOjpGb3JrTWFuYWdlcn0g aXMgaW50ZW5kZWQgZm9yIHVzZSBpbgorb3BlcmF0aW9ucyB0aGF0IGNhbiBiZSBkb25lIGluIHBh cmFsbGVsIHdoZXJlIHRoZSBudW1iZXIgb2YKK3Byb2Nlc3NlcyB0byBiZSBmb3JrZWQgb2ZmIHNo b3VsZCBiZSBsaW1pdGVkLiIpCisgIChsaWNlbnNlIChwYWNrYWdlLWxpY2Vuc2UgcGVybCkpKSkK KwogKGRlZmluZS1wdWJsaWMgcGVybC1wYXJhbXMtdXRpbAogICAocGFja2FnZQogICAgIChuYW1l ICJwZXJsLXBhcmFtcy11dGlsIikKLS0gCjEuOS4xCgo= --001a1148bb5a76691a0545ee5179--