From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH 1/2] gnu: Add freealut. Date: Mon, 21 Mar 2016 15:44:10 -0500 Message-ID: References: <1458370575-388-1-git-send-email-david.hashe@dhashe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113ac1ccd8413c052e9529ff Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai6gj-00012Q-3w for guix-devel@gnu.org; Mon, 21 Mar 2016 16:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai6gh-0000xW-9I for guix-devel@gnu.org; Mon, 21 Mar 2016 16:44:32 -0400 Received: from mail-vk0-x243.google.com ([2607:f8b0:400c:c05::243]:36178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai6gh-0000xO-2B for guix-devel@gnu.org; Mon, 21 Mar 2016 16:44:31 -0400 Received: by mail-vk0-x243.google.com with SMTP id z68so5192331vkg.3 for ; Mon, 21 Mar 2016 13:44:30 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a113ac1ccd8413c052e9529ff Content-Type: multipart/alternative; boundary=001a113ac1ccd84135052e9529fd --001a113ac1ccd84135052e9529fd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ricardo, Thanks for taking the time to review this! On Mon, Mar 21, 2016 at 9:36 AM, Ricardo Wurmus < ricardo.wurmus@mdc-berlin.de> wrote: > > Hi David, > > thank you for the patch! > > > * gnu/packages/audio.scm (freealut): New variable. > > --- > > [...] > > > > > +(define-public freealut > > + (package > > + (name "freealut") > > + (version "1.1.0") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + ;; The official repository is defunct. This is the > most > > + ;; popular mirror. > > + (url (string-append "https://github.com/vancegroup= /" > name)) > > + (commit version))) > > I see that Arch and Fedora both use the tarball from here: > > > http://pkgs.fedoraproject.org/repo/pkgs/freealut/freealut-1.1.0.tar.gz/e0= 89b28a0267faabdb6c079ee173664a/freealut-1.1.0.tar.gz > > The advantage of that tarball is that it doesn=E2=80=99t require bootstra= pping, > so you can do without the additional =E2=80=9Cautogen=E2=80=9D phase and = without the > three native inputs. > Done. By the way, where exactly do you find what tarball Arch and Fedora use for a given package? I couldn't seem to find that information on a cursory glance. > > > + (home-page "http://www.openal.org/") > > Does Freealut itself have a home page? It doesn=E2=80=99t seem right to = me to > declare the website of OpenAL as the home page, when the package is > really just one implemenatation of the standard published on the OpenAL > website. > > I agree, but it doesn't seem to have a separate home page. Debian simply lists the home page as "http://www.openal.org/", for instance. I could set the field to #f, but guix lint complains about that and it looks like only the bootstrap-binaries actually do that. For now, I've added a comment clarifying the situation. Let me know if you think that another option would be better. > > + (synopsis "OpenAL Utility Tool") > > Is it a library or a tool (or both)? What does it do? > It is a library, similar to GLUT from OpenGL. I've expanded the synopsis to "Implementation of the OpenAL Utility Toolkit (ALUT)", which I patterned off of the freeglut synopsis. > > > + (description "Freealut is a free implementation of OpenAL's ALUT > > +standard.") > > Could you try to extend the description a little? I don=E2=80=99t know w= hat > this really means. > I've expanded the synopsis. > > ~~ Ricardo > Thanks! David Hashe --001a113ac1ccd84135052e9529fd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Ricardo,

Thanks for taking the time = to review this!

On Mon, Mar 21, 2016 at 9:36 AM, Ricardo Wurmus <<= a href=3D"mailto:ricardo.wurmus@mdc-berlin.de" target=3D"_blank">ricardo.wu= rmus@mdc-berlin.de> wrote:

Hi David,

thank you for the patch!

> * gnu/packages/audio.scm (freealut): New variable.
> ---

[...]

>
> +(define-public freealut
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "freealut")
> +=C2=A0 =C2=A0 (version "1.1.0")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-reference<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= ;; The official repository is defunct. This is the most
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= ;; popular mirror.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (url (string-append "https://github.com/vancegroup/" = name))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (commit version)))

I see that Arch and Fedora both use the tarball from here:

=C2=A0 =C2=A0 http://pkgs.fedoraproject.org/repo/p= kgs/freealut/freealut-1.1.0.tar.gz/e089b28a0267faabdb6c079ee173664a/freealu= t-1.1.0.tar.gz

The advantage of that tarball is that it doesn=E2=80=99t require bootstrapp= ing,
so you can do without the additional =E2=80=9Cautogen=E2=80=9D phase and wi= thout the
three native inputs.

Done. By the way, = where exactly do you find what tarball Arch and Fedora use for a given pack= age? I couldn't seem to find that information on a cursory glance.
=C2=A0

> +=C2=A0 =C2=A0 (home-page "http://www.openal.org/")

Does Freealut itself have a home page?=C2=A0 It doesn=E2=80=99t seem= right to me to
declare the website of OpenAL as the home page, when the package is
really just one implemenatation of the standard published on the OpenAL
website.


I agree, but i= t doesn't seem to have a separate home page. Debian simply lists the ho= me page as "http://www.openal.org/", for instance. I could set t= he field to #f, but guix lint complains about that and it looks like only t= he bootstrap-binaries actually do that. For now, I've added a comment c= larifying the situation.

Let me know if you think = that another option would be better.
=C2=A0
> +=C2=A0 =C2=A0 (synopsis "OpenAL Utility Tool")

Is it a library or a tool (or both)?=C2=A0 What does it do?

It is a library, similar to GLUT from OpenGL. I= 've expanded the synopsis to=C2=A0"Implementation of the OpenAL Ut= ility Toolkit (ALUT)", which I patterned off of the freeglut synopsis.=
=C2=A0

> +=C2=A0 =C2=A0 (description "Freealut is a free implementation of= OpenAL's ALUT
> +standard.")

Could you try to extend the description a little?=C2=A0 I don=E2=80= =99t know what
this really means.

I've expanded th= e synopsis.
=C2=A0

~~ Ricardo

Thank= s!
David Hashe
--001a113ac1ccd84135052e9529fd-- --001a113ac1ccd8413c052e9529ff Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-freealut.patch" Content-Disposition: attachment; filename="0001-gnu-Add-freealut.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_im2gkmat0 RnJvbSAxOTZmY2M1ZmIxMDcxZGE5NzZhZWMxNzg1ZmQ5NWFkYThmZGY3NDE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogU2F0LCAxOSBNYXIgMjAxNiAwMDo1Njo1NSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogQWRkIGZyZWVhbHV0LgoKKiBnbnUvcGFja2FnZXMvYXVkaW8uc2NtIChmcmVlYWx1dCk6IE5l dyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvYXVkaW8uc2NtIHwgMzEgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKykKCmRp ZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvYXVkaW8uc2NtIGIvZ251L3BhY2thZ2VzL2F1ZGlvLnNj bQppbmRleCBjYTQzOGY4Li41MjI1YzY0IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvYXVkaW8u c2NtCisrKyBiL2dudS9wYWNrYWdlcy9hdWRpby5zY20KQEAgLTQsNiArNCw3IEBACiA7OzsgQ29w eXJpZ2h0IMKpIDIwMTUgQW5kcmVhcyBFbmdlIDxhbmRyZWFzQGVuZ2UuZnI+CiA7OzsgQ29weXJp Z2h0IMKpIDIwMTUgQWxleCBLb3N0IDxhbGV6b3N0QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQg wqkgMjAxNSwgMjAxNiBNYXJrIEggV2VhdmVyIDxtaHdAbmV0cmlzLm9yZz4KKzs7OyBDb3B5cmln aHQgwqkgMjAxNiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4KIDs7OwogOzs7 IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xNTA0LDYgKzE1MDUsMzYg QEAgYnVmZmVycywgYW5kIGF1ZGlvIGNhcHR1cmUuIikKICAgICAoaG9tZS1wYWdlICJodHRwOi8v a2NhdC5zdHJhbmdlc29mdC5uZXQvb3BlbmFsLmh0bWwiKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6 bGdwbDIuMCspKSkKIAorKGRlZmluZS1wdWJsaWMgZnJlZWFsdXQKKyAgKHBhY2thZ2UKKyAgICAo bmFtZSAiZnJlZWFsdXQiKQorICAgICh2ZXJzaW9uICIxLjEuMCIpCisgICAgKHNvdXJjZSAob3Jp Z2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJp CisgICAgICAgICAgICAgICAobGV0ICgobmFtZS12ZXJzaW9uLXRhcgorICAgICAgICAgICAgICAg ICAgICAgIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24gIi50YXIuZ3oiKSkpCisgICAg ICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kCisgICAgICAgICAgICAgICAgICAiaHR0cDovL3Br Z3MuZmVkb3JhcHJvamVjdC5vcmcvcmVwby9wa2dzLyIgbmFtZSAiLyIKKyAgICAgICAgICAgICAg ICAgIG5hbWUtdmVyc2lvbi10YXIgIi8iCisgICAgICAgICAgICAgICAgICAiZTA4OWIyOGEwMjY3 ZmFhYmRiNmMwNzllZTE3MzY2NGEvIgorICAgICAgICAgICAgICAgICAgbmFtZS12ZXJzaW9uLXRh cikpKQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAg ICAgICAgICAgICAgIjBremxpbDYxMTJ4MjQyOW53Nm15Y21pZjh5NmJ4cjJjd2pjdnAxOHZoNnM3 ZzYzeW1sYjAiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAo aW5wdXRzCisgICAgIGAoKCJvcGVuYWwiICxvcGVuYWwpKSkKKyAgICA7OyBUaGlzIGlzIHRoZSBo b21lIHBhZ2UgZm9yIHRoZSBzcGVjaWZpY2F0aW9uLCBidXQgdGhlcmUgaXMgbm8KKyAgICA7OyBw cm9qZWN0LXNwZWNpZmljIGhvbWVwYWdlLgorICAgIChob21lLXBhZ2UgImh0dHBzOi8vd3d3Lm9w ZW5hbC5vcmcvIikKKyAgICAoc3lub3BzaXMgIkltcGxlbWVudGF0aW9uIG9mIHRoZSBPcGVuQUwg VXRpbGl0eSBUb29sa2l0IChBTFVUKSIpCisgICAgKGRlc2NyaXB0aW9uICJGcmVlYWx1dCBpcyBh IGZyZWUgaW1wbGVtZW50YXRpb24gb2YgT3BlbkFMJ3MgQUxVVCBzdGFuZGFyZC4KK0FMVVQgaXMg dGhlIE9wZW5BTCBlcXVpdmFsZW50IHRvIEdMVVQgZm9tIE9wZW5HTCBhbmQgaGFzIGFuIGludGVu dGlvbmFsbHkKK3NpbWlsYXIgQVBJLiAgSXQgaXMgaW50ZW5kZWQgdG8gYWxsb3cgZGV2ZWxvcGVy cyB0byBxdWlja2x5IGxlYXJuIE9wZW5BTCB3aGlsZQorYWJzdHJhY3RpbmcgYXdheSBkZXRhaWxz IHN1Y2ggYXMgbG9hZGluZyBzb3VuZCBzYW1wbGVzIGZyb20gZGlzay4iKQorICAgIChsaWNlbnNl IGxpY2Vuc2U6bGdwbDIuMCspKSkKKwogKGRlZmluZS1wdWJsaWMgcGF0Y2hhZ2UKICAgKHBhY2th Z2UKICAgICAobmFtZSAicGF0Y2hhZ2UiKQotLSAKMS45LjEKCg== --001a113ac1ccd8413c052e9529ff--