Re: [PATCH] gnu: Add gst-plugins-ugly

[David Hashe <david.hashe@dhashe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1674 bytes --]

> +    (home-page "http://gstreamer.freedesktop.org/";)

There's an extraneous semicolon here, but once I removed that
everything worked fine and I was able to play mp3s without issue.

I've attached an updated rhythmbox patch adding gst-plugins-ugly as a
dependency along with some useful configure flags.

- David


On Tue, Jul 7, 2015 at 1:50 PM, Mark H Weaver <mhw@netris.org> wrote:

> Mark H Weaver <mhw@netris.org> writes:
>
> > David Hashe <david.hashe@dhashe.com> writes:
> >
> >> Thanks for clarifying. Besides patents, my other concern was
> >> licensing. Specifically, the page I linked about gst-plugins-ugly
> >> includes the following:
> >>
> >> The license on either the plug-ins or the supporting libraries might
> >> not be how we'd like.
> >
> > Yes, we'll need to investigate this.
> >
> >> Rather vague, but a bit worrying. However, you're right that Debian
> >> includes it, as do Trisquel and Parabola (both free distributions), so
> >> I agree that this is probably something we can include.
> >
> > I looked in Parabola's blacklist
> > <https://projects.parabola.nu/blacklist.git/tree/> and didn't find
> > issues listed with gst-plugins-ugly, so I guess that's a good sign.
> >
> > I've attached a preliminary 'gst-plugins-ugly' package for Guix.  Note
> > that this depends on commit 23da88f61e82e2b32d6dedb3af467f665cd03bf5
> > "gnu: liba52: Build shared library", which I pushed to master just a few
> > minutes ago.
>
> I've since added libmpeg2 (commit e088410984) and noticed that we
> already have libdvdread and libdvdnav (which I just updated).
>
> Here's an updated version of my preliminary 'gst-plugins-ugly' patch.
>
>      Mark
>
>
>

[-- Attachment #1.2: Type: text/html, Size: 2678 bytes --]

[-- Attachment #2: 0001-gnu-Add-rhythmbox.patch --]
[-- Type: text/x-patch, Size: 3475 bytes --]

From c3ec7cf01a6c1bf9013a2819c2c5ec7181724947 Mon Sep 17 00:00:00 2001
From: David Hashe <david.hashe@dhashe.com>
Date: Tue, 7 Jul 2015 23:40:01 -0500
Subject: [PATCH] gnu: Add rhythmbox.

* gnu/packages/gnome.scm (rhythmbox): New variable.
---
 gnu/packages/gnome.scm | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0ec5ea2..6d238af 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -56,6 +56,7 @@
   #:use-module (gnu packages libcanberra)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libusb)
+  #:use-module (gnu packages lirc)
   #:use-module (gnu packages image)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -2718,3 +2719,76 @@ the patterned block to the area bordered by green markers.  To do so, you will
 need to slide other blocks out of the way.  Complete each puzzle in as few moves
 as possible!")
     (license license:gpl2+)))
+
+(define-public rhythmbox
+ (package
+   (name "rhythmbox")
+   (version "3.2.1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
+   (build-system glib-or-gtk-build-system)
+   (arguments
+    `(#:configure-flags
+      (list "--enable-lirc"
+            "--enable-python"
+            "--enable-vala"
+            "--with-brasero"
+            "--with-gudev"
+            "--with-libsecret")))
+   (propagated-inputs
+    `(("dconf" ,dconf)
+      ("gobject-introspection" ,gobject-introspection)
+      ("gst-libav" ,gst-libav)
+      ("gst-plugins-base" ,gst-plugins-base)
+      ("gst-plugins-good" ,gst-plugins-good)
+      ("gst-plugins-ugly" ,gst-plugins-ugly)
+      ("totem-pl-parser" ,totem-pl-parser)))
+   (native-inputs
+    `(("intltool" ,intltool)
+      ("glib" ,glib "bin")
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("json-glib" ,json-glib)
+      ("tdb" ,tdb)
+      ("gnome-desktop" ,gnome-desktop)
+      ("python" ,python)
+      ("python-pygobject" ,python2-pygobject)
+      ("vala" ,vala)
+      ("gmime" ,gmime)
+      ("nettle" ,nettle)
+      ("itstool" ,itstool)
+      ("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("gstreamer" ,gstreamer)
+      ("gudev" ,eudev)
+      ;("libmtp" ,libmtp) FIXME Not detected
+      ("libsecret" ,libsecret)
+      ("libsoup" ,libsoup)
+      ("libnotify" ,libnotify)
+      ("libpeas" ,libpeas)
+      ("lirc" ,lirc)
+      ; TODO Unused without mx
+      ;("clutter" ,clutter)
+      ;("clutter-gtk" ,clutter-gtk)
+      ;("clutter-gst" ,clutter-gst)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("atk" ,atk)
+      ("pango" ,pango)
+      ("gtk+" ,gtk+)
+      ;; TODO:
+      ;;  * grilo
+      ;;  * libgpod
+      ;;  * mx
+      ;;  * webkit
+      ("brasero" ,brasero)))
+   (home-page "https://wiki.gnome.org/Apps/Rhythmbox")
+   (synopsis "Music player for GNOME")
+   (description "Rhythmbox is a music playing application for GNOME.  It
+supports playlists, song ratings, and any codecs installed through gstreamer.")
+   (license license:gpl2+)))
-- 
1.9.1