From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH 1/2] gnu: Add gtksourceview. Date: Sun, 8 Nov 2015 11:16:48 -0600 Message-ID: References: <1446959917-25693-1-git-send-email-david.hashe@dhashe.com> <87wptsvgt9.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11434a3a5904b705240aa46e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvTaF-0007FP-HB for guix-devel@gnu.org; Sun, 08 Nov 2015 12:16:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvTaE-0002UJ-2g for guix-devel@gnu.org; Sun, 08 Nov 2015 12:16:51 -0500 Received: from mail-yk0-x22b.google.com ([2607:f8b0:4002:c07::22b]:36374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvTaD-0002UF-Rs for guix-devel@gnu.org; Sun, 08 Nov 2015 12:16:49 -0500 Received: by ykba4 with SMTP id a4so232128710ykb.3 for ; Sun, 08 Nov 2015 09:16:49 -0800 (PST) In-Reply-To: <87wptsvgt9.fsf@member.fsf.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?B?5a6L5paH5q2m?= Cc: guix-devel@gnu.org --001a11434a3a5904b705240aa46e Content-Type: multipart/alternative; boundary=001a11434a3a5904b105240aa46c --001a11434a3a5904b105240aa46c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, Nov 8, 2015 at 6:03 AM, =E5=AE=8B=E6=96=87=E6=AD=A6 wrote: > David Hashe writes: > > > * gnu/packages/gnome.scm (gtksourceview): New variable. > > --- > > gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > > index 5440433..9bd1c31 100644 > > --- a/gnu/packages/gnome.scm > > +++ b/gnu/packages/gnome.scm > > @@ -3659,3 +3659,37 @@ environment that allows users to view, unpack, > and create compressed archives > > such as gzip tarballs.") > > (home-page "http://fileroller.sourceforge.net/") > > (license license:gpl2+))) > > + > > +(define-public gtksourceview > > + (package > > + (name "gtksourceview") > > + (version "3.16.1") > Why not use the latest stable 3.18.x? > Changed to 3.18.1. > > + (source (origin > > + (method url-fetch) > > + (uri (string-append "mirror://gnome/sources/" name "/" > > + (version-major+minor version) "/" > > + name "-" version ".tar.xz")) > > + (sha256 > > + (base32 > > + "030v7x1dmx5blqi9jcknsjd91jppbpl7f4z69k8c8kklr939i7k6"))= )) > > + (build-system glib-or-gtk-build-system) > > + (arguments > > + '(#:tests? #f)) ; Tries to open graphical display during testing > and fails > > + (native-inputs > > + `(("intltool" ,intltool) > > + ("itstool", itstool) > > + ("gobject-introspection" ,gobject-introspection) > > + ("pkg-config" ,pkg-config))) > > + (inputs > > + `(("glib" ,glib) > > + ("gtk+" ,gtk+) > > + ("libxml2" ,libxml2) > > + ("pango" ,pango) > > + ("gdk-pixbuf" ,gdk-pixbuf) > > + ("vala" ,vala))) > > + (home-page "https://wiki.gnome.org/Projects/GtkSourceView ") > extra space ^ > > + (synopsis "GNOME source code widget") > > + (description "GtkSourceView is a text widget that extends the > standard > > +GTK+ text widget GtkTextView. It improves GtkTextView by implementing > syntax > We use two spaces after period ^ > Fixed. > > +highlighting and other features typical of a source code editor.") > > + (license license:lgpl2.1+))) > > Thanks for the feedback! I've attached an updated patch. --001a11434a3a5904b105240aa46c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Sun, Nov 8, 2015 at 6:03 AM, =E5=AE=8B=E6=96=87=E6=AD=A6 <iy= zsong@member.fsf.org> wrote:
David Hashe <david.hashe@dhashe.com> writes:

> * gnu/packages/gnome.scm (gtksourceview): New variable.
> ---
>=C2=A0 gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++ >=C2=A0 1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 5440433..9bd1c31 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3659,3 +3659,37 @@ environment that allows users to view, unpack, = and create compressed archives
>=C2=A0 such as gzip tarballs.")
>=C2=A0 =C2=A0 =C2=A0 (home-page "http://fileroller.source= forge.net/")
>=C2=A0 =C2=A0 =C2=A0 (license license:gpl2+)))
> +
> +(define-public gtksourceview
> + (package
> +=C2=A0 =C2=A0(name "gtksourceview")
> +=C2=A0 =C2=A0(version "3.16.1")
Why not use the latest stable 3.18.x?

Changed to= 3.18.1.
=C2=A0
> +=C2=A0 =C2=A0(source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method url-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (string-append "m= irror://gnome/sources/" name "/"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (version-major+minor version) &q= uot;/"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name "-" version "= ;.tar.xz"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "030v7x1dmx5blq= i9jcknsjd91jppbpl7f4z69k8c8kklr939i7k6"))))
> +=C2=A0 =C2=A0(build-system glib-or-gtk-build-system)
> +=C2=A0 =C2=A0(arguments
> +=C2=A0 =C2=A0 '(#:tests? #f)) ; Tries to open graphical display d= uring testing and fails
> +=C2=A0 =C2=A0(native-inputs
> +=C2=A0 =C2=A0 `(("intltool" ,intltool)
> +=C2=A0 =C2=A0 =C2=A0 ("itstool", itstool)
> +=C2=A0 =C2=A0 =C2=A0 ("gobject-introspection" ,gobject-intr= ospection)
> +=C2=A0 =C2=A0 =C2=A0 ("pkg-config" ,pkg-config)))
> +=C2=A0 =C2=A0(inputs
> +=C2=A0 =C2=A0 `(("glib" ,glib)
> +=C2=A0 =C2=A0 =C2=A0 ("gtk+" ,gtk+)
> +=C2=A0 =C2=A0 =C2=A0 ("libxml2" ,libxml2)
> +=C2=A0 =C2=A0 =C2=A0 ("pango" ,pango)
> +=C2=A0 =C2=A0 =C2=A0 ("gdk-pixbuf" ,gdk-pixbuf)
> +=C2=A0 =C2=A0 =C2=A0 ("vala" ,vala)))
> +=C2=A0 =C2=A0(home-page "https://wiki.gnome.= org/Projects/GtkSourceView ")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 extra space=C2=A0 =C2=A0 =C2=A0 ^
> +=C2=A0 =C2=A0(synopsis "GNOME source code widge= t")
> +=C2=A0 =C2=A0(description "GtkSourceView is a text widget that e= xtends the standard
> +GTK+ text widget GtkTextView. It improves GtkTextView by implementing= syntax
We use two spaces after period=C2=A0 ^

Fixed.
=C2=A0
> +highlighting and other featur= es typical of a source code editor.")
> +=C2=A0 =C2=A0(license license:lgpl2.1+)))


Thanks for the feedback! I'= ;ve attached an updated patch.
--001a11434a3a5904b105240aa46c-- --001a11434a3a5904b705240aa46e Content-Type: text/x-patch; charset=US-ASCII; name="0001-gnu-Add-gtksourceview.patch" Content-Disposition: attachment; filename="0001-gnu-Add-gtksourceview.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igqs7jme0 RnJvbSAwNmY4OTY0ZGM0MjZhY2Q0ZWRiNzBkMzExMzI5ODJlMGMxZDVkY2E5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogU2F0LCA3IE5vdiAyMDE1IDIyOjM4OjA5IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzNd IGdudTogQWRkIGd0a3NvdXJjZXZpZXcuCgoqIGdudS9wYWNrYWdlcy9nbm9tZS5zY20gKGd0a3Nv dXJjZXZpZXcpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dub21lLnNjbSB8IDM0 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNCBp bnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dub21lLnNjbSBiL2dudS9w YWNrYWdlcy9nbm9tZS5zY20KaW5kZXggNTQ0MDQzMy4uOWM0YjE4MiAxMDA2NDQKLS0tIGEvZ251 L3BhY2thZ2VzL2dub21lLnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCkBAIC0zNjU5 LDMgKzM2NTksMzcgQEAgZW52aXJvbm1lbnQgdGhhdCBhbGxvd3MgdXNlcnMgdG8gdmlldywgdW5w YWNrLCBhbmQgY3JlYXRlIGNvbXByZXNzZWQgYXJjaGl2ZXMKIHN1Y2ggYXMgZ3ppcCB0YXJiYWxs cy4iKQogICAgIChob21lLXBhZ2UgImh0dHA6Ly9maWxlcm9sbGVyLnNvdXJjZWZvcmdlLm5ldC8i KQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKworKGRlZmluZS1wdWJsaWMgZ3Rrc291 cmNldmlldworIChwYWNrYWdlCisgICAobmFtZSAiZ3Rrc291cmNldmlldyIpCisgICAodmVyc2lv biAiMy4xOC4xIikKKyAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgKG1ldGhvZCB1cmwt ZmV0Y2gpCisgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJtaXJyb3I6Ly9nbm9tZS9z b3VyY2VzLyIgbmFtZSAiLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHZlcnNp b24tbWFqb3IrbWlub3IgdmVyc2lvbikgIi8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG5hbWUgIi0iIHZlcnNpb24gIi50YXIueHoiKSkKKyAgICAgICAgICAgIChzaGEyNTYKKyAg ICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICIxcnBkZzhyY2pscXY4eWsxM3ZzaDUx NDhtYWRzMHpiZmloOGNhazNobTd3YjBzcG16c2J2IikpKSkKKyAgIChidWlsZC1zeXN0ZW0gZ2xp Yi1vci1ndGstYnVpbGQtc3lzdGVtKQorICAgKGFyZ3VtZW50cworICAgICcoIzp0ZXN0cz8gI2Yp KSA7IFRyaWVzIHRvIG9wZW4gZ3JhcGhpY2FsIGRpc3BsYXkgZHVyaW5nIHRlc3RpbmcgYW5kIGZh aWxzCisgICAobmF0aXZlLWlucHV0cworICAgIGAoKCJpbnRsdG9vbCIgLGludGx0b29sKQorICAg ICAgKCJpdHN0b29sIiwgaXRzdG9vbCkKKyAgICAgICgiZ29iamVjdC1pbnRyb3NwZWN0aW9uIiAs Z29iamVjdC1pbnRyb3NwZWN0aW9uKQorICAgICAgKCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykp KQorICAgKGlucHV0cworICAgIGAoKCJnbGliIiAsZ2xpYikKKyAgICAgICgiZ3RrKyIgLGd0aysp CisgICAgICAoImxpYnhtbDIiICxsaWJ4bWwyKQorICAgICAgKCJwYW5nbyIgLHBhbmdvKQorICAg ICAgKCJnZGstcGl4YnVmIiAsZ2RrLXBpeGJ1ZikKKyAgICAgICgidmFsYSIgLHZhbGEpKSkKKyAg IChob21lLXBhZ2UgImh0dHBzOi8vd2lraS5nbm9tZS5vcmcvUHJvamVjdHMvR3RrU291cmNlVmll dyAiKQorICAgKHN5bm9wc2lzICJHTk9NRSBzb3VyY2UgY29kZSB3aWRnZXQiKQorICAgKGRlc2Ny aXB0aW9uICJHdGtTb3VyY2VWaWV3IGlzIGEgdGV4dCB3aWRnZXQgdGhhdCBleHRlbmRzIHRoZSBz dGFuZGFyZAorR1RLKyB0ZXh0IHdpZGdldCBHdGtUZXh0Vmlldy4gIEl0IGltcHJvdmVzIEd0a1Rl eHRWaWV3IGJ5IGltcGxlbWVudGluZyBzeW50YXgKK2hpZ2hsaWdodGluZyBhbmQgb3RoZXIgZmVh dHVyZXMgdHlwaWNhbCBvZiBhIHNvdXJjZSBjb2RlIGVkaXRvci4iKQorICAgKGxpY2Vuc2UgbGlj ZW5zZTpsZ3BsMi4xKykpKQotLSAKMS45LjEKCg== --001a11434a3a5904b705240aa46e--