Re: [PATCH] gnu: Add rhythmbox.

[David Hashe <david.hashe@dhashe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3597 bytes --]

On Sun, Jul 5, 2015 at 2:24 PM, Amirouche Boubekki <amirouche@hypermove.net>
wrote:

> On 2015-07-05 19:45, Amirouche Boubekki wrote:
>
>> On 2015-07-05 17:28, David Hashe wrote:
>>
>>> Hi Ludo and Ricardo,
>>>
>>> The 'uridecodebin' error is a result of GST_PLUGIN_SYSTEM_PATH not
>>> being set. However, the recent patch to gstreamer adds that to its
>>> native search paths, so that error should be resolved now on an
>>> updated system. I had a line defining GST_PLUGIN_SYSTEM_PATH in my
>>> .bashrc, but I was able to remove it after that patch was applied.
>>> Rhythmbox is working without errors for me.
>>>
>>> I've also realized that some of the packages I put under inputs should
>>> probably be propagated inputs, so I'm attaching an updated patch which
>>> changes that.
>>>
>>> I am currently using guix over ubuntu.
>>>
>>
>> I use GuixSD. I patched my guix git repository just after they were
>> published.
>>
>> It works, or more precisly it can work:
>>
>> - I have the following in my .bashrc:
>>
>> export GST_PLUGIN_SYSTEM_PATH=$HOME/.guix-profile/lib/gstreamer-1.0
>> export GRL_PLUGIN_PATH=$HOME/.guix-profile/lib/grilo-0.2
>>
>> - Also I installed several gstreamer packages.
>>
>> I only tried to play mp3 and ogg. Ogg works. I did not try burning audio
>> cds.
>> I will try later today or tomorrow.
>>
>
mp3 support requires gst-plugins-ugly, which includes nonfree and
patent-encumbered codecs. More information at
http://gstreamer.freedesktop.org/modules/gst-plugins-ugly.html

As a side note, it appears that we do package some patent-encumbered
software, such as LAME, so I'm not sure what our stance is on software
patents themselves.


>
> Both cd burning and ripping doesn't work:
>
> - audio burn: the plugin appears in the list of plugins and can be
> activated. When activated it doesn't appear in the player UI to actually
> burn playlists
> - ripping: no mention of it at all in the UI
>

You're right. I don't usually use CDs, so I wasn't able to test it very
well. I'll try to figure out why this is.


>
>
>>
>>
>>
>>> Thanks,
>>>
>>> David
>>>
>>> On Sun, Jul 5, 2015 at 6:44 AM, Ricardo Wurmus <rekado@elephly.net>
>>> wrote:
>>>
>>>  So, I applied the patch, built rhythmbox, and installed it into a
>>>>>> separate profile. It starts up fine and begins importing files
>>>>>>
>>>>> from
>>>>
>>>>> ~/Music but I get a *lot* of import errors:
>>>>>>
>>>>>> “Couldn’t create ‘uridecodebin’ element”
>>>>>>
>>>>>> I see this for a great many ogg and mp3 files in my ~/Music
>>>>>>
>>>>> directory
>>>>
>>>>> under “Import Errors”. In fact, none of my audio files in
>>>>>>
>>>>> ~/Music were
>>>>
>>>>> imported at all.
>>>>>>
>>>>>
>>>>>
> I used to have errors when I did not install gstreamer plugins.
>
>
>
My bad on saying that GST_PLUGIN_SYSTEM_PATH is not required; I resourced
my .bashrc but left the path in my environment. I'm currently using the
following variables to make things work:

export GST_PLUGIN_SYSTEM_PATH=/home/dhashe/.guix-profile/lib/gstreamer-1.0
# needed for importing music
export GIO_EXTRA_MODULES=/home/dhashe/.guix-profile/lib/gio/modules #
needed for playlist support

I don't have GRL_PLUGIN_PATH set yet because the patch adding grilo hasn't
been committed yet (grilo is also commented out in this patch) but you're
right that we will probably need it in the future.

I've also moved totem-pl-parser to propagated inputs for playlist support
in the attached, updated patch.

Thanks,
David

[-- Attachment #1.2: Type: text/html, Size: 6554 bytes --]

[-- Attachment #2: 0001-gnu-Add-rhythmbox.patch --]
[-- Type: text/x-patch, Size: 2691 bytes --]

From e544b1d2e2689225d447ec38e3f41b44a6f9311b Mon Sep 17 00:00:00 2001
From: David Hashe <david.hashe@dhashe.com>
Date: Sun, 5 Jul 2015 10:24:22 -0500
Subject: [PATCH] gnu: Add rhythmbox.

* gnu/packages/gnome.scm (rhythmbox): New variable.
---
 gnu/packages/gnome.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3882a7a..ffd83e8 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2718,3 +2718,59 @@ the patterned block to the area bordered by green markers.  To do so, you will
 need to slide other blocks out of the way.  Complete each puzzle in as few moves
 as possible!")
     (license license:gpl2+)))
+
+(define-public rhythmbox
+ (package
+   (name "rhythmbox")
+   (version "3.2.1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "0f3radhlji7rxl760yl2vm49fvfslympxrpm8497acbmbd7wlhxz"))))
+   (build-system glib-or-gtk-build-system)
+   (propagated-inputs
+    `(("dconf" ,dconf)
+      ("gst-libav" ,gst-libav)
+      ("gst-plugins-base" ,gst-plugins-base)
+      ("gst-plugins-good" ,gst-plugins-good)
+      ("totem-pl-parser" ,totem-pl-parser)))
+   (native-inputs
+    `(("intltool" ,intltool)
+      ("glib" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("json-glib" ,json-glib)
+      ("libpeas" ,libpeas)
+      ("tdb" ,tdb)
+      ("webkitgtk" ,webkitgtk)
+      ("gnome-desktop" ,gnome-desktop)
+      ("python" ,python)
+      ("gmime" ,gmime)
+      ("nettle" ,nettle)
+      ("itstool" ,itstool)
+      ("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("gstreamer" ,gstreamer)
+      ("gudev" ,eudev)
+      ("libmtp" ,libmtp)
+      ("libsecret" ,libsecret)
+      ("libnotify" ,libnotify)
+      ("clutter" ,clutter)
+      ("clutter-gtk" ,clutter-gtk)
+      ("clutter-gst" ,clutter-gst)
+      ;("grilo" ,grilo)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("atk" ,atk)
+      ("pango" ,pango)
+      ("brasero" ,brasero)
+      ("desktop-file-utils" ,desktop-file-utils)))
+   (home-page "https://wiki.gnome.org/Apps/Rhythmbox")
+   (synopsis "Music player for GNOME")
+   (description "Rhythmbox is a music playing application for GNOME.  It
+supports playlists, song ratings, and any codecs installed through gstreamer.")
+   (license license:gpl2+)))
+
-- 
1.9.1