From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47295) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJYXs-0007oD-83 for guix-patches@gnu.org; Sun, 13 Oct 2019 03:44:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJYXq-0005z0-S8 for guix-patches@gnu.org; Sun, 13 Oct 2019 03:44:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJYXq-0005yn-N8 for guix-patches@gnu.org; Sun, 13 Oct 2019 03:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJYXq-00036s-KI for guix-patches@gnu.org; Sun, 13 Oct 2019 03:44:02 -0400 Subject: bug#35813: [PATCH] Add crate-recursive-import. Resent-To: guix-patches@gnu.org Resent-Message-ID: MIME-Version: 1.0 References: <20190808103956.GD5507@E2140> <20190908075730.GA977@E5400> In-Reply-To: <20190908075730.GA977@E5400> From: Brian Leung Date: Sun, 13 Oct 2019 00:42:22 -0700 Message-ID: Content-Type: multipart/alternative; boundary="000000000000674cde0594c5e6b3" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 35813-done@debbugs.gnu.org, Ivan Petkov --000000000000674cde0594c5e6b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Closing this since someone else already merged their own crate recursive importer. On Sun, Sep 8, 2019 at 12:57 AM Efraim Flashner wrote: > As a simple test I ran 'guix import crate encoding -r' and it gave me > the 6 packages I expected. 'guix import crate winapi -r' only gave me > rust-winapi, as the dependent crates are already packaged. When I tried > 'guix import crate rand -r' it found the updated version and started > importing all the new dependencies also. > > It looks good. I'm tempted to leave it running with 'guix import crate > serde -r' just to see if we're ever going to make it there. > > I see that it imports A then B then C then D, and prints out D then C > then B then A. For the one I tested with is still rust-encoding. I'll > try my hand at ascii art: > > encoding > | > ------------------------------------------------------- > | | | | | > japanese korean simpchinese singlebyte tradchinese > | | | | | > ------------------------------------------------------- > | > encoding-tests > > import went encoding, japanese, tests, korean, simpchinese, singlebyte, > tradchinese > > I think the only thing I would wish for would be to do tests, then the > languages and then encoding (best for upstreaming one at a time), or to > do them alphabetically (plop them in alphabetically all at once). This > I'm happy to live without I think. > > The other thing was I ran 'guix import crate security-framework -r' and > after ~40 crates it crashed on me with: > web/http.scm:1186:15: In procedure read-response-line: > Bad Read-Header-Line header: # > and I would prefer to have the ~40 crates it did grab first to be > printed out and not lost. Between these two I would like most to not > lose the imported crates than worrying over the printed order. > > Great job! From what I've tested I think it's ready as-is and any > changes would just be gravy. > > > -- > Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed > --000000000000674cde0594c5e6b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Closing this since someone else already merged their = own crate recursive importer.

On Sun, Sep 8, 2019 at 12:57 AM Efraim Flashn= er <efraim@flashner.co.il&g= t; wrote:
As a s= imple test I ran 'guix import crate encoding -r' and it gave me
the 6 packages I expected. 'guix import crate winapi -r' only gave = me
rust-winapi, as the dependent crates are already packaged. When I tried
'guix import crate rand -r' it found the updated version and starte= d
importing all the new dependencies also.

It looks good. I'm tempted to leave it running with 'guix import cr= ate
serde -r' just to see if we're ever going to make it there.

I see that it imports A then B then C then D, and prints out D then C
then B then A. For the one I tested with is still rust-encoding. I'll try my hand at ascii art:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 encoding
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |
=C2=A0 -------------------------------------------------------
=C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|
japanese=C2=A0 korean=C2=A0 =C2=A0 =C2=A0 simpchinese=C2=A0 =C2=A0 singleby= te=C2=A0 =C2=A0 =C2=A0tradchinese
=C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|
=C2=A0 -------------------------------------------------------
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 |
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0encoding-test= s

import went encoding, japanese, tests, korean, simpchinese, singlebyte,
tradchinese

I think the only thing I would wish for would be to do tests, then the
languages and then encoding (best for upstreaming one at a time), or to
do them alphabetically (plop them in alphabetically all at once). This
I'm happy to live without I think.

The other thing was I ran 'guix import crate security-framework -r'= and
after ~40 crates it crashed on me with:
=C2=A0 =C2=A0 web/http.scm:1186:15: In procedure read-response-line:
=C2=A0 =C2=A0 Bad Read-Header-Line header: #<eof>
and I would prefer to have the ~40 crates it did grab first to be
printed out and not lost. Between these two I would like most to not
lose the imported crates than worrying over the printed order.

Great job! From what I've tested I think it's ready as-is and any changes would just be gravy.


--
Efraim Flashner=C2=A0 =C2=A0<efraim@flashner.co.il>=C2=A0 =C2=A0=D7=90=D7=A4=D7= =A8=D7=99=D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D=C2=A0 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted=
--000000000000674cde0594c5e6b3--