From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KBTfOVJ4OWCmRQAA0tVLHw (envelope-from ) for ; Fri, 26 Feb 2021 22:38:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 3oOPNVJ4OWA9AQAAbx9fmQ (envelope-from ) for ; Fri, 26 Feb 2021 22:38:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFA3E173B0 for ; Fri, 26 Feb 2021 23:38:09 +0100 (CET) Received: from localhost ([::1]:37886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFlkO-00086A-Mu for larch@yhetil.org; Fri, 26 Feb 2021 17:38:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFlkI-00085q-8c for guix-patches@gnu.org; Fri, 26 Feb 2021 17:38:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFlkI-00038H-1D for guix-patches@gnu.org; Fri, 26 Feb 2021 17:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFlkH-0008Iw-Se for guix-patches@gnu.org; Fri, 26 Feb 2021 17:38:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46805] [PATCH] guix: ui: Improved error reporting when user file eval fails Resent-From: Rovanion Luckey Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Feb 2021 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46805 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46805@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161437904331867 (code B ref -1); Fri, 26 Feb 2021 22:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Feb 2021 22:37:23 +0000 Received: from localhost ([127.0.0.1]:42733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFljf-0008Ht-7e for submit@debbugs.gnu.org; Fri, 26 Feb 2021 17:37:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:39498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFljd-0008Hm-RJ for submit@debbugs.gnu.org; Fri, 26 Feb 2021 17:37:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFljc-00082y-8j for guix-patches@gnu.org; Fri, 26 Feb 2021 17:37:21 -0500 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:33427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFljY-0002oJ-0J for guix-patches@gnu.org; Fri, 26 Feb 2021 17:37:19 -0500 Received: by mail-io1-xd32.google.com with SMTP id e2so8023906iog.0 for ; Fri, 26 Feb 2021 14:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=uuCmdpx7sKJShiecAEyt8WCqA7qxWTfqZgJjlpXwf8o=; b=Edm0fkov5DBKViYX/GZC12WJaHKgwJbej0/AB99aaT2/EnLPswyN8hm1yWuij7HwCB ePotAzsH8BZADn/afzFymwHZ7JvVtqLGfFu+8+RsIHz3yQXUJshWJdJUEAi3Sufev0Fb v83uCR8/BosI8MQayQ3kGulyOdZ5XgkhKoZISa9DyUtwjHMxydMxMa+gMu7MS8c6h441 174gF0ghKxvvssCJKdN0I/xfqdy3Vqvp2kIGXf84oxv+aANMjL6zSgZg5cmIL7Q3wY8E 5LL3r5IPNWmetosph95N7xHMEm9SoHzF0F2gQvMhPyiem4/o7aJxmjwqM1ssd4Xh3NVy 1wKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uuCmdpx7sKJShiecAEyt8WCqA7qxWTfqZgJjlpXwf8o=; b=QhJbtFUjcNSimwqg/RRIAdrFzlwoEiyDxlvxBlAZ8kzzdx120TDZAwTZqhIYlrGSx8 /lW7mv6lQ2WYngxlk+VErubBJ3iToAhaRAmz6g5mLBrlkcWzzbQxPwoJxq12cyKVT/DV 4eMQgLx2ATQf2P06r0hixvyE7KHtqHRJLJmn+tqgYmWqphNs9G2QESULuQgPzJQfAS6N wR9CBbHoOWCeDRgy8WnEhoVOL/jiMzTBxUWLDs4rRuWWYGGxnMflft6L1v+Uu6hdNkZO K00Rmm8ZxNnxoOJnum9H0u0xqck9VBLFWpAnO3wPn6gKhpxDpg8SgFAgAWmzD9hY9RLL dYlQ== X-Gm-Message-State: AOAM530kpkhxa80inh3bWda1xuCztirwIseXHaLPTUH/qtlH+L/MJP78 LkhJ6Jlz7cUWAglo1+wlTZ5MVUShJ0wMgwKY0A0F5GRrgXc= X-Google-Smtp-Source: ABdhPJxmn+6UUE3hu710685ozDz1UaOvUFS+PyXxeZlvEX/4nG6k0sFf/OXkwoUlkcVm3xyEX5Jk2iM1oXokeyYL7ew= X-Received: by 2002:a6b:d01a:: with SMTP id x26mr4612016ioa.11.1614379032262; Fri, 26 Feb 2021 14:37:12 -0800 (PST) MIME-Version: 1.0 From: Rovanion Luckey Date: Fri, 26 Feb 2021 23:36:46 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000c088ea05bc44e88e" Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=rovanion.luckey@gmail.com; helo=mail-io1-xd32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614379090; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=CeDmnxJLG0P7arSL2mIalHbsu3Uui+gjdmgcGY+KTEk=; b=fw28HT4B6162BnXJb7OhbeZr7D0933rVVYmE73UeLHjqiGpEYO/kXmbWAtCbpijEeU/au+ 0AhtlNNo9HhePdh4/oYgkBUL2OcX4zVI0D4OfVSJletQ/ee3VBgd2CsKnBhPH0kLQTWO/M +suWYr6hmcrdMa8ZUg2EJURB0YTE/DPPMvheeTj5eqFbsNppWvsIE4zIoo+V6xRH3moN5b lEcuh4LpZa8uE9nXtbXhJGYqGeYShFwyQ4JaCenhCNWyhTmjumfKM7OY2G9zSOoc9kUMkI I1HPW7QHh4HOj9GucyePmOKnJg/5VKzkEAHx1QnqA1oKBiRZPCHqenP5QgJCAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614379090; a=rsa-sha256; cv=none; b=HSCx7PNRNJelvjZV2bFFotF2p+kEMCuHpgRWV7jowKTjxEFWePRknveHEP+5fr9hRBpPqP hg2V8gBXfbD4vPGl4wq78tfI5eujtYszrtDWnpbzDOldFqLxdMMa9szNnA5JVKLqce46xa zOJ4lW6oCcd/kbf6x+AiKK522adlAZgyUSWYLRneVb3Y/fwdikiY31LuSqRSKu1mRFB1tR zP2UfwhpKB04D8KbFIAK50Q7QXDDZaw/86oup+wVWrWisT1FnyD3Ouu//7Q8ZtOr3KhRjm 3SbnJNeOhwvPgD7xM6LuDke6O/GivvxMT4RPA34CHb0qwHbrYMKqsZwdZLnkSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=Edm0fkov; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=Edm0fkov; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CFA3E173B0 X-Spam-Score: -0.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: QiKTVIZKOemH --000000000000c088ea05bc44e88e Content-Type: multipart/alternative; boundary="000000000000c088e805bc44e88c" --000000000000c088e805bc44e88c Content-Type: text/plain; charset="UTF-8" Added a specific error message for when the user provided scheme file being evaluated in turn fails to load another file. Also clearified the error message given on generic system errors, to make it clear where the error originates from. See attached patch. --000000000000c088e805bc44e88c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Added a specific error message for when the user prov= ided scheme file being evaluated in turn fails to load another file. Also c= learified the error message given on generic system errors, to make it clea= r where the error originates from.

See attached pa= tch.
--000000000000c088e805bc44e88c-- --000000000000c088ea05bc44e88e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-guix-ui-Improved-error-reporting-when-user-file-eval.patch" Content-Disposition: attachment; filename="0001-guix-ui-Improved-error-reporting-when-user-file-eval.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_klmvk1ma0 RnJvbSA1NzEyNmNiZmYzOGRlNzI4ZDY0Nzk3NTUxMjM5NzIzZWQxODU3NWE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb3ZhbmlvbiBMdWNrZXkgPHJvdmFuaW9uLmx1Y2tleUBnbWFp bC5jb20+CkRhdGU6IEZyaSwgMjYgRmViIDIwMjEgMjM6MjM6MTQgKzAxMDAKU3ViamVjdDogW1BB VENIXSBndWl4OiB1aTogSW1wcm92ZWQgZXJyb3IgcmVwb3J0aW5nIHdoZW4gdXNlciBmaWxlIGV2 YWwgZmFpbHMKIGR1ZSB0byBzeXN0ZW0gZXJyb3JzCgpBZGRlZCBhIHNwZWNpZmljIGVycm9yIG1l c3NhZ2UgZm9yIHdoZW4gdGhlIHVzZXIgcHJvdmlkZWQgc2NoZW1lIGZpbGUgYmVpbmcgZXZhbHVh dGVkIGluIHR1cm4gZmFpbHMgdG8gbG9hZCBhbm90aGVyIGZpbGUuIEFsc28gY2xlYXJpZmllZCB0 aGUgZXJyb3IgbWVzc2FnZSBnaXZlbiBvbiBnZW5lcmljIHN5c3RlbSBlcnJvcnMsIHRvIG1ha2Ug aXQgY2xlYXIgd2hlcmUgdGhlIGVycm9yIG9yaWdpbmF0ZXMgZnJvbS4KLS0tCiBndWl4L3VpLnNj bSB8IDcgKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2d1aXgvdWkuc2NtIGIvZ3VpeC91aS5zY20KaW5kZXggN2ZiZDRj NjNhMi4uMGVhYmYxMzZmNiAxMDA2NDQKLS0tIGEvZ3VpeC91aS5zY20KKysrIGIvZ3VpeC91aS5z Y20KQEAgLTM3Myw5ICszNzMsMTQgQEAgaXQgZG9lc24ndC4iCiAgICJSZXBvcnQgdGhlIGZhaWx1 cmUgdG8gbG9hZCBGSUxFLCBhIHVzZXItcHJvdmlkZWQgU2NoZW1lIGZpbGUuCiBBUkdTIGlzIHRo ZSBsaXN0IG9mIGFyZ3VtZW50cyByZWNlaXZlZCBieSB0aGUgJ3Rocm93JyBoYW5kbGVyLiIKICAg KG1hdGNoIGFyZ3MKKyAgICAoKCdzeXN0ZW0tZXJyb3IgIm9wZW4tZmlsZSIgLiByZXN0KQorICAg ICAobGV0ICgoZXJyIChzeXN0ZW0tZXJyb3ItZXJybm8gYXJncykpCisgICAgICAgICAgIChmaWxl LXdoaWNoLWZhaWxlZC10by1vcGVuIChjYXIgKGNkciAoY2FyIChjZHIgcmVzdCkpKSkpKQorICAg ICAgIChyZXBvcnQtZXJyb3IgKEdfICJ3aGlsZSBldmFsdWF0aW5nICd+YScsIGl0IGZhaWxlZCBv cGVuaW5nICd+YScgd2l0aCB0aGUgZXJyb3I6IH5hfiUiKQorICAgICAgICAgICAgICAgICAgICAg ZmlsZSBmaWxlLXdoaWNoLWZhaWxlZC10by1vcGVuIChzdHJlcnJvciBlcnIpKSkpCiAgICAgKCgn c3lzdGVtLWVycm9yIC4gcmVzdCkKICAgICAgKGxldCAoKGVyciAoc3lzdGVtLWVycm9yLWVycm5v IGFyZ3MpKSkKLSAgICAgICAocmVwb3J0LWVycm9yIChHXyAiZmFpbGVkIHRvIGxvYWQgJ35hJzog fmF+JSIpIGZpbGUgKHN0cmVycm9yIGVycikpKSkKKyAgICAgICAocmVwb3J0LWVycm9yIChHXyAi ZmFpbGVkIHRvIGV2YWx1YXRlICd+YScsIGl0IHJhaXNlZCB0aGUgZXJyb3I6IH5hfiUiKSBmaWxl IChzdHJlcnJvciBlcnIpKSkpCiAgICAgKCgncmVhZC1lcnJvciAic2NtX2lfbHJlYWRwYXJlbiIg bWVzc2FnZSBfIC4uLikKICAgICAgOzsgR3VpbGUncyBtaXNzaW5nLXBhcmVuIG1lc3NhZ2VzIGFy ZSBvYnNjdXJlIHNvIHdlIG1ha2UgdGhlbSBtb3JlCiAgICAgIDs7IGludGVsbGlnaWJsZSBoZXJl LgotLSAKMi4zMC4wCgo= --000000000000c088ea05bc44e88e--