From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rohan Prinja Subject: Re: [PATCH] getifaddrs wrapper Date: Thu, 16 Jul 2015 19:20:59 +0530 Message-ID: References: <87mvzvykfx.fsf@gnu.org> <87a8veeoip.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1147a50e8e7101051afe5c7e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFjZ0-0001br-DJ for guix-devel@gnu.org; Thu, 16 Jul 2015 09:51:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFjYz-0007Uo-6y for guix-devel@gnu.org; Thu, 16 Jul 2015 09:51:02 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel --001a1147a50e8e7101051afe5c7e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Added a convenience macro to make the filtering out of unneeded interfaces cleaner. On 16 July 2015 at 14:00, Rohan Prinja wrote: > A bug causing broadcast-addr and other fields AFTER the flags field in > 'struct getifaddrs' to be accessed incorrectly has been fixed. > > On 2 July 2015 at 17:53, Ludovic Court=C3=A8s wrote: >> Rohan Prinja skribis: >> >>> PTAL, tests to follow soon. >> >> It=E2=80=99s looking good now, thanks! >> >> Could you send the updated patch against master, that includes a simple >> test in tests/syscalls.scm that makes sure that =E2=80=98getifaddrs=E2= =80=99 returns a >> possibly empty list of ? >> >> TIA, >> Ludo=E2=80=99. --001a1147a50e8e7101051afe5c7e Content-Type: text/x-patch; charset=US-ASCII; name="0001-guix-build-syscalls.scm-tests-syscalls.scm-un-export.patch" Content-Disposition: attachment; filename="0001-guix-build-syscalls.scm-tests-syscalls.scm-un-export.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ic6984ct5 RnJvbSA2MTkyZTlhMTdiNTJiOTVkMzA3ZmM4MDI2OGY4NTRkOGU4ODYwMDVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2hhbiBQcmluamEgPHJvaGFuLnByaW5qYUBnbWFpbC5jb20+ CkRhdGU6IFRodSwgMTYgSnVsIDIwMTUgMTk6MTk6MjkgKzA1MzAKU3ViamVjdDogW1BBVENIXSBn dWl4L2J1aWxkL3N5c2NhbGxzLnNjbSwgdGVzdHMvc3lzY2FsbHMuc2NtOiB1bi1leHBvcnQKIG1h a2UtaWZhZGRycywgYW5kIGFkZCBhIGNvbnZlbmllbmNlIG1hY3JvIHRvIGZpbHRlciBvdXQgbm9u LXVzZWZ1bCBpbnRlcmZhY2VzCgotLS0KIGd1aXgvYnVpbGQvc3lzY2FsbHMuc2NtIHwgMTcgKysr KysrKysrKystLS0tLS0KIHRlc3RzL3N5c2NhbGxzLnNjbSAgICAgIHwgMTkgKysrKysrLS0tLS0t LS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9ndWl4L2J1aWxkL3N5c2NhbGxzLnNjbSBiL2d1aXgvYnVpbGQvc3lz Y2FsbHMuc2NtCmluZGV4IGE1MGE5YmYuLjBjZGEwOTEgMTAwNjQ0Ci0tLSBhL2d1aXgvYnVpbGQv c3lzY2FsbHMuc2NtCisrKyBiL2d1aXgvYnVpbGQvc3lzY2FsbHMuc2NtCkBAIC01Niw3ICs1Niw3 IEBACiAgICAgICAgICAgICBpbnRlcmZhY2UtYWRkcmVzcy1icm9hZGNhc3QtYWRkcgogICAgICAg ICAgICAgaW50ZXJmYWNlLWFkZHJlc3MtbmV0bWFzay1hZGRyCiAKLSAgICAgICAgICAgIG1ha2Ut aWZhZGRycworICAgICAgICAgICAgcmVtb3ZlLWlmLW5ldG1hc2stbnVsbAogCiAgICAgICAgICAg ICBJRkZfVVAKICAgICAgICAgICAgIElGRl9CUk9BRENBU1QKQEAgLTUzNCwxMSArNTM0LDYgQEAg dW5zaWduZWQtaW50IGlmYS1mbGFncyBmaWVsZCIKICAgICAgICAgICAgKGluZXQtbnRvcCBmYW1p bHkgYWRkcmVzcykKICAgICAgICAgICAgI2YpKSkpCiAKLTs7IE5vdGU6IGFkZHJlc3MgZmllbGRz IGluICdzdHJ1Y3QgZ2V0aWZhZGRycycgYXJlIHBvaW50ZXJzIHRvCi07OyAnc3RydWN0IHNvY2th ZGRyJy4gSW4gJ2ludGVyZmFjZS1hZGRyZXNzLWJyb2FkY2FzdC1hZGRyJyB3ZSBhcmUKLTs7IGlt cGxpY2l0bHkgdHlwZWNhc3RpbmcgdGhpcyAnc29ja2FkZHInIHBvaW50ZXIgdG8gYQotOzsgJ3Nv Y2thZGRyX2luJyBwb2ludGVyLgotCiA7OyBOb3RlOiBnZXRpZmFkZHJzIHJldHVybnMgbXVsdGlw bGUgaW50ZXJmYWNlcyB3aXRoIHRoZSBzYW1lCiA7OyBlLmcuIG9uIG15IHN5c3RlbSBJIHNlZSBt dWx0aXBsZSAiZXRoMCJzLiBUaGUgZGlmZmVyZW5jZSBpcwogOzsgdGhhdCBmb3Igb25lIG9mIHRo ZSBldGgwJ3MsIHRoZSBmYW1pbHkgb2YgdGhlIGFkZHJlc3MKQEAgLTU1Miw2ICs1NDcsMTYgQEAg c29ja2FkZHInIGZyb20gYW4gPGludGVyZmFjZS1hZGRyZXNzPiByZWNvcmQgdHlwZS4iCiAgICAg ICAgICAoYnYgKHBvaW50ZXItPmJ5dGV2ZWN0b3IgYWRkciAlc2l6ZW9mLXN0cnVjdC1zb2NrYWRk cikpKQogICAgIChieXRldmVjdG9yLT5zb2NrYWRkciBidikpKQogCis7OyBOb3RlOiBhZGRyZXNz IGZpZWxkcyBpbiAnc3RydWN0IGdldGlmYWRkcnMnIGFyZSBwb2ludGVycyB0bworOzsgJ3N0cnVj dCBzb2NrYWRkcicuIEluICdleHRyYWN0LWFkZHJlc3MtZmllbGQnIHdlIGFyZQorOzsgaW1wbGlj aXRseSB0eXBlY2FzdGluZyB0aGlzICdzb2NrYWRkcicgcG9pbnRlciB0byBhCis7OyAnc29ja2Fk ZHJfaW4nIHBvaW50ZXIuCisKKzs7IFV0aWxpdHkgbWFjcm8gdG8gcmVtb3ZlIGFsbCBpZmFjZXMg ZnJvbSB0aGUgb3V0cHV0IElGQUNFUyBvZgorOzsgKGdldGlmYWRkcnMpIHRoYXQgaGF2ZSBhIG51 bGwtcG9pbnRlciBpbiB0aGUgJ25ldG1hc2snIGZpZWxkLgorKGRlZmluZS1zeW50YXgtcnVsZSAo cmVtb3ZlLWlmLW5ldG1hc2stbnVsbCBpZmFjZXMpCisgIChyZW1vdmUgKGNvbXBvc2UgbnVsbC1w b2ludGVyPyBpbnRlcmZhY2UtYWRkcmVzcy1uZXRtYXNrKSBpZmFjZXMpKQorCiA7OyBHaXZlbiBh biA8aW50ZXJmYWNlLWFkZHJlc3M+IHJlY29yZCBJRkFDRSwgcmV0dXJuIGl0cwogOzsgYWRkcmVz cyBmaWVsZCBhcyBhIHNvY2thZGRyIGlmIGl0IGV4aXN0cywgb3RoZXJ3aXNlIHJldHVybiAjZi4K IChkZWZpbmUgKGludGVyZmFjZS1hZGRyZXNzLWFkZHJlc3MgaWZhY2UpCmRpZmYgLS1naXQgYS90 ZXN0cy9zeXNjYWxscy5zY20gYi90ZXN0cy9zeXNjYWxscy5zY20KaW5kZXggMzY2NTU3NS4uODdj NThlYSAxMDA2NDQKLS0tIGEvdGVzdHMvc3lzY2FsbHMuc2NtCisrKyBiL3Rlc3RzL3N5c2NhbGxz LnNjbQpAQCAtMjMyLDEwICsyMzIsOSBAQCBGb3IgZXhhbXBsZSwgKDQgMiAyIDIgMiAxIDMgMykg PT4gKDQgMiAxIDMpLiIKICAgICAgICAgICAgICAobGV0KiAoKGlzLWV0aC1pZmFjZT8gKGxhbWJk YSAoaSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLXByZWZp eD8gImV0aCIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGludGVyZmFjZS1hZGRyZXNzLW5hbWUgaSkpKSkKLSAgICAgICAgICAgICAgICAgICAg KGlmYWRkcnMgKGdldGlmYWRkcnMpKQorICAgICAgICAgICAgICAgICAgICAoaWZhZGRycyAocmVt b3ZlLWlmLW5ldG1hc2stbnVsbCAoZ2V0aWZhZGRycykpKQogICAgICAgICAgICAgICAgICAgICAo ZXRoLWlmYWNlcyAoZmlsdGVyIGlzLWV0aC1pZmFjZT8gaWZhZGRycykpCi0gICAgICAgICAgICAg ICAgICAgIChnZXRpZmFkZHJzLXRtcCAobWFwIGludGVyZmFjZS1hZGRyZXNzLWFkZHJlc3MgZXRo LWlmYWNlcykpCi0gICAgICAgICAgICAgICAgICAgIChnZXRpZmFkZHJzLXJlc3VsdCAocmVtb3Zl IG5vdCBnZXRpZmFkZHJzLXRtcCkpCisgICAgICAgICAgICAgICAgICAgIChnZXRpZmFkZHJzLXJl c3VsdCAobWFwIGludGVyZmFjZS1hZGRyZXNzLWFkZHJlc3MgZXRoLWlmYWNlcykpCiAgICAgICAg ICAgICAgICAgICAgIChpZmNvbmZpZy1yZXN1bHQgKGlmY29uZmlnLWV4dHJhY3QtYWRkci1vZiAi ZXRoIiAnYWRkcmVzcykpKQogICAgICAgICAgICAgICAgKG1lbWJlciBpZmNvbmZpZy1yZXN1bHQg Z2V0aWZhZGRycy1yZXN1bHQpKSkKIApAQCAtMjQzLDEwICsyNDIsOSBAQCBGb3IgZXhhbXBsZSwg KDQgMiAyIDIgMiAxIDMgMykgPT4gKDQgMiAxIDMpLiIKICAgICAgICAgICAgICAobGV0KiAoKGlz LWV0aC1pZmFjZT8gKGxhbWJkYSAoaSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc3RyaW5nLXByZWZpeD8gImV0aCIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGludGVyZmFjZS1hZGRyZXNzLW5hbWUgaSkpKSkKLSAg ICAgICAgICAgICAgICAgICAgKGlmYWRkcnMgKGdldGlmYWRkcnMpKQorICAgICAgICAgICAgICAg ICAgICAoaWZhZGRycyAocmVtb3ZlLWlmLW5ldG1hc2stbnVsbCAoZ2V0aWZhZGRycykpKQogICAg ICAgICAgICAgICAgICAgICAoZXRoLWlmYWNlcyAoZmlsdGVyIGlzLWV0aC1pZmFjZT8gaWZhZGRy cykpCi0gICAgICAgICAgICAgICAgICAgIChnZXRpZmFkZHJzLXRtcCAobWFwIGludGVyZmFjZS1h ZGRyZXNzLWJyb2FkY2FzdC1hZGRyIGV0aC1pZmFjZXMpKQotICAgICAgICAgICAgICAgICAgICAo Z2V0aWZhZGRycy1yZXN1bHQgKHJlbW92ZSBub3QgZ2V0aWZhZGRycy10bXApKQorICAgICAgICAg ICAgICAgICAgICAoZ2V0aWZhZGRycy1yZXN1bHQgKG1hcCBpbnRlcmZhY2UtYWRkcmVzcy1icm9h ZGNhc3QtYWRkciBldGgtaWZhY2VzKSkKICAgICAgICAgICAgICAgICAgICAgKGlmY29uZmlnLXJl c3VsdCAoaWZjb25maWctZXh0cmFjdC1hZGRyLW9mICJldGgiICdicm9hZGNhc3QpKSkKICAgICAg ICAgICAgICAgIChtZW1iZXIgaWZjb25maWctcmVzdWx0IGdldGlmYWRkcnMtcmVzdWx0KSkpCiAK QEAgLTI1NCwxNCArMjUyLDkgQEAgRm9yIGV4YW1wbGUsICg0IDIgMiAyIDIgMSAzIDMpID0+ICg0 IDIgMSAzKS4iCiAgICAgICAgICAgICAgKGxldCogKChpcy1ldGgtaWZhY2U/IChsYW1iZGEgKGkp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1wcmVmaXg/ICJl dGgiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChpbnRlcmZhY2UtYWRkcmVzcy1uYW1lIGkpKSkpCi0gICAgICAgICAgICAgICAgICAgIChpZmFk ZHJzIChnZXRpZmFkZHJzKSkKKyAgICAgICAgICAgICAgICAgICAgKGlmYWRkcnMgKHJlbW92ZS1p Zi1uZXRtYXNrLW51bGwgKGdldGlmYWRkcnMpKSkKICAgICAgICAgICAgICAgICAgICAgKGV0aC1p ZmFjZXMgKGZpbHRlciBpcy1ldGgtaWZhY2U/IGlmYWRkcnMpKQotICAgICAgICAgICAgICAgICAg ICAoZ2V0aWZhZGRycy10bXAgKHJlbW92ZSAobGFtYmRhIChpKQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobnVsbC1wb2ludGVyPwotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGludGVyZmFjZS1hZGRyZXNzLW5l dG1hc2sgaSkpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZXRoLWlmYWNlcykpCi0gICAgICAgICAgICAgICAgICAgIChnZXRpZmFkZHJzLXRtcCAobWFwIGlu dGVyZmFjZS1hZGRyZXNzLW5ldG1hc2stYWRkciBnZXRpZmFkZHJzLXRtcCkpCi0gICAgICAgICAg ICAgICAgICAgIChnZXRpZmFkZHJzLXJlc3VsdCAocmVtb3ZlIG5vdCBnZXRpZmFkZHJzLXRtcCkp CisgICAgICAgICAgICAgICAgICAgIChnZXRpZmFkZHJzLXJlc3VsdCAobWFwIGludGVyZmFjZS1h ZGRyZXNzLW5ldG1hc2stYWRkciBldGgtaWZhY2VzKSkKICAgICAgICAgICAgICAgICAgICAgKGlm Y29uZmlnLXJlc3VsdCAoaWZjb25maWctZXh0cmFjdC1hZGRyLW9mICJldGgiICduZXRtYXNrKSkp CiAgICAgICAgICAgICAgICAobWVtYmVyIGlmY29uZmlnLXJlc3VsdCBnZXRpZmFkZHJzLXJlc3Vs dCkpKQogCi0tIAoxLjkuMQoK --001a1147a50e8e7101051afe5c7e--