From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Sprang Subject: Re: [PATCH] download: Fix some minor progress-logging regressions. Date: Thu, 17 Sep 2015 12:44:58 -0700 Message-ID: References: <87bnd0j4dy.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcf76-0003AG-1w for guix-devel@gnu.org; Thu, 17 Sep 2015 15:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcf74-0006IR-SI for guix-devel@gnu.org; Thu, 17 Sep 2015 15:44:59 -0400 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:33954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcf74-0006II-NO for guix-devel@gnu.org; Thu, 17 Sep 2015 15:44:58 -0400 Received: by oiev17 with SMTP id v17so15540966oie.1 for ; Thu, 17 Sep 2015 12:44:58 -0700 (PDT) In-Reply-To: <87bnd0j4dy.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel@gnu.org On Thu, Sep 17, 2015 at 11:18 AM, Mathieu Lirzin wrote: > Steve Sprang writes: > >> From 11440f61cebd49d31d165f6433ec6e4b1afe728f Mon Sep 17 00:00:00 2001 >> From: Steve Sprang >> Date: Thu, 17 Sep 2015 04:22:01 -0700 >> Subject: [PATCH] download: Fix some minor progress-logging regressions. >> >> * guix/build/download.scm >> (string-pad-middle): Allow resulting padded string to overflow. >> (store-url-abbreviation): Remove unnecessary procedure. >> (progress-proc): Default abbreviation should be basename. > > What about something like "(progress-proc): Use BASENAME as default for > parameter 'abbreviation'." ? Ok, sounds good. >> (url-fetch): Insert some newlines for readability. > > I would prefer "Display" instead of "Insert" to not confuse with > insertion of newlines in the source code (even if such change won't be > notified in the commit log) :) Ok. >> --- >> guix/build/download.scm | 20 +++++++++----------- >> 1 file changed, 9 insertions(+), 11 deletions(-) >> >> diff --git a/guix/build/download.scm b/guix/build/download.scm >> index 9b72e8f..e6de4d2 100644 >> --- a/guix/build/download.scm >> +++ b/guix/build/download.scm >> @@ -100,15 +100,13 @@ width of the bar is BAR-WIDTH." >> >> (define (string-pad-middle left right len) >> "Combine LEFT and RIGHT with enough padding in the middle so that the >> -resulting string has length at least LEN. This right justifies RIGHT." > ^^^ > Maybe it's only because of my poor english but I don't understand the > meaning of the last sentence. Yes, the phrasing is awkward. Basically the effect is that the RIGHT string will be flush with the right edge when the string is LEN width (i.e. it is right-justified as in typography). I will try to phrase it better. I have to head out for the moment, but I will send a tweaked patch later today. -Steve > Otherwise this looks good to me. > > -- > Mathieu Lirzin