[bug#73227] Remove phase 'skip-gtk-update-icon-cache from Tilix

[bug#73227] Remove phase 'skip-gtk-update-icon-cache from Tilix

[Ashvith Shetty]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hello,
I should've made this clearer in the previous issue that I've opened. 
There is no to keep the phase 'skip-gtk-update-icon-cache, as the two 
new native-inputs I've added respectively, `(,glib "bin") and `(,gtk+ 
"bin") fixes the issues with meson's post-install Python script.


[-- Attachment #2: Type: text/html, Size: 340 bytes --]

[bug#73227] [PATCH v1] gnu: tilix: Remove phase 'skip-gtk-update-icon-cache.

[Ashvith Shetty]

* gnu/packages/terminals.scm (tilix)[arguments]<#:phases>: Remove
phase 'skip-gtk-update-icon-cache.

Change-Id: I7eb068764f67fd047854e65c9dcdecd45ac18dd3
---
 gnu/packages/terminals.scm | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index eadf58fbf3..30a64acb36 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -1451,17 +1451,11 @@ (define-public tilix
     (arguments
      (list
       #:glib-or-gtk? #t
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-after 'unpack 'set-env-variables
-            (lambda _
-              (setenv "CC"
-                      #$(cc-for-target))))
-          (add-after 'unpack 'skip-gtk-update-icon-cache
-            (lambda _
-              (substitute* "meson_post_install.py"
-                (("gtk-update-icon-cache") (which "true"))
-                (("update-desktop-database") (which "true"))))))))
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'set-env-variables
+                     (lambda _
+                       (setenv "CC"
+                               #$(cc-for-target)))))))
     (inputs (list dbus
                   dconf
                   gettext-minimal
-- 
2.46.0

[bug#73227] Remove phase 'skip-gtk-update-icon-cache from Tilix

[Ashvith Shetty]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Hello,

Just wanted to ping about this patch I had created around September, which
removes the need for having to substitute text unnecessarily. This is
actually a follow-up to the previous patch at
https://issues.guix.gnu.org/73105.

Regards,
Ashvith

[-- Attachment #2: Type: text/html, Size: 337 bytes --]