From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CNGlHI2kYGLqugAAbAwnHQ (envelope-from ) for ; Thu, 21 Apr 2022 02:25:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sAmYHI2kYGLsSgEA9RJhRA (envelope-from ) for ; Thu, 21 Apr 2022 02:25:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A6A842A54 for ; Thu, 21 Apr 2022 02:25:49 +0200 (CEST) Received: from localhost ([::1]:38700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhKdo-00084l-6P for larch@yhetil.org; Wed, 20 Apr 2022 20:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhKd2-0007sH-CA for guix-devel@gnu.org; Wed, 20 Apr 2022 20:25:00 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:35634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhKcy-0006xW-2x for guix-devel@gnu.org; Wed, 20 Apr 2022 20:25:00 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id t67so5890727ybi.2 for ; Wed, 20 Apr 2022 17:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heykimo-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u2OiLajISetDKctq5qPSm+0zkP8ezvfeAfuAyYCXsu0=; b=CCQQSdRygyLMjohR1I21+FyKuxkLk5j69Ou+T1nk519iIkgGF3y4ZFT9w8Rs6Aa1Xj ZYYAB+P/gWefduFqK7+8EU+KKCoPA8QmXzi1ekxoaO7YBXPXtFqU1zYVDKenBWwWt+2Q 4eArX1sMq997R26vUR0bgw3eMoVGtYOzH6ljHn+bhJNpnipE+yOiY0KnDYjs1vml4E5W VIrbK3J/9XZVhqlhwbgOVFU/rq00ZpqkACQIIKJRV3iDBSTv2/Y14NcC1KBXXI58+lI3 faxc6PElQTEjTFOETcsBCvhioKKXu8gKRl9MRDLiZN5MmZpSwdRW4/klcdLbSWFThrc2 oOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u2OiLajISetDKctq5qPSm+0zkP8ezvfeAfuAyYCXsu0=; b=4SmOVCz/lVMd04bJh2xcfc4dfkLLpCLV3UECP+p7MZ6QBGCFW7ChEPCNCKCTf/hh4l DVWqNyokqIB8piTfUNcKK87k2Wb2hlCuYjnoj1FS6/YdcMd9ED2+c3hSoCcdoRogDT+7 VmBns8iAEaposoqXc+GPMyCTpVw8d0JHuP+4Tb5UFMxIsc75q/9+H+VbT6CxFvCBfAy2 CuFu+o8UnlsY8lSGm+TAKLDAd+Ag0QdzesTjWcfh3KZ2d9ce7Fnwd6Wg37FI+aQWLq8A PvI6ZwNWKbutSOoRovAzwinCSQyodScz0jxopJAcDyE0mNKvOGQqvhgxrjlHGWW3lljS ZeEw== X-Gm-Message-State: AOAM530cWNyD6aCrHiB36LbMYbDx/e2wbFCf2l5bmATuAe3xesAxqoI4 b8pPHRNhkj1+APtGOFzfrZsMEn0dPMaG4N7uakZutwHJxAV5SNUx X-Google-Smtp-Source: ABdhPJy4tD85dV0tzrqyOS/8Bdy9RU+3MMk82Pvz55DDNzh0ANLF0/s0GNNi6Ltqpa4cN8Q7iyFvKp8k3RGoeyuyLGg= X-Received: by 2002:a05:6902:4af:b0:63d:a53f:8871 with SMTP id r15-20020a05690204af00b0063da53f8871mr22430511ybs.452.1650500695000; Wed, 20 Apr 2022 17:24:55 -0700 (PDT) MIME-Version: 1.0 References: <87k0bw4qh8.fsf@gnu.org> <87o80vtjid.fsf@gmail.com> In-Reply-To: From: Pier-Hugues Pellerin Date: Wed, 20 Apr 2022 20:24:44 -0400 Message-ID: Subject: Re: Updating from Go 1.17 to 1.18 To: Katherine Cox-Buday Content-Type: multipart/alternative; boundary="000000000000a09ede05dd1f230f" Received-SPF: none client-ip=2607:f8b0:4864:20::b2a; envelope-from=ph@heykimo.com; helo=mail-yb1-xb2a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650500749; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=u2OiLajISetDKctq5qPSm+0zkP8ezvfeAfuAyYCXsu0=; b=B7a4x5NPHaD+azxRKRUeh4TFu5PRh4eXZpkG9bf/TqywgsCM/yZq0XsAgr86G2HHUNrX60 9fQF2+X6n639kYNr7H0VSdJA3ZLO0zkyt2V35FvMUVupENC2OiMGuNx59ssA+RlIJuycba ir1sTrip+4y7hVbJc+sMKCMXymOWC2F2FQ5lMiy5dsYuq3BZdDs0qa0Q2x1vwph47r6nmV H1xnZZZY7yVCtKm8zuFQ8HDFVX3n7eKxuLzNftgP7y72zLARqa4aQRWGUSlFndiaFuLP/V wWPybDdbucvKdZ+OHJLs2THUh9cEe1LPZ0Abocad6c+Qqc4medzlctneNIZikg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650500749; a=rsa-sha256; cv=none; b=TX8lKSHEoSiBKwwoHq/CimD5i23tvHeEWfAV2Tvf8+ASSZ85H8NVoLvO0laOwO+Eemoplk 7vvgorffwfUmLHu/S+3u+LSTuWOJcHDA0VyNEswLnxs6hmBDo/qmlNeofcgac+Jop7FySE LCmDKhfymndPuhjAek+63hWyzwBQJBI62IHzlD5ypyrAy/hHc+hrj96ZK/A0c2sSrvsJlI JrVWyoQky0rVrxOk/x8j7G40obbnEs0b7W67h4iZpLfktwmjz3vPRurIjYuThLHJUDnt4P Yogg7+ee3kPqa5p7oVjlO0E/ZBMo2pbzoGOWWySsgQjrJl6gDYQaI75yM2b/NA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=heykimo-com.20210112.gappssmtp.com header.s=20210112 header.b=CCQQSdRy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=heykimo-com.20210112.gappssmtp.com header.s=20210112 header.b=CCQQSdRy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0A6A842A54 X-Spam-Score: 1.16 X-Migadu-Scanner: scn1.migadu.com X-TUID: nT1yAZm40b0a --000000000000a09ede05dd1f230f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I've looked a bit more in detail on the Go package definition, Maybe we should rethink how we are building the Go package in guix? If I understand correctly, the current bootstrap chain is the following. 1.17 -> 1.16-> 1.4 which is the last gcc version of go. Looking at the current proposal in Go https://mail.google.com/mail/u/0/#inbox/KtbxLthKLdQNrjXvKllfQHQBQcKqVFdmPg I don't think we will be able to remove 1.17 soon and also 1.4. Because they want to move to use 1.17 as the minimum version in the next minor. We should probably also try to mimic how their bootstrap and have the following: - Bootstrap 1.17 with 1.4 - Bootstrap 1.18 with 1.4 - Have 1.19 bootstrap with 1.17. So maybe we should do something like this. - Add go-1.18 build from 1.4. - Add go-next that point to go-1.18 - Refactor 1.17 package definition that is shared between go-1.18. and go-1.17. - Move go to go-1.18 in another branch - Remove 1.16? WDYT? I am not super familiar with the scheme but this seems like a good exercise. Thanks On Wed, Apr 20, 2022 at 7:43 PM Pier-Hugues Pellerin wrote= : > That sound great and great timing I was working on that as you send the > mail > > I think also go-next is a good idea, I will split them in the following > commits: > > 1. Add go-1.17 inherits from 1.18 (actually reversing the patch in the > previous email) > 2. Add go-next pointing to 1.18. > 3. Make go point to 1.18. > > This will allow merging things right away to add support for go 1.18 and > also allow Ludovic to create the branch and rebuild. > > Thanks > > On Wed, Apr 20, 2022 at 7:36 PM Katherine Cox-Buday < > cox.katherine.e@gmail.com> wrote: > >> >>> Pier-Hugues Pellerin writes: >> >> Ludovic Court=C3=A8s writes: >> >> >>> I am trying to update Go to 1.18, I do have a *working* patch that >> defines >> >>> a package that inherits from 1.17 and that adjusts the inputs. >> >> >> >> Nice! >> >> Yes, thank you! I just found out I need this and came to see if anyone h= ad >> started on it. >> >> >> You can define Go 1.18 inheriting from 1.17; that=E2=80=99ll allow us= to have >> both >> >> versions, and eventually we=E2=80=99ll remove the older one. >> >> I suggest inverting this: copy/paste go-1.17 to go-1.18, and then make >> go-1.17 >> inherit from go-1.18. This means that when it's time to sunset a version= , >> it's >> a simple delete and not something that cascades through all recent >> versions. >> >> > I think it makes sense, looking at the number of impacted packages and >> from >> > my experience working in go, even if the contract is the same, >> sometimes it >> > does break on minor. >> >> I was wondering if we don't want to start publishing a go-next package >> like we do with emacs-next? That would allow us to publish the latest >> version of Go without needing to immediately address building all the >> packages that depend on it. >> >> Kindest regards, >> -- >> Katherine >> > > > -- > ph, > http://heykimo.com > --=20 ph, http://heykimo.com --000000000000a09ede05dd1f230f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I've looked a bit= more in detail on the Go package definition, Maybe we should rethink how w= e are building the Go package in guix?
If I understand correctly,= the current bootstrap chain is the following.

1.1= 7 -> 1.16-> 1.4 which is the last gcc version of go.
I don't think we will be able to remove 1.17 soon and also 1.4.=C2=A0= Because they want to move to use 1.17 as the minimum
=C2=A0versi= on in the next minor.

We should probably also = try to mimic how their bootstrap and have the following:
  • Boots= trap 1.17 with 1.4
  • Bootstrap 1.18 with 1.4
  • Have 1.19 bootst= rap with 1.17.
So maybe we should do something like this.

- Add go-1.18 build from 1.4.
- Add go-next= that point to go-1.18
- Refactor 1.17 package definition that is= shared between go-1.18. and go-1.17.
- Move=C2=A0 go to go-1.18= =C2=A0 in another branch
- Remove 1.16?

<= div>WDYT? I am not super familiar with the scheme but this seems like a goo= d exercise.

Thanks


On = Wed, Apr 20, 2022 at 7:43 PM Pier-Hugues Pellerin <ph@heykimo.com> wrote:
That sound great and great= timing I was working on that as you send the mail

=
I think also go-next is a good idea, I will split them in the fol= lowing commits:

1. Add go-1.17 inherits from 1.18 = (actually reversing the patch in the previous email)
2. Add g= o-next pointing to 1.18.
3. Make go point to 1.18.

=
This will allow merging things right away to add support for go = 1.18 and also allow Ludovic to create the branch and rebuild.
Thanks

On Wed, Apr 20, 2022 at 7:36 PM Katherine= Cox-Buday <cox.katherine.e@gmail.com> wrote:
>>> Pier-Hugues Pellerin <ph@heykimo.com> writes:=
>> Ludovic Court=C3=A8s writes:

>>> I am trying to update Go to 1.18, I do have a *working* patch = that defines
>>> a package that inherits from 1.17 and that adjusts the inputs.=
>>
>> Nice!

Yes, thank you! I just found out I need this and came to see if anyone had<= br> started on it.

>> You can define Go 1.18 inheriting from 1.17; that=E2=80=99ll allow= us to have both
>> versions, and eventually we=E2=80=99ll remove the older one.

I suggest inverting this: copy/paste go-1.17 to go-1.18, and then make go-1= .17
inherit from go-1.18. This means that when it's time to sunset a versio= n, it's
a simple delete and not something that cascades through all recent versions= .

> I think it makes sense, looking at the number of impacted packages and= from
> my experience working in go, even if the contract is the same, sometim= es it
> does break on minor.

I was wondering if we don't want to start publishing a go-next package = like we do with emacs-next? That would allow us to publish the latest versi= on of Go without needing to immediately address building all the packages t= hat depend on it.

Kindest regards,
--
Katherine


--


--
--000000000000a09ede05dd1f230f--