From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKbbz-0007OY-Dq for guix-patches@gnu.org; Wed, 07 Nov 2018 23:08:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKbbw-0001AJ-5n for guix-patches@gnu.org; Wed, 07 Nov 2018 23:08:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35921) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKbbw-0001A7-0I for guix-patches@gnu.org; Wed, 07 Nov 2018 23:08:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKbbv-0001rZ-Ju for guix-patches@gnu.org; Wed, 07 Nov 2018 23:08:03 -0500 Subject: [bug#33217] Modifying the commit message to gnu-Add-r-weights Resent-Message-ID: MIME-Version: 1.0 References: In-Reply-To: From: Lakshmi Prasannakumar Date: Thu, 8 Nov 2018 09:37:24 +0530 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000b6e28057a1f6076" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 33217@debbugs.gnu.org --0000000000000b6e28057a1f6076 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi G=C3=A1bor, I am extremely sorry that , I did miss out this mail. I would like to know , if there is anything more that I need to do on r-weights package addition. If not could you tell me how you fixed this to do the final commit ? Thanks, On Tue 6 Nov, 2018, 3:50 AM G=C3=A1bor Boskovits Hello Lakshmi, > > It would be nice if you could give this another shot, if not I will > commit it tomorrow with > some minor changes. > > The commit message seems to be missing the second line (what has changed)= . > > The license field still misses the prefix. See the mail from Bj=C3=B6rn e= arlier. > > Could you squash your changes to a single commit? > > (You can either do this on a throw-away branch with a git merge --squash, > or > you can use git rebase -i, see this for more info > > https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriti= ng-history > .) > > Best regards, > g_bor > --0000000000000b6e28057a1f6076 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0G=C3=A1bor,

I am extremely sorry that , I did miss out t= his mail. I would like to know , if there is anything more that I need to d= o on r-weights package addition.=C2=A0
If = not could you tell me how you fixed this to do the final commit ?=C2=A0

Thanks,= =C2=A0

On= Tue 6 Nov, 2018, 3:50 AM G=C3=A1bor Boskovits <boskovits@gmail.com= wrote:
Hello Lakshmi,

It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.

The commit message seems to be missing the second line (what has changed).<= br>
The license field still misses the prefix. See the mail from Bj=C3=B6rn ear= lier.

Could you squash your changes to a single commit?

(You can either do this on a throw-away branch with a git merge --squash, o= r
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewr= iting-history.)

Best regards,
g_bor
--0000000000000b6e28057a1f6076--