From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lakshmi Prasannakumar Subject: Re: Video Documentation for GNU GUIX (an Outreachy project) Date: Wed, 31 Oct 2018 10:15:03 +0530 Message-ID: References: <20181017084521.29579a72@alma-ubu> <20181018134637.25c82e09@alma-ubu> <20181029205741.24759fd6@alma-ubu> <20181029212738.75de1734@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000004fb0105797ef8af" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHiNb-0005AS-Vh for guix-devel@gnu.org; Wed, 31 Oct 2018 00:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHiNa-0005QG-Kc for guix-devel@gnu.org; Wed, 31 Oct 2018 00:45:19 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:40485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHiNa-0005Pr-AN for guix-devel@gnu.org; Wed, 31 Oct 2018 00:45:18 -0400 Received: by mail-oi1-x233.google.com with SMTP id u130-v6so7784778oie.7 for ; Tue, 30 Oct 2018 21:45:18 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Cc: guix-devel@gnu.org --00000000000004fb0105797ef8af Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Bj=C3=B6rn and G=C3=A1bor, I've sent the patch file to the patch tracker. Now I understand next this is to send you the timeline proposal for the internship period , is it so? The patch submission took me a little while since my system needed an update due to ubuntu version becoming obsolete. Thanks, Lakshmi Prasannakumar Bangalore On Tue, Oct 30, 2018 at 11:50 PM Lakshmi Prasannakumar < lakshmiprasannakumaran@gmail.com> wrote: > Thanks G=C3=A1bor, > I'll make these changes and make a patch file and try to send across. > > Lakshmi Prasannakumar > Bangalore > > > On Tue, Oct 30, 2018 at 2:28 AM G=C3=A1bor Boskovits > wrote: > >> Hello Lakshmi, >> >> I did a preliminary review, that can make this contribution faster. >> Here are my comments: >> >> (package >> (name "r-weights") >> (version "1.0") >> (source >> (origin >> (method url-fetch) >> (uri (cran-uri "weights" version)) >> (sha256 >> (base32 >> "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c")))) >> (build-system r-build-system) >> (propagated-inputs >> `(("r-gdata" ,r-gdata) >> ("r-hmisc" ,r-hmisc) >> ("r-mice" ,r-mice))) >> (home-page >> "http://cran.r-project.org/web/packages/weights") >> (synopsis "Weighting and Weighted Statistics") >> >> Please use lower case for all words except the first. >> The importer cannot find out which letters should be lower case, >> this has to be done manually. >> >> (description >> "Provides a variety of functions for producing simple weighted >> statistics, such as weighted Pearson's correlations, partial >> correlations, Chi-Squared statistics, histograms, and t-tests. Also >> now includes some software for quickly recoding survey data and >> plotting point estimates from interaction terms in regressions (and >> multiply imputed regressions). NOTE: Weighted partial correlation >> calculations pulled to address a bug.") >> >> Please, try to repharse this so that it has whole sentences, for >> example like "This package provides...". >> >> (license gpl2+)) >> >> With these small modifications this looks good to me. >> > --00000000000004fb0105797ef8af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bj=C3=B6rn and G=C3=A1bor,

I've sent the patch file to t= he patch tracker.
Now I understand next this is to send you the timeline= proposal for the internship period , is it so?
The patch = submission took me a little=C2=A0while since my system needed an update due= to ubuntu version becoming obsolete.

Thanks,
Lakshmi Prasannakumar
Bangalore


On Tue, Oct 30, 2018 at 11:50 PM = Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
Thanks G=C3=A1bor,
=
I'll make thes= e changes and make a patch file and try to send across.

Lakshmi Prasan= nakumar
Bangalore
<= br>

On Tue, Oct = 30, 2018 at 2:28 AM G=C3=A1bor Boskovits <boskovits@gmail.com> wrote:
Hello Lakshmi,

I did a preliminary review, that can make this contribution faster.
Here are my comments:

(package
=C2=A0 (name "r-weights")
=C2=A0 (version "1.0")
=C2=A0 (source
=C2=A0 =C2=A0 (origin
=C2=A0 =C2=A0 =C2=A0 (method url-fetch)
=C2=A0 =C2=A0 =C2=A0 (uri (cran-uri "weights" version))
=C2=A0 =C2=A0 =C2=A0 (sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "0186bfpkhxngrshac6bpg37alp6slwhwd4= 3inrm8hqg0vhpfgc4c"))))
=C2=A0 (build-system r-build-system)
=C2=A0 (propagated-inputs
=C2=A0 =C2=A0 `(("r-gdata" ,r-gdata)
=C2=A0 =C2=A0 =C2=A0 ("r-hmisc" ,r-hmisc)
=C2=A0 =C2=A0 =C2=A0 ("r-mice" ,r-mice)))
=C2=A0 (home-page
=C2=A0 =C2=A0 "http://cran.r-project.org/web/pack= ages/weights")
=C2=A0 (synopsis "Weighting and Weighted Statistics")

Please use lower case for all words except the first.
The importer cannot find out which letters should be lower case,
this has to be done manually.

=C2=A0 (description
=C2=A0 =C2=A0 "Provides a variety of functions for producing simple we= ighted
statistics, such as weighted Pearson's correlations, partial
correlations, Chi-Squared statistics, histograms, and t-tests.=C2=A0 Also now includes some software for quickly recoding survey data and
plotting point estimates from interaction terms in regressions (and
multiply imputed regressions).=C2=A0 NOTE: Weighted partial correlation
calculations pulled to address a bug.")

Please, try to repharse this so that it has whole sentences, for
example like "This package provides...".

=C2=A0 (license gpl2+))

With these small modifications this looks good to me.
--00000000000004fb0105797ef8af--