From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffQmq-0007SM-Qp for guix-patches@gnu.org; Tue, 17 Jul 2018 10:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffQml-0003xH-P8 for guix-patches@gnu.org; Tue, 17 Jul 2018 10:17:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffQml-0003x7-Im for guix-patches@gnu.org; Tue, 17 Jul 2018 10:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffQmj-0005tN-Ol for guix-patches@gnu.org; Tue, 17 Jul 2018 10:17:03 -0400 Subject: [bug#32137] closed (Re: [bug#32137] [PATCH] gnu: Add luakit) Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <87in5e80n4.fsf@gnu.org> From: =?UTF-8?Q?Rapha=C3=ABl_?= =?UTF-8?Q?M=C3=A9lotte?= Date: Tue, 17 Jul 2018 16:15:44 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c576350571329612" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 32137@debbugs.gnu.org --000000000000c576350571329612 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > From: "Ludovic Court=C3=A8s" > > Thanks for this first patch and welcome! I made only minor > modifications (patch below): > > 1. Add =E2=80=98file-name=E2=80=99 to the source to please =E2=80=98gui= x lint=E2=80=99. > I spotted the issue reported by 'guix lint', but I didn't know how to fix it. Now I do :-) > > 2. Return #t at the end of the =E2=80=98wrap=E2=80=99 phase. I took inspiration from Icecat's definition but it looks like I missed this. Why is it necessary to return #t ? > 4. Change license to =E2=80=98gpl3+=E2=80=99 because source file header= s explicitly > say =E2=80=9Cversion 3 or any later version=E2=80=9D. > I was tricked by the website that says it's GPLv3 but you're right, the source files says GPLv3+. I tried running =E2=80=9Cluakit -c /dev/null=E2=80=9D but it insists on hav= ing an rc > file that explicitly creates a window, right? > I've never used custom configuration files, but once installed, running only `luakit` should load the default files from '~/.guix-profile/etc/xdg/luakit' and open luakit's homepage. Does it fail if you only run `luakit` ? Thanks! --000000000000c576350571329612 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

=
From:=C2=A0"Ludovic Court=C3=A8s" = <ludo@gnu.org>

Thanks for this first patch and welcome!=C2=A0 I made only minor
modifications (patch below):

=C2=A0 1. Add =E2=80=98file-name=E2=80=99 to the source to please =E2=80=98= guix lint=E2=80=99.

I spotted the issue= reported by 'guix lint', but I didn't know how to fix it. Now = I do :-)
=C2=A0

=C2=A0 2. Return #t at the end of the =E2=80=98wrap=E2=80=99 phase.=C2=A0

I took inspiration from Icecat's definit= ion but it looks like I missed this. Why is it necessary to return #t ?=C2= =A0
=C2=A0
=C2=A0 4. Change license to =E2=80=98gpl3+=E2=80=99 because source file hea= ders explicitly
=C2=A0 =C2=A0 =C2=A0say =E2=80=9Cversion 3 or any later version=E2=80=9D.
=C2=A0
I was tricked by the website that says= it's GPLv3 but you're right, the source files says GPLv3+.


I tried running =E2=80=9Cluakit -c /dev/null=E2=80=9D but it insists on hav= ing an rc
file that explicitly creates a window, right?

I've never used custom configuration files, but once installed, = running only `luakit` should
load the default files from '~/.guix-p= rofile/etc/xdg/luakit' and open luakit's homepage.
Do= es it fail if you only run `luakit` ?


Thanks!

--000000000000c576350571329612--