From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6Fi5BQcze2ZnAgEAe85BDQ:P1 (envelope-from ) for ; Tue, 25 Jun 2024 21:13:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6Fi5BQcze2ZnAgEAe85BDQ (envelope-from ) for ; Tue, 25 Jun 2024 23:13:43 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b=CMGKEG6H; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719350022; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qV2PU+zW+401Ia9BfAuQ4XhYxaWYs4WyBkXc31Gwvow=; b=J44sQmQWiNL2SEyVSZTj8lNl8WDz9c7B3829Nsffum0TbEq5paZfMvfKHEyiujBtCfvPNE M+pxoSC/vbH9R9eKyRUHmEUjRSejfnkoxk5XCHkmTvHtP2+G7TbjsGvUerc4Xx5dG3+AOE /oyOQrffy8+3ZafMHs8bHIL4AoWUNrwQNdleMgf8P4VrD33m+7w7PjkbwyIgjB7C9wffiN QbOGIA12a/smdEAwSySjRIOkXNURez6I578+KbrZWYkryOZqcYYO/9vN2h3vKOh6m05OTG F1pVYDzP0kihgrP20q7G+O8rUeKjJK0R7GBa06zfq+zJ1pqL+X0ugAOPgTjCXg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719350022; a=rsa-sha256; cv=none; b=RqGIcVSMZnT/5GnGUn76heZFIttukoLjsV6otEmF2eaG13R7vktRlfR8rPtsB/ktIzAGUc PUkR9P/ImLf7lA/ZBVwToZHh5VnFWZzr91CDREWdw4wMCligYZgzFcyvwcVqSDwn0/WlDN yOP1ssZaNsSx26IvyUx8oxEC9Yl/45nHqPqlxqLUAwBKATsb/QDK4UHArzYqFWNc6k6cci qEhjZ84oDlPQGRcgCY/XmOQ7+vKS2in2KVIsRYWErBr5rn2wnOGjkON1JHq/dS5tgT8t52 69D+heQhxdWVASzDDc5ojwYzBkerjVmUt0yYvFlzKrZc7RBM7Wx9NUqIyo0sGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b=CMGKEG6H; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1AA434FF6 for ; Tue, 25 Jun 2024 23:13:42 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMBpw-0005Rc-HX; Tue, 25 Jun 2024 15:28:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMBm5-0004WK-KA for guix-patches@gnu.org; Tue, 25 Jun 2024 15:24:31 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMBlZ-0003D3-8v for guix-patches@gnu.org; Tue, 25 Jun 2024 15:23:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sM9lx-0001PF-OY for guix-patches@gnu.org; Tue, 25 Jun 2024 13:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers. Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jun 2024 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71697 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , 71697@debbugs.gnu.org, Christopher Baines , Matthew Trzcinski Received: via spool by 71697-submit@debbugs.gnu.org id=B71697.17193357585395 (code B ref 71697); Tue, 25 Jun 2024 17:16:01 +0000 Received: (at 71697) by debbugs.gnu.org; 25 Jun 2024 17:15:58 +0000 Received: from localhost ([127.0.0.1]:37631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sM9lq-0001Ov-QT for submit@debbugs.gnu.org; Tue, 25 Jun 2024 13:15:57 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:49316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sM9lh-0001OR-Aq for 71697@debbugs.gnu.org; Tue, 25 Jun 2024 13:15:52 -0400 Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6f97a4c4588so3334099a34.2 for <71697@debbugs.gnu.org>; Tue, 25 Jun 2024 10:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1719335670; x=1719940470; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qV2PU+zW+401Ia9BfAuQ4XhYxaWYs4WyBkXc31Gwvow=; b=CMGKEG6H2jqsVTcwGYiTNOqdC39veS+pOahfhTR9ITf8IDgv/Di9w2luGt/WcOvahi Iq89abvMM146Zar9MUhr7AOxeufwo37mNQLdWNxUyY6himwZSvY2Cb4bMRbfPY1Wz8Hj tHK1nHZoCMHQtcaVCb68fiAnC3GM0sG/IsQSYnOCh6jLhT7Gf0RNtFAzp3jCpUBmCaKI lVSR7UroSh6e2CWqqlYVZ60K6znK5y5EIGem5qI24bHpDsJ+vcwmcOlQtfwDzmVsX+/G axAFdGSWMrCUFKvDbgBwGP5VbDZtdHbQNUMRoUbnu6enaswFlz1lPkjAZggs1BEvzm3c OcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719335671; x=1719940471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qV2PU+zW+401Ia9BfAuQ4XhYxaWYs4WyBkXc31Gwvow=; b=m5afoljvRU4AOOgrySye32EyjgCiKH5yBIj3KCCZcnpgY2t0bECs5Zrpn15bGacSsS z6Lr+OH4HsQKznzz41m6KbSag/0YX488rHZdIBIVVQX8V5rljLnX6+RFhuJSUI5K8lBW UXiCLkumj/hn3tJNTnkL2GuOITWfrz6V8FqIqGnOUF2G9sA82gP9iGFdPj8ZRBhXQdIx BTRtUWNzvzAC7MB0dZ/jPGigyyBoud/bFudXdmjSf95PW5+tPZYbWk4ccstQmEBgZoZ8 PVRsd0zuMbNLE6qBCMRHiHIH7xcQVyObWQwmA9eqwGBieK9AxYW5MFKwJbH932npC1D8 pUxQ== X-Forwarded-Encrypted: i=1; AJvYcCWXwwQMoM7nwD5lxOifZZrSw07AsxziwHlQlDSUFR1z0fi+JTC5U2xGUnTjcL50k+WOwrMSJzPJ5K1p3D1HSVgbh+9Znu0= X-Gm-Message-State: AOJu0Yx0sMD8H8Tw6zpaeeUyi8Mr9cKRnit5k81IjHcwH/05584q/6y7 sBixPrcDRDTMqGK4ESj96z6A8LA4QgA6hQV0Xd3f/yU2JHZgw1T5/8ff9epry8e3pDzMsTbmOaD MtIjDgA9zIL1ergUGEfaIAgrVKuntZNWx/znFTg== X-Google-Smtp-Source: AGHT+IGnL8LjZrLwp0lhyUuAN0mymq0hLI/99wfwLpmNZ7GqLK25mxzypAHFAXOBMZ2SjxTJNaEGWUbje6vzH5tP0Hk= X-Received: by 2002:a05:6830:18ee:b0:6f9:916e:517f with SMTP id 46e09a7af769-700afa09a0amr9683570a34.28.1719335670609; Tue, 25 Jun 2024 10:14:30 -0700 (PDT) MIME-Version: 1.0 References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@gmail.com> <871q4ldpgv.fsf@gnu.org> In-Reply-To: <871q4ldpgv.fsf@gnu.org> Date: Tue, 25 Jun 2024 13:14:18 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Greg Hogan via Guix-patches Reply-To: Greg Hogan Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D1AA434FF6 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.57 X-Spam-Score: -5.57 X-TUID: +wFZSESuiGOV On Tue, Jun 25, 2024 at 11:15=E2=80=AFAM Ludovic Court=C3=A8s wrote: > > Hi, > > Simon Tournier skribis: > > > +@lisp > > +(package > > + (name "python-scikit-learn") > > + ;; @dots{} > > + (properties '((lint-exclude-archival? . #t) > > + (lint-exclude-home-page? . #t)))) > > To complement Maxim=E2=80=99s review, how about: > > (properties '((lint-excluded-checkers . (archival home-page)))) > > ? > > Apart from that, the idea sounds reasonable to me. > > Thanks, > Ludo=E2=80=99. Could we not instead create a GUIX_LINT_OPTIONS, similar to GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain checkers (or disable network checks) on their own system would be free to do so. I find the current implementation confusing since I don't believe the project would accept a new or modified package missing the home page or with archiving disabled. Stated another way, to which Guix packages are we adding lint exclusions? Greg