From: Greg Hogan via Guix-patches <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Florian Pelz <pelzflorian@pelzflorian.de>,
Ricardo Wurmus <rekado@elephly.net>,
71697@debbugs.gnu.org, Christopher Baines <guix@cbaines.net>,
Matthew Trzcinski <matt@excalamus.com>
Subject: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers.
Date: Tue, 25 Jun 2024 13:14:18 -0400 [thread overview]
Message-ID: <CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@mail.gmail.com> (raw)
In-Reply-To: <871q4ldpgv.fsf@gnu.org>
On Tue, Jun 25, 2024 at 11:15 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hi,
>
> Simon Tournier <zimon.toutoune@gmail.com> skribis:
>
> > +@lisp
> > +(package
> > + (name "python-scikit-learn")
> > + ;; @dots{}
> > + (properties '((lint-exclude-archival? . #t)
> > + (lint-exclude-home-page? . #t))))
>
> To complement Maxim’s review, how about:
>
> (properties '((lint-excluded-checkers . (archival home-page))))
>
> ?
>
> Apart from that, the idea sounds reasonable to me.
>
> Thanks,
> Ludo’.
Could we not instead create a GUIX_LINT_OPTIONS, similar to
GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain
checkers (or disable network checks) on their own system would be free
to do so.
I find the current implementation confusing since I don't believe the
project would accept a new or modified package missing the home page
or with archiving disabled. Stated another way, to which Guix packages
are we adding lint exclusions?
Greg
next prev parent reply other threads:[~2024-06-25 21:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 17:22 [bug#71697] [PATCH] guix: lint: Honor 'no-archival?' package property Simon Tournier
2024-06-21 18:33 ` [bug#71697] [PATCH v2] guix: scripts: lint: Honor package property to exclude chercker Simon Tournier
2024-06-21 21:09 ` Liliana Marie Prikler
2024-06-22 14:29 ` MSavoritias
2024-06-22 15:40 ` Simon Tournier
2024-06-24 8:21 ` MSavoritias
2024-06-22 15:27 ` [bug#71697] [PATCH v3 1/2] scripts: lint: Add 'dry-run' option Simon Tournier
2024-06-22 15:27 ` [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers Simon Tournier
2024-06-23 23:51 ` Maxim Cournoyer
2024-06-25 15:14 ` Ludovic Courtès
2024-06-25 17:14 ` Greg Hogan via Guix-patches [this message]
2024-06-26 8:24 ` Ricardo Wurmus
2024-06-26 19:28 ` Maxim Cournoyer
2024-06-27 16:38 ` Greg Hogan
2024-06-29 3:12 ` Maxim Cournoyer
2024-06-30 14:48 ` Dale Mellor
2024-07-01 20:44 ` Maxim Cournoyer
[not found] ` <72a5f3c9d0523b29ed99afd5a551b411f4c0e7f5.camel@rdmp.org>
2024-07-02 1:39 ` Maxim Cournoyer
2024-06-23 23:54 ` [bug#71697] [PATCH v3 1/2] scripts: lint: Add 'dry-run' option Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+3U0Znt_Ah_P=D5A8P1bZ8CNXjof=mOZ8soO7X7p1GmJYvKHw@mail.gmail.com' \
--to=guix-patches@gnu.org \
--cc=71697@debbugs.gnu.org \
--cc=code@greghogan.com \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=matt@excalamus.com \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=pelzflorian@pelzflorian.de \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.