From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CDBGGH1qXWKJ+gAAbAwnHQ (envelope-from ) for ; Mon, 18 Apr 2022 15:41:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +H9HGH1qXWKp8gAA9RJhRA (envelope-from ) for ; Mon, 18 Apr 2022 15:41:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C439D2B4F2 for ; Mon, 18 Apr 2022 15:41:16 +0200 (CEST) Received: from localhost ([::1]:58464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngRcx-0004WE-VM for larch@yhetil.org; Mon, 18 Apr 2022 09:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngRck-0004Rg-OX for guix-patches@gnu.org; Mon, 18 Apr 2022 09:41:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngRck-00064c-GA for guix-patches@gnu.org; Mon, 18 Apr 2022 09:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngRck-0007Fa-DI for guix-patches@gnu.org; Mon, 18 Apr 2022 09:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54974] [PATCH] added btop Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Apr 2022 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54974 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wil deBeest Cc: 54974@debbugs.gnu.org Received: via spool by 54974-submit@debbugs.gnu.org id=B54974.165028924727842 (code B ref 54974); Mon, 18 Apr 2022 13:41:02 +0000 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 13:40:47 +0000 Received: from localhost ([127.0.0.1]:38490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngRcU-0007F0-OB for submit@debbugs.gnu.org; Mon, 18 Apr 2022 09:40:47 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:38436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngRcR-0007El-5J for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 09:40:45 -0400 Received: by mail-pj1-f53.google.com with SMTP id s14-20020a17090a880e00b001caaf6d3dd1so17292056pjn.3 for <54974@debbugs.gnu.org>; Mon, 18 Apr 2022 06:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MrwVm2SXLEBHbgYBDElNVem8T8NiCFF5xt8gILIu8M8=; b=SH735xZ4cjEeUnNuP9BU5jPrYwPdiEGXve2ypFvWEOjZnwCTSAOIH0XZL5gfsohi3O wBftxZOTPa3wupspOKxAtRafsFRsu1rSQidsRJZVvZFrwyfKKgC/XDdkTqIzpiNUpu+6 4QwtFpCmNVWK7uuIdyGA1wGTowlaL71/QpirTmnj62WhySzQ0JuyGJuxFOaxvlVGpb7l GKkqaNwb5nmcOt419D7fPUEZ6nhETb/6Xbxbs7FLhjXOEM//yjrRnOBkp1kAqR2X1GsR an76Bvem+mh+wdhnX/qrpI5t9ryvgUWDu/018pzZgtbA/1k9xvG5/krYTFDtWVsuWkWu dTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MrwVm2SXLEBHbgYBDElNVem8T8NiCFF5xt8gILIu8M8=; b=d3zOw0ExpFi4D9xRJ5BsGiK3/Xw5jGzVJAEc40kZJd9SRLRFFArwopTXMfTmrP/jgp GcBIdLX6AFE5JN1lJfLV1NbigBR+TAPye7X8DUL34vcZ/BRRtYG8oY+tAKvbDV6WCxRW QzzCqMnRelor5yA0BQ6piSwY0/FI+zHkMZdxFkG8azoq+YUnkxeE2ZlZAvz01/I1olgz jr0yeOK+CiT1nyebo6pxxcU7vnghjZPf9JAHMEvAbdjR1jrZYlEb+u2dljNcqSmQLO21 EH1iFKNPuZjML0USSFecqI6kZia52X0JYsD/KqyS59mLExAdgPdQsWV/qXWoJk09OBrv 2QMg== X-Gm-Message-State: AOAM531X/YYKDCHEzX7UufpG0/zg4PhCQHZT7mM7xVtffbHl2sKOVGk6 H+bKJyEntbRHxt/5VmFCkQfmxlFW2rzgOVYBdBShcq00Sp7hkTTg X-Google-Smtp-Source: ABdhPJwk+iKWDyHC9d8naY+nFMDJqRbr0m2UR5gbVhwovo1G7w6F+NKOkIyp3O47UKtu5Mv1Dvu758W8UbsZ7oFAU74= X-Received: by 2002:a17:902:c944:b0:158:de4a:6975 with SMTP id i4-20020a170902c94400b00158de4a6975mr10881373pla.131.1650289237217; Mon, 18 Apr 2022 06:40:37 -0700 (PDT) MIME-Version: 1.0 References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> From: Greg Hogan Date: Mon, 18 Apr 2022 09:40:26 -0400 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c2e43105dcede75d" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650289277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MrwVm2SXLEBHbgYBDElNVem8T8NiCFF5xt8gILIu8M8=; b=AsaXb5XdLuYn5S3FC7De/Ml5pYca8S6SG/lHyfvqj2KrBDVp3p6Ykga2OzzVh/LrtO4W+9 oBVMxnHKcyS8eif97+luAbxgBchbYSI3EL1gJjnUVmg/Xirx9T5gGt70TtU7y11LTtT4j/ AUhBbdr6xA4Ew8F68amY6lJEelUkdTb0zXwtloO4+vRA6X2xigUVIcCcxJ5Dw7k0faH5uP jpO2b6pHzE6K6rfxE1z/APzaJsVAywXVRq0XC65dK7zM9e1KqBff/TcpFp1NDkmTlHqkaK /2Qek5gWPgz6X/V9ZYinLwUussemLM9/sR/cl4cK0psyHISSWq9ZMUOrg2fjwQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650289277; a=rsa-sha256; cv=none; b=LSm50kyoF5RqFKsryUMVIsvTahi8iXxRbPFBHD21qh/BcD60jMvc8YCsVDE68Mf/Cg2bdo jsdMhjmh5YwXCrf2/4vtvcXNJaybgr3GYhKc1NJYwLvRMHBKMPsApn6j+Knlu8tA9KsTyJ iQrrSPetDmkx5kB49hn/AI/Y6udyElqy2Db3yis06F/CvFhHMU1YcA+ONWF4b7yGAbkZ/y rpRU4SgCPwItMGfXFb0nl92Gdr5CexJRTD2O4hHEJYd9BEm0Gt7Y1KQZ3losLCzZpdgY5J A0gV5fKFv/SZNEk/jzHrtL/PMnSevTMCsFZgt7Z6+SKsZjA/mPJjAQsu40tK/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20210112.gappssmtp.com header.s=20210112 header.b=SH735xZ4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20210112.gappssmtp.com header.s=20210112 header.b=SH735xZ4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C439D2B4F2 X-Spam-Score: -0.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: r5OGV4O2KJ1J --000000000000c2e43105dcede75d Content-Type: text/plain; charset="UTF-8" Hi Wil, I had recently looked at adding this package so I happen to have a few comments. v1.2.6 was released last week. Is it preferable to "(delete 'check)" the test phase or specify the "#:tests? #f" argument? Instead of the "replace 'install" lambda, I had done: #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))) which is both shorter and to my understanding more generic (more adaptable to future additional binaries or libraries, though this package will likely only ever have a single binary). Greg On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest wrote: > > --- > gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 1db04adf71..68f09cdbf9 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -730,6 +730,58 @@ (define-public bpytop > memory, disks, network and processes. It's a Python port and continuation > of > @command{bashtop}.") > (license license:asl2.0))) > +(define-public btop > + (package > + (name "btop") > + (version "1.2.5") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/aristocratos/btop") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1v0lj296bzwgs29hv9z3r82fwmibiqgsvsqqh2fimxs0jmld7c2v")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) ;; not provided > + (delete 'check) ;; not provided > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append > + (assoc-ref outputs "out")"/bin"))) > + (install-file "bin/btop" bin))))))) > + (home-page "https://github.com/aristocratos/btop") > + (synopsis "Resource monitor for processor, memory, disks, network and > processes") > + (description "Resource monitor that shows usage and stats > +for processor, memory, disks, network and processes. > + > +C++ version and continuation of bashtop and bpytop. > + > +Features > + > + Easy to use, with a game inspired menu system. > + Full mouse support, all buttons with a highlighted key is clickable > + and mouse scroll works in process list and menu boxes. > + Fast and responsive UI with UP, DOWN keys process selection. > + Function for showing detailed stats for selected process. > + Ability to filter processes. > + Easy switching between sorting options. > + Tree view of processes. > + Send any signal to selected process. > + UI menu for changing all config file options. > + Auto scaling graph for network usage. > + Shows IO activity and speeds for disks > + Battery meter > + Selectable symbols for the graphs > + Custom presets > + And more... > +") > + (license license:asl2.0))) > > (define-public pies > (package > > base-commit: 20645d8467852990413c1ea9cf81cec82d23defd > -- > 2.35.1 > > > > --000000000000c2e43105dcede75d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Wil,

I had recently looked at = adding this package so I happen to have a few comments.

= v1.2.6 was released last week.

Is it preferable=C2= =A0to "(delete 'check)" the test phase or specify the "#= :tests? #f" argument?

Instead of the "re= place 'install" lambda, I had done:
=C2=A0 #:make-flags = (list (string-append "PREFIX=3D" (assoc-ref %outputs "out&qu= ot;)))
which=C2=A0is both shorter and to my understanding more ge= neric (more adaptable to future additional binaries or libraries, though th= is package will likely only ever have a single binary).

Greg

On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest <bovid-19@4tii.de> wrote:

---
gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 1db04adf71..68f09cdbf9 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -730,6 +730,58 @@ (define-public bpytop
memory, disks, network and processes.=C2=A0 It's a Python port and cont= inuation of
@command{bashtop}.")
=C2=A0 =C2=A0 (license license:asl2.0)))
+(define-public btop
+=C2=A0 (package
+=C2=A0 =C2=A0 (name "btop")
+=C2=A0 =C2=A0 (version "1.2.5")
+=C2=A0 =C2=A0 (source
+=C2=A0 =C2=A0 =C2=A0 (origin
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "http= s://github.com/aristocratos/btop")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit (string-append &qu= ot;v" version))))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1v0lj296bzwgs29hv9z3r82fwmibiqgsvs= qqh2fimxs0jmld7c2v"))))
+=C2=A0 =C2=A0 (build-system gnu-build-system)
+=C2=A0 =C2=A0 (arguments
+=C2=A0 =C2=A0 =C2=A0`(#:phases
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'configure) ;; not provided<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'check) ;; not provided
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(replace 'install
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda* (#:key outputs #:allow-o= ther-keys)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((bin (string-append<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(assoc-ref outputs "out")"/bin")))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(install-file "= ;bin/btop" bin)))))))
+=C2=A0 =C2=A0 (home-page "https://github.com/aristocratos/= btop")
+=C2=A0 =C2=A0 (synopsis "Resource monitor for processor, memory, disk= s, network and processes")
+=C2=A0 =C2=A0 (description "Resource monitor that shows usage and sta= ts
+for processor, memory, disks, network and processes.
+
+C++ version and continuation of bashtop and bpytop.
+
+Features
+
+=C2=A0 =C2=A0 Easy to use, with a game inspired menu system.
+=C2=A0 =C2=A0 Full mouse support, all buttons with a highlighted key is cl= ickable
+ and mouse scroll works in process list and menu boxes.
+=C2=A0 =C2=A0 Fast and responsive UI with UP, DOWN keys process selection.=
+=C2=A0 =C2=A0 Function for showing detailed stats for selected process. +=C2=A0 =C2=A0 Ability to filter processes.
+=C2=A0 =C2=A0 Easy switching between sorting options.
+=C2=A0 =C2=A0 Tree view of processes.
+=C2=A0 =C2=A0 Send any signal to selected process.
+=C2=A0 =C2=A0 UI menu for changing all config file options.
+=C2=A0 =C2=A0 Auto scaling graph for network usage.
+=C2=A0 =C2=A0 Shows IO activity and speeds for disks
+=C2=A0 =C2=A0 Battery meter
+=C2=A0 =C2=A0 Selectable symbols for the graphs
+=C2=A0 =C2=A0 Custom presets
+=C2=A0 =C2=A0 And more...
+")
+=C2=A0 =C2=A0 =C2=A0(license license:asl2.0)))

(define-public pies
=C2=A0 (package

base-commit: 20645d8467852990413c1ea9cf81cec82d23defd
--
2.35.1



--000000000000c2e43105dcede75d--