all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Greg Hogan <code@greghogan.com>
To: Alice BRENON <alice.brenon@ens-lyon.fr>
Cc: 63295@debbugs.gnu.org
Subject: [bug#63295] [PATCH] Update csvkit to 1.1.1
Date: Thu, 11 May 2023 18:08:47 -0400	[thread overview]
Message-ID: <CA+3U0ZkBouZVgxqGdZ8o56JQb=9NGp731KnD-2Mq91Mje9VVMA@mail.gmail.com> (raw)
In-Reply-To: <20230506172704.3184033d@ens-lyon.fr>

On Sat, May 6, 2023 at 11:27 AM Alice BRENON <alice.brenon@ens-lyon.fr> wrote:
>
> Thanks for your vigilance and sorry for the duplicate. Following our
> discussion I'll leave it open for now, hoping one of them will be
> reviewed and accepted.
>
> I'll also follow the advice of the linter (actually I had first gone for a
> substitute* to fix the errors in the tests it was the linter which suggested I
> updated the packages, making me completely rewrite my patch and taking some time
> to check whether the dependencies where still needed and then I forgot to put a pair of
> parenthesis back to the line where they belonged — that, and to re-run the
> linter after having reworked on the patch that much, that is) and here is a
> hopefully cleaner version of my patch.

The patch should be divided with each package update in a separate
patch (a large number of small, similar updates can be made in a
single patch).

Your update to python-agate includes glibc-locales (a 932 MiB package)
whereas mine added python-agate-locales as a new package. Yours has
(as noted) additional changes to the inputs.

My patchset updates python-agate-sql. I don't recall why, but it must
have fixed a breaking build. The only dependent package is csvkit.




      reply	other threads:[~2023-05-11 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 10:26 [bug#63295] [PATCH] Update csvkit to 1.1.1 Alice BRENON
2023-05-05 12:41 ` Greg Hogan
2023-05-06 15:27   ` Alice BRENON
2023-05-11 22:08     ` Greg Hogan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+3U0ZkBouZVgxqGdZ8o56JQb=9NGp731KnD-2Mq91Mje9VVMA@mail.gmail.com' \
    --to=code@greghogan.com \
    --cc=63295@debbugs.gnu.org \
    --cc=alice.brenon@ens-lyon.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.