From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aB1bH6ecPmBLIAAA0tVLHw (envelope-from ) for ; Tue, 02 Mar 2021 20:14:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6IoDG6ecPmAKWwAAbx9fmQ (envelope-from ) for ; Tue, 02 Mar 2021 20:14:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF0531E042 for ; Tue, 2 Mar 2021 21:14:30 +0100 (CET) Received: from localhost ([::1]:49688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHBPa-0003VR-21 for larch@yhetil.org; Tue, 02 Mar 2021 15:14:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHBP9-0003VD-Ao for guix-patches@gnu.org; Tue, 02 Mar 2021 15:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHBP8-0002vD-2Q for guix-patches@gnu.org; Tue, 02 Mar 2021 15:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHBP7-00043m-Sr for guix-patches@gnu.org; Tue, 02 Mar 2021 15:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46728] [PATCH 0/7] gnu: aws-sdk-cpp: Update to 1.8.148. Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Mar 2021 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46728 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 46728@debbugs.gnu.org, Leo Famulari Received: via spool by 46728-submit@debbugs.gnu.org id=B46728.161471602815577 (code B ref 46728); Tue, 02 Mar 2021 20:14:01 +0000 Received: (at 46728) by debbugs.gnu.org; 2 Mar 2021 20:13:48 +0000 Received: from localhost ([127.0.0.1]:54297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHBOt-00043B-Jx for submit@debbugs.gnu.org; Tue, 02 Mar 2021 15:13:47 -0500 Received: from mail-il1-f174.google.com ([209.85.166.174]:46999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHBOr-00042w-Dv for 46728@debbugs.gnu.org; Tue, 02 Mar 2021 15:13:46 -0500 Received: by mail-il1-f174.google.com with SMTP id i18so19173855ilq.13 for <46728@debbugs.gnu.org>; Tue, 02 Mar 2021 12:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y1tpDtY2Ck8Ytpo+QTje87xX4eQqSHhYjEYSwPEgG1g=; b=Fk+PWY3Srf+ULjTaagMe1DT6JtIM/FIaAtn+OqWbAbPigybQLBU62xLWs9diAalLNP Bt+qHH5UekrBUvhX5jnifnuMItO+36sYkiMqYzZ8+YkZ0eDmZ9LjX9MPTfJ56B4zas2s O/RnAiV5DDJX/vj+lP8PBJSrtXnfq2HI0TQXMhnXAswLWw0Lw5hHiw2scFl5xBZTo/Xl QuhN36Lj6gmtpIBB40di1un4HdM+dvjLJaithUJIlEJ25JLAdiqCM6xe3KZjkm259Wwr t6U4z1fslMUfXUkiSX7r8jORC1hwRD53dpDJM4DFxMcOijKWgF6jPoEIZIAa0w+SxjNN lwZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y1tpDtY2Ck8Ytpo+QTje87xX4eQqSHhYjEYSwPEgG1g=; b=jQTTD67aiU5aPCbWBcZhbWk7YGYHRU6iSlWK25NqRFKsC8dWbEQx7QXpPQUWBCj+pR NQXsDWuE7r+Kxx/pT22DGaQoct7Jb6Dy92Yl4LT0LGjybAq0n9+21bD/GkVO2/LKQeRY 7ilwI5JK5A33IBO6XS1/ZeJ1WfNryGQA4OGJomKw8RDUr+G2TZlafpOIRjkejbvwJTce eGhzGiIUhc8IWLq/WrBzW6Y/WtJ5hx29d87dw8Yftsvf8TPRCVbJpaqc+poHYZrsuCGI XbwrEZM1BjlwfhDZ9kJDoZUSpfov5yqiF/W9KvjMCPN63BBr8eCN65EXpSHz3IT5Y/h4 hf0w== X-Gm-Message-State: AOAM532e19+yCuhxWmcy4/2MeiulmHRw29t1jhvPw+cMR6P0SWO93sM2 cZxeyp+SBGFSwu770jacj0FqIPwm6yi0VTR/DhViyQ== X-Google-Smtp-Source: ABdhPJw9oU8shKob6JOtvwYCxRRWK9RwZT4MDbaAgorVZFeXrkgnt795qy0xMjyIzyWDy5neuu7iwGumB8YhTT+Xf4s= X-Received: by 2002:a05:6e02:1806:: with SMTP id a6mr19268989ilv.8.1614716019812; Tue, 02 Mar 2021 12:13:39 -0800 (PST) MIME-Version: 1.0 References: <878s75uz1n.fsf_-_@gnu.org> In-Reply-To: <878s75uz1n.fsf_-_@gnu.org> From: Greg Hogan Date: Tue, 2 Mar 2021 15:13:29 -0500 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c648b905bc935e54" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614716071; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=y1tpDtY2Ck8Ytpo+QTje87xX4eQqSHhYjEYSwPEgG1g=; b=BL3YlG3h+zhVdrjxAxpVN37Q7rnHt59/lSIRh6m9tdpMugtIf5is6h8qkPThYwFqtHYaHi 7Vdr4NM88RBwEZd1v/xjRNwY+RI7y5IsKKl23mOhVolLKU4ntus6Uh9Mln0g5Q82/uUbRl j64uhujsarvM3xNjbPhzSdtDFphzU1Z+yJuixmytsEMEyV1orjLSPP4+vGoPT2YwpkVaq1 IB/9rIahdXGkWYQuFYC9DkmuaKqhhQXkqxNBATsSd0oFVwtRAd4/8Uv6H0wYQ+rr6tGhlO PZkDbzUCyIcknlLd4N9FqsYhvdLgJrBvcdLSyCpa14o2U2uslgY+RfagUl4PmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614716071; a=rsa-sha256; cv=none; b=Y223CLJ8jN+A0HaD3EdQwlo1eG/HpwZdef7SlWfTX5OdsGjFKCAd9LYvYAvWnouZmTeBRe Uig1kScUKZAre8wYwklIwFxRB6jrigvWjEAeV5NN7VkmoPXY6nV4CmTxOyeXK26bxqisPb Xc/16n4RCk6DEjq+NaBuXOIjb1XbAHHiiXtTDw67Os+OcU8JChDzDRxwrMGx8pf3aYToRT fu43uqq2G/phyljjNyxFc+Yh8aY7Ih9yACqt/Lxb8G3c8jn/DQa1ydI/tr+G0WBJeBTEVv 9GZRc/1q8QY41jIJbjdjbYNwKuoT3p636/byp1w9m5aNWFiu64ntbr2nvmexdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20150623.gappssmtp.com header.s=20150623 header.b=Fk+PWY3S; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20150623.gappssmtp.com header.s=20150623 header.b=Fk+PWY3S; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CF0531E042 X-Spam-Score: -1.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9QInpovp8LAf --000000000000c648b905bc935e54 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 2, 2021 at 2:37 PM Ludovic Court=C3=A8s wrote: > Hi, > > Greg Hogan skribis: > > > The AWS packages (aws-sdk-cpp and dependencies) are currently built as > > static libraries. I would like to build both static and shared but coul= d > > not find an example or simple method for building both using cmake. Do > you > > think it would be worthwhile to extend the cmake-build-system to > optionally > > configure, build, and install static libraries with additional phases? > The > > gnu-build-system makes it easy to inline a new phase into the package > > definition (when the makefile has both 'make' and 'make static' targets= ) > > but with CMake we are forced to duplicate the configure phase, which is > 44 > > lines of code. > > In general, it=E2=80=99s best to build only shared libraries. That allow= s for > reduced memory usage, fast security updates via grafts, etc. So if you > could make the AWS packages build as shared libraries only, that=E2=80=99= d be > great. > > It=E2=80=99s OK to optionally add static libraries, preferably in a separ= ate > output or even a separate package, but that=E2=80=99s not what should be = used by > default. > > Does that make sense? Yes, I would prefer to provide shared as the default output and static as a separate output to the same package. There look to be three options: 1) separate packages (as with boost and boost-static). This is simple but not as elegant (boost-static is the eighth most relevant package when guix search'ing for "boost"). 2) duplicate CMake phases in the package definition (much more verbose than with gnu-build-system). This results in considerable duplication of build system code and is unmaintainable. 3) extend the cmake-build-system to optionally configure, build, and install static libraries with additional phases. The ideal result but requires modification of the cmake-build-system. Thoughts? > Thanks, > Ludo=E2=80=99. > --000000000000c648b905bc935e54 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 2, 2021 at 2= :37 PM Ludovic Court=C3=A8s <ludo@gnu.or= g> wrote:
Hi,
Greg Hogan <code= @greghogan.com> skribis:

> The AWS packages (aws-sdk-cpp and dependencies) are currently built as=
> static libraries. I would like to build both static and shared but cou= ld
> not find an example or simple method for building both using cmake. Do= you
> think it would be worthwhile to extend the cmake-build-system to optio= nally
> configure, build, and install static libraries with additional phases?= The
> gnu-build-system makes it easy to inline a new phase into the package<= br> > definition (when the makefile has both 'make' and 'make st= atic' targets)
> but with CMake we are forced to duplicate the configure phase, which i= s 44
> lines of code.

In general, it=E2=80=99s best to build only shared libraries.=C2=A0 That al= lows for
reduced memory usage, fast security updates via grafts, etc.=C2=A0 So if yo= u
could make the AWS packages build as shared libraries only, that=E2=80=99d = be
great.

It=E2=80=99s OK to optionally add static libraries, preferably in a separat= e
output or even a separate package, but that=E2=80=99s not what should be us= ed by
default.

Does that make sense?

Yes, I would prefer t= o provide shared as the default output and static as a separate output to t= he same package. There look to be three options:

1= ) separate packages (as with boost and boost-static). This is simple but no= t as elegant (boost-static is the eighth most relevant package when guix se= arch'ing for "boost").

2) duplicate = CMake phases in the package definition (much more verbose than with gnu-bui= ld-system). This results in considerable duplication of build system code a= nd is unmaintainable.

3) extend the cmake-build-sy= stem to optionally configure, build, and install static libraries with addi= tional phases. The ideal result but requires modification of the cmake-buil= d-system.

Thoughts?
=C2=A0=C2=A0
Thanks,
Ludo=E2=80=99.
--000000000000c648b905bc935e54--