From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IKAzESGyN2AyPwAA0tVLHw (envelope-from ) for ; Thu, 25 Feb 2021 14:20:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iLb/DCGyN2DXcwAAB5/wlQ (envelope-from ) for ; Thu, 25 Feb 2021 14:20:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 66FF01994B for ; Thu, 25 Feb 2021 15:20:16 +0100 (CET) Received: from localhost ([::1]:50056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFHV1-0005oO-IZ for larch@yhetil.org; Thu, 25 Feb 2021 09:20:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFHUo-0005lV-RD for guix-patches@gnu.org; Thu, 25 Feb 2021 09:20:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFHUo-0007hv-JJ for guix-patches@gnu.org; Thu, 25 Feb 2021 09:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFHUo-0002Xi-EX for guix-patches@gnu.org; Thu, 25 Feb 2021 09:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46728] [PATCH 4/7] gnu: Add s2n. Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Feb 2021 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46728 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 46728@debbugs.gnu.org Received: via spool by 46728-submit@debbugs.gnu.org id=B46728.16142627939755 (code B ref 46728); Thu, 25 Feb 2021 14:20:02 +0000 Received: (at 46728) by debbugs.gnu.org; 25 Feb 2021 14:19:53 +0000 Received: from localhost ([127.0.0.1]:37118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFHUf-0002XH-HB for submit@debbugs.gnu.org; Thu, 25 Feb 2021 09:19:53 -0500 Received: from mail-io1-f54.google.com ([209.85.166.54]:38696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFHUa-0002X1-Dv for 46728@debbugs.gnu.org; Thu, 25 Feb 2021 09:19:52 -0500 Received: by mail-io1-f54.google.com with SMTP id k2so554920ioh.5 for <46728@debbugs.gnu.org>; Thu, 25 Feb 2021 06:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TFvTmDC4njR9qIlA7i9TQ9FUpSJP6aV9kXPQvw0TslM=; b=r4cuKsX53ICyJm+1IWN2t28F16D5DMM/Oy2uuB0s+iMPCSMgqs2kJUXfbuL01pZwVZ jxC5eCYJs5KnRm5yoOOH+bjmraRi89ryU3DS2XWx2eYhgrdYFgL5B88UVyxaRIUz4BsK Q969zqg9+lQFblqukReIi+jirD4r9dPGK/1aNSOzBzvqLiwrk5e0IlIL6flFK5sC+M61 Kx+AmjD3pZ8OdkPnstTBUeLCu7mnuL+tRGGvcpWNiUtZXfWqvHFfj3/1yG6nmMzog/f9 W4ghIYgBPLhn0gvEi9+t86AKtWmrLLg+QY3D2/up3Agcht+A3JhNXSVkCg7xN5+hWwtN zrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TFvTmDC4njR9qIlA7i9TQ9FUpSJP6aV9kXPQvw0TslM=; b=nYJNBkxJHhJe3tNE2k4usLaRw4k8zm+P2lOulBBUF10SrPBCKHHZ6SxXWV3RMehekI qDxtnQHNcvEpwte0SXy+zWg2orJn5DarLPKsFqpltfMeHOaL7W7BeK//72agrmc7VV/p JpMseLfEChAwybx79A5Zw2DKCdRPs51SHHYRmwvVnoUrt82R/O3PMZTmHwa3HpvXmcPN SOj+dkLiA/4jgU/1mcAy8FoFRaCxT1n8tEovkPxV2I4XdGmjjgB7dvjOZkiCEFYN9Ny6 cyVrbw7PuqZ1zFXsL5AYcVu7+4QeEJHFmJI6/9eYeeXAs59BJZElwdcWO76Ad1CkI18D Kr+Q== X-Gm-Message-State: AOAM530BHFRWtRhuqyp6U6mOapYNrTyS9EoX3iCXxBu3p53OQtbe2NC1 usDIHIvd8xWGiIL9TxKs5bWBoi0+eqhcTfrQ2xdinMVv+II741XU X-Google-Smtp-Source: ABdhPJy03IL1MH2a31WKT5Dky+c1zKlmgQuRdWo0IjS6fH+/2ZKHY9sQl52B2aQKKmnPvn+GdliixvR6yW+2uz865Z0= X-Received: by 2002:a6b:8b83:: with SMTP id n125mr2908233iod.35.1614262782603; Thu, 25 Feb 2021 06:19:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Greg Hogan Date: Thu, 25 Feb 2021 09:19:31 -0500 Message-ID: Content-Type: multipart/alternative; boundary="000000000000bb4b7605bc29d798" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20150623.gappssmtp.com header.s=20150623 header.b=r4cuKsX5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 66FF01994B X-Spam-Score: -1.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: HXS13CClwCYJ --000000000000bb4b7605bc29d798 Content-Type: text/plain; charset="UTF-8" Hi Leo, The CMake configuration [1] has both shared and static dependencies on LibCrypto. The AWS packages (aws-sdk-cpp and dependencies) are currently built as static libraries. I would like to build both static and shared but could not find an example or simple method for building both using cmake. Do you think it would be worthwhile to extend the cmake-build-system to optionally configure, build, and install static libraries with additional phases? The gnu-build-system makes it easy to inline a new phase into the package definition (when the makefile has both 'make' and 'make static' targets) but with CMake we are forced to duplicate the configure phase, which is 44 lines of code. Greg [1] https://github.com/aws/s2n-tls/blob/main/cmake/modules/FindLibCrypto.cmake On Wed, Feb 24, 2021 at 4:34 PM Leo Famulari wrote: > On Tue, Feb 23, 2021 at 06:17:06PM -0500, Greg Hogan wrote: > > From 78e69597f63b22a3249853208e88f8f57cf84054 Mon Sep 17 00:00:00 2001 > > From: Greg Hogan > > Date: Tue, 19 Jan 2021 12:52:01 +0000 > > Subject: [PATCH 4/7] gnu: Add s2n. > > > > * gnu/packages/tls.scm (s2n): New variable. > > Thank you for this patch series! > > > + (propagated-inputs > > + `(("openssl" ,openssl) > > + ("openssl:static" ,openssl "static"))) > > I'm wondering specifically about the use of static OpenSSL in these > patches. It's a little unusual to use statically-linked outputs in Guix. > Is it required for s2n? > --000000000000bb4b7605bc29d798 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Leo,

The= CMake configuration [1] has both shared and static dependencies on LibCryp= to.

The AWS packages (aws-sdk-cpp and dependencies= ) are currently built as static libraries. I would like to build both stati= c and shared but could not find an example or simple method for building bo= th using cmake. Do you think it would be worthwhile to extend the cmake-bui= ld-system to optionally configure, build, and install static libraries with= additional phases? The gnu-build-system makes it easy to inline a new phas= e into the package definition (when the makefile has both 'make' an= d 'make static' targets) but with CMake we are forced to duplicate = the configure phase, which is 44 lines of code.

Gr= eg


On Wed, Feb = 24, 2021 at 4:34 PM Leo Famulari <leo@famulari.name> wrote:
On Tue, Feb 23, 2021 at 06:17:06PM -0500, Greg Hogan wrote:
> From 78e69597f63b22a3249853208e88f8f57cf84054 Mon Sep 17 00:00:00 2001=
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 19 Jan 2021 12:52:01 +0000
> Subject: [PATCH 4/7] gnu: Add s2n.
>
> * gnu/packages/tls.scm (s2n): New variable.

Thank you for this patch series!

> +=C2=A0 =C2=A0 (propagated-inputs
> +=C2=A0 =C2=A0 =C2=A0`(("openssl" ,openssl)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("openssl:static" ,openssl "= ;static")))

I'm wondering specifically about the use of static OpenSSL in these
patches. It's a little unusual to use statically-linked outputs in Guix= .
Is it required for s2n?
--000000000000bb4b7605bc29d798--