From: Julien Lepiller <julien@lepiller.eu>
To: zimoun <zimon.toutoune@gmail.com>,
Evgeny Pisemsky <evgeny@pisemsky.com>,
61468@debbugs.gnu.org
Subject: [bug#61468] [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Mon, 13 Feb 2023 13:28:08 +0100 [thread overview]
Message-ID: <C895FC02-45DC-41B1-BA71-74836516C742@lepiller.eu> (raw)
In-Reply-To: <8635797pom.fsf@gmail.com>
Hehe version "1" got through review ;) I agree it would be nice to use git-version instead, but I wouldn't go back to version "0" since guix would detect a package downgrade.
Evgeny, I can take care of that don't worry.
Le 13 février 2023 12:47:05 GMT+01:00, zimoun <zimon.toutoune@gmail.com> a écrit :
>Hi,
>
>On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny@pisemsky.com> wrote:
>
>> (define-public cat-avatar-generator
>> (package
>> (name "cat-avatar-generator")
>> - (version "1")
>> + (version "2")
>> (source (origin
>> (method git-fetch)
>> (uri (git-reference
>> - (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> - (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad")))
>> + (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> + (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")))
>
>The common practise when it is not yet released is to use this pattern:
>
>--8<---------------cut here---------------start------------->8---
>(let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")
> (revision "2"))
> (package
> (name "cat-avatar-generator")
> (version (git-version "1" revision commit))
>[...]
> (commit commit)
>--8<---------------cut here---------------end--------------->8---
>
>Although it was not used by the initial addition
>3bedac50571204643d5e3b204dc720ae7d571a1f. :-)
>
>Even, maybe version should 0 and not 1; I do not know.
>
>Cheers,
>simon
>
>
>
next prev parent reply other threads:[~2023-02-13 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 3:40 [bug#61468] [PATCH] gnu: cat-avatar-generator: Update to 2 Evgeny Pisemsky
2023-02-13 11:47 ` zimoun
2023-02-13 12:28 ` Julien Lepiller [this message]
2023-02-25 15:18 ` [bug#61468] Updated patch Evgeny Pisemsky
2023-03-10 16:31 ` Evgeny Pisemsky
2023-03-16 11:36 ` bug#61468: [PATCH] gnu: cat-avatar-generator: Update to 2 Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C895FC02-45DC-41B1-BA71-74836516C742@lepiller.eu \
--to=julien@lepiller.eu \
--cc=61468@debbugs.gnu.org \
--cc=evgeny@pisemsky.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.