From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6DdQDV/zVWPGNQAAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 04:07:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wIA+DV/zVWMCgwEAauVa8A (envelope-from ) for ; Mon, 24 Oct 2022 04:07:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3BE92E872 for ; Mon, 24 Oct 2022 04:07:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omjpc-0000Rp-LX for larch@yhetil.org; Sun, 23 Oct 2022 18:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omM1G-0000T4-0r for guix-patches@gnu.org; Sat, 22 Oct 2022 17:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omM1F-0002ze-QH for guix-patches@gnu.org; Sat, 22 Oct 2022 17:27:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omM1F-0006n4-LC for guix-patches@gnu.org; Sat, 22 Oct 2022 17:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58614] [PATCH 000/187] Remove unused crates Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Oct 2022 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Christopher Baines , 58614@debbugs.gnu.org Received: via spool by 58614-submit@debbugs.gnu.org id=B58614.166647399026065 (code B ref 58614); Sat, 22 Oct 2022 21:27:01 +0000 Received: (at 58614) by debbugs.gnu.org; 22 Oct 2022 21:26:30 +0000 Received: from localhost ([127.0.0.1]:42502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omM0j-0006mL-Ly for submit@debbugs.gnu.org; Sat, 22 Oct 2022 17:26:30 -0400 Received: from lepiller.eu ([89.234.186.109]:42846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omM0g-0006m8-3y for 58614@debbugs.gnu.org; Sat, 22 Oct 2022 17:26:28 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 78251b44; Sat, 22 Oct 2022 21:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=1a7/Ycuf+H7U /Fz2UgX+qNWHujd0pTJ4kv/xBcVaFuo=; b=UYJ0HM1jJgOMUCDuqW9PooIpYQaV ueSyEddbCnuhLiKlrijiZI4wpLjdaqvZJQoeIAt9DYoiul8oN58eIum0oMyDYtJC 62B/e7f6tx5uA9LcaVjrtitDSYhqCf2imvChisRwUewJcHagyb0GsVOCtZqL7V4I oz4Pqq4aTFVHap5T6XZheRXP/eDUbkxhYr9TerX8p565t8FZd43EkFU7D8EeQ5fi rr80Vl3sCD+o4xq7mn0PSJk8fO4jEkiNIGtQQmjoutjkUxuXDqOspuHWTjMcZHOZ MxyVqgP1NNIbFuyNxIvjLp98mhoxv+vno7LIOgI5g2k3FCUTdj+yeigUTg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 106743c4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 22 Oct 2022 21:26:22 +0000 (UTC) Date: Sat, 22 Oct 2022 23:26:21 +0200 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: References: <878rl9i1tw.fsf@cbaines.net> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----4WECGMYYY4UUD4LNMMXLXBYGY6MU19 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666577247; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qG3wFKCxoApXsKaW02/xuaOgtQwC0AJ9rRxkhO6u2Zc=; b=VKg3MyH6yeJK7uwBBPHdG09GD8GFmvyhsOXQ5ozuiTWNGRDVo8+MuY8zfD7Cg0lQFSpn7T t+mkOOnpQTjQX+x4ZaFdP1gZMDbmIUkIt+y1bxP+DA30jjsXeoqqK8fAI7JCCoxT3YHCLY dsFcmZ3mS8L4paJcOZtjp1bVa/s7sohSMUI53oBIxF4Et+51t385Im0BQU9YgRT2eC8sKE YUQG6h/wjMiFQUnKB0Dhel12Du6X0+Hf6L4r1wM+cY3I6F2Bl/6uvxMkbqs9Vt3LmsxXWb dapv8Msi/jlOHm8hWz9R8GH0XYDbqft0UXP3nAmfkQ0dKamATvAp7Z+A4zA5ug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666577247; a=rsa-sha256; cv=none; b=ZSVg/36e3bu79L9mQOc8OHcdVC27pI87XDJV8Abs3bB7LjISQMCwng2+EeJsqjK92Iuh0P VKDEAYP9pQSmwLhLAnSA5lFnL/xlriYa5o/I6oxFE6Xdyxi5p/7KsD822dpYQ3LNJEasGo EF8PsprDscLHauFvFjSOjzo7RhHSVW1hfvkZSFcbVMK++Bxnh7bMLxzyIsoFtVnQnQvl6O HegOsc+9QjMsIRLez8fz21Z6caL+7FIDXxWgjr6hV0/JhTsVzYSyfVGPX60db212Se7sOH X6G2vRdFFoRsJzubGPXuDbC6dbk7CO8wrwCWNnFcOvBe3pmZ/0jYOudnhYsJ+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=UYJ0HM1j; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 8.29 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=UYJ0HM1j; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F3BE92E872 X-Spam-Score: 8.29 X-Migadu-Spam: Yes X-Migadu-Scanner: scn0.migadu.com X-TUID: OdqBhubb9VBO ------4WECGMYYY4UUD4LNMMXLXBYGY6MU19 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I propably didn't ask my question properly=2E How were those crates selecte= d for removal? From=20your answer, it seems that being a leaf package was the only criteria= =2E But there are useful leaf packages=2E So, are there other criteria, or did you manually review them to ensure th= e packages are no longer useful? Or are crates generally not useful if noth= ing depends on them, in which case, what is a crate? Le 22 octobre 2022 21:35:22 GMT+02:00, Efraim Flashner a =C3=A9crit=C2=A0: >On Sat, Oct 22, 2022 at 07:49:34AM +0200, Julien Lepiller wrote: >> I'm wondering why we want to do that? Are those outdated maybe? At this= rate we'll remove all crates :) > >Would it be that bad? :) > >The cargo ecosystem relies pretty heavily on semver and due to the >upgrade cycle we don't always remove old crates when nothing else >depends on them=2E I'd guess that some of them might be part of an >upstream-all-dependencies move (which I've done before) and most of them >are probably just outdated=2E > >> Le 21 octobre 2022 18:21:47 GMT+02:00, Christopher Baines a =C3=A9crit=C2=A0: >> > >> >Efraim Flashner writes: >> > >> >> This is round 1 of removing unreferenced crates=2E All of the crates >> >> removed _should_ have no dependencies inside Guix proper=2E I used t= he >> >> command listed below and then manually searched for the lines ending >> >> with ':1' and made sure the package definition was the only referenc= e to >> >> that package=2E >> >> >> >> grep define-public gnu/packages/crates-*scm | \ >> >> awk '{print $NF}' | xargs -I{} sh -c 'echo {} && git grep -c {}' >> >> >> >> I then removed all the packages and rebuilt all the modules which us= ed >> >> the cargo-build-system somewhere inside them and rebuilt all the >> >> modules=2E >> >> >> >> git grep -c cargo-build-system | cut -f1 -d':' | grep \\=2Escm$ | \ >> >> sed -e 's/scm/go/' | xargs -n1 rm >> >> >> >> Efraim Flashner (187): > >> >> >> >> gnu/packages/crates-graphics=2Escm | 187 -- >> >> gnu/packages/crates-gtk=2Escm | 59 - >> >> gnu/packages/crates-io=2Escm | 4645 -------------------------= ----- >> >> 3 files changed, 4891 deletions(-) >> >> >> >> >> >> base-commit: 3bb145b6e2a8c84e7739ead9ae76dc4d42bb9850 >> > >> >This looks good to me: https://qa=2Eguix=2Egnu=2Eorg/issue/58614 >> > >> >Thanks, >> > >> >Chris > >--=20 >Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99= =D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 >GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 >Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed ------4WECGMYYY4UUD4LNMMXLXBYGY6MU19 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I propably didn't ask my question properly=2E How = were those crates selected for removal?

From your answer, it seems t= hat being a leaf package was the only criteria=2E But there are useful leaf= packages=2E

So, are there other criteria, or did you manually revie= w them to ensure the packages are no longer useful? Or are crates generally= not useful if nothing depends on them, in which case, what is a crate?
=
Le 22 octobre 2022 21:35:22 GMT+02:00, Efrai= m Flashner <efraim@flashner=2Eco=2Eil> a =C3=A9crit=C2=A0: 
On Sat, Oct 22, 2022 at 07:49:34AM +020=
0, Julien Lepiller wrote:
I'm wondering why we want to do that? Are those outdated maybe? At this =
rate we'll remove all crates :)

Would it be that bad? :=
)

The cargo ecosystem relies pretty heavily on semver and due to the=

upgrade cycle we don't always remove old crates when nothing else
de=
pends on them=2E I'd guess that some of them might be part of an
upstrea=
m-all-dependencies move (which I've done before) and most of them
are pr=
obably just outdated=2E

Le 21 octobre 2022 18:21:47 GMT+02:00, Christopher Baines <mail@cba=
ines=2Enet> a =C3=A9crit :

Efraim Flashner <efraim@flashner=2Eco=2Eil> writes:
 This is round 1 of =
removing unreferenced crates=2E All of the crates
 removed _should_ have=
 no dependencies inside Guix proper=2E I used the
 command listed below =
and then manually searched for the lines ending
 with ':1' and made sure=
 the package definition was the only reference to
 that package=2E
 grep define-public gnu/packages/crates-*scm | \
     awk '{print $NF}=
' | xargs -I{} sh -c 'echo {} && git grep -c {}'

 I then rem=
oved all the packages and rebuilt all the modules which used
 the cargo-=
build-system somewhere inside them and rebuilt all the
 modules=2E
 git grep -c cargo-build-system | cut -f1 -d':' | grep \\=2Escm$ | \
 =
    sed -e 's/scm/go/' | xargs -n1 rm

 Efraim Flashner (187):
<snip>
=


  gnu/packages/crates-=
graphics=2Escm |  187 --
  gnu/packages/crates-gtk=2Escm      |   59 -  gnu/packages/crates-io=2Escm       | 4645 -----------------------------=
-
  3 files changed, 4891 deletions(-)


 base-commit: 3bb145b6=
e2a8c84e7739ead9ae76dc4d42bb9850

This looks good to me:=
 https://qa=2Eguix=2E=
gnu=2Eorg/issue/58614

Thanks,

Chris

-- 
Efraim Flashner   <ef=
raim@flashner=2Eco=2Eil>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =D7=A4=D7=9C=
=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC =
CA3D 8351
Confidentiality cannot be guaranteed on emails sent or receive=
d unencrypted
------4WECGMYYY4UUD4LNMMXLXBYGY6MU19--