From: Julien Lepiller <julien@lepiller.eu>
To: Martin Becze <mjbecze@riseup.net>, 36866@debbugs.gnu.org
Subject: [bug#36866] [PATCH] added trezord package
Date: Thu, 01 Aug 2019 08:48:18 +0200 [thread overview]
Message-ID: <C3A23F88-E2B3-4771-B7C1-BAEE14BE6AB7@lepiller.eu> (raw)
In-Reply-To: <71E9E80C-BB07-49CE-9F27-36ED73027AAF@lepiller.eu>
Le 1 août 2019 08:12:25 GMT+02:00, Julien Lepiller <julien@lepiller.eu> a écrit :
>Le 1 août 2019 03:38:53 GMT+02:00, Martin Becze <mjbecze@riseup.net> a
>écrit :
>>heyyy does anyone know if this is the correct way to open a PR to
>guix?
>>kinda missing easy github mode here... lol
>
>Hey Martin,
>
>You're on the right track. Now, you just have to send your patches to
>this bug (36866@debbugs.gnu.org) with git send-email. If there's only
>one patch, you may send it as an attachment instead, but send-email is
>the prefered way.
Hi again,
For some reason I didn't see your previous email with the patch, but I do now. Can you make sure the copyright line at the beginning is correct? It should only mentionned people who worked on that file, including you.
Github tarballs are autogenerated, but get regenerated from time to time and they are not stable. We prefer to use tge git-fetch method for github, since it is more stable. There thould be plenty of examples in the repo, but we can take care of that. Otherwise, nice patch! Could you send an updated one to this bug number? Thank you!
next prev parent reply other threads:[~2019-08-01 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 0:11 [bug#36866] [PATCH] added trezord package mjbecze
2019-08-01 1:38 ` Martin Becze
2019-08-01 6:12 ` Julien Lepiller
2019-08-01 6:48 ` Julien Lepiller [this message]
2019-08-01 19:31 ` [bug#36866] [PATCH 2/2] fixed copyright line and use git-fetch mjbecze
2019-08-01 20:16 ` bug#36866: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3A23F88-E2B3-4771-B7C1-BAEE14BE6AB7@lepiller.eu \
--to=julien@lepiller.eu \
--cc=36866@debbugs.gnu.org \
--cc=mjbecze@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.