From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oMbWNaAbkmJyWwAAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 14:54:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CL25NaAbkmIwXwEAauVa8A (envelope-from ) for ; Sat, 28 May 2022 14:54:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 736BA8C73 for ; Sat, 28 May 2022 14:54:56 +0200 (CEST) Received: from localhost ([::1]:48436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuvy2-0005M9-Fs for larch@yhetil.org; Sat, 28 May 2022 08:54:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuuX8-0003O7-JH for guix-patches@gnu.org; Sat, 28 May 2022 07:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuuX8-00063O-9f for guix-patches@gnu.org; Sat, 28 May 2022 07:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuuX8-0005El-58 for guix-patches@gnu.org; Sat, 28 May 2022 07:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54974] [PATCH] added btop References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Resent-From: Wil deBeest Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 May 2022 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54974 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54974@debbugs.gnu.org, Greg Hogan Received: via spool by 54974-submit@debbugs.gnu.org id=B54974.165373692720053 (code B ref 54974); Sat, 28 May 2022 11:23:02 +0000 Received: (at 54974) by debbugs.gnu.org; 28 May 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1]:36550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuuWF-0005DM-3x for submit@debbugs.gnu.org; Sat, 28 May 2022 07:22:07 -0400 Received: from mail.4tii.de ([178.254.9.173]:47000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuuW6-0005Cf-Qa for 54974@debbugs.gnu.org; Sat, 28 May 2022 07:22:05 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1653736911; bh=CZlCeZMAkYT9NfN0qao6V8fcjXTGJsG+1ORbsAWy+80=; h=From:Subject:Date:Cc:To; b=4fG/zig8IaoJajMd0oUxRmHMMHWaN/+EeV4cvOrtiz7RfmKQqt6lFyg5Kj2rloNFi 6g00lERggVGsgL7ZUb5a0RsFILhF6hX/G5lKvw67YFOe7on6RGKr4LqWJnuSrQpqbB 3wxuxW1462NKq+HzLwW52iVGZKwBnKseC0q+5R4E= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Message-Id: Date: Sat, 28 May 2022 13:21:49 +0200 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 28 May 2022 08:54:44 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653742496; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CZlCeZMAkYT9NfN0qao6V8fcjXTGJsG+1ORbsAWy+80=; b=aRMuE/TTmKVzSvDavCwKb+JRtpdqgWpPbIwVnEBiu+tlLYZWON61wO1wDZjQRTDPNRSdiM rRsUMYN0PL3vPw5eOgqHjK5MzLJwPOB1ZoKmiOyrPswP/zwehPARYmvQ38QX6q9y7MOWAb 4usa4qbIcc+A+n6S1G+F3hlz3oNKe9deddWH0kgvpvqtWVqM4tjmX0rCgN12RZ5jH2voTQ Qdnk3p5gdLPKcWqOf4pW0I9D+HEVLMS3jhaPLdLxA4H7G9INZPb4aF3Xt9oX3N0UDztr1w hz6Mik6UOHA/lzgi6mpV29VqaujX0gtx3GkPaAdBhh504ywst6MdnSFKRMK10w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653742496; a=rsa-sha256; cv=none; b=ppgqNYDPZYbccvHpfGRjvMTPVa8jAFhob47jqqf0U6pfHIVuqRmTWKxoyctfdzxk/zZv6o IkX1tbMs7ssY28wMmk7Kfh+sBDE2TK1jpgoYjlTTQPVgJTq8e338tcKmz1EzhjjhW+VQLB zM2ZzqRCWK8GsxMPLRGzFGcPJnGBirc5uYdZ2Qh895ihQql/SpYEwq3KR94yI01hT9BKte dpdVwhzv/o474S75CQI3T4rda8Q8N1LWLpSFbogBYrrZcbR/I2YZvKUQj7Pql9fra+4Tap t/ypy8ib6qk+xZZedj8o2pl3bEMDo15qIPQRX3lQtSuCS9pWJSxVa4G9tFAb5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=4tii.de header.s=mail header.b="4fG/zig8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=4tii.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=4tii.de header.s=mail header.b="4fG/zig8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=4tii.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 736BA8C73 X-Spam-Score: 7.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: FND9qtl3EMDq =EF=BB=BFMaxime Devos writes: > [[PGP Signed Part:Undecided]] > Wil deBeest schreef op vr 29-04-2022 om 01:17 [+0200]: >> =EF=BB=BFHi Maxime, >>> Long term, %outputs, %build-inputs, ... are being phased out, so I'd go >>> with, so I'd go with >>> (arguments (list #:make-flags #~(string-append "PREFIX=3D" #$output))= ) >>> here instead. >> I haven't been able to integrate your snippet into the package. Could y= ou >> show me how to do so or tell me which part of the handbook would be >> relevant? >=20 > For a good example, see the 'stress-ng' package definition 'guix edit > stress-ng'. #:make-flags is documented in the manual (search for > #:make-flags or go to (guix)Build Systems). #$output is documented in > =E2=80=98(guix)G-Expressions=E2=80=99. >=20 > Very concretely: >=20 > (package > [...] > (arguments (list #:tests? #false ; some comment > #:make-flags #~(...) > #:phases > ;; [Stuff for replacing the install phase and > ;; removing the configure phase] > #~(modify-phases %standard-phases ...)))) >=20 > Greetings, > Maxime. >=20 > [[End of PGP Signed Part]] Thank you, I think I got it. I've also added gcc-12 as a native input for efficiency reasons [1]. Since I'm not familiar with the process of deprecation, I've kept the though= ts I had written down regarding your question on whether bashtop & bpytop co= uld be removed, even though there's probably nothing in there that hasn't at= least been discussed before [2] Cheers! --- gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index af75dee697..fccc0e8dd3 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -101,6 +101,7 @@ (define-module (gnu packages admin) #:use-module (gnu packages file) #:use-module (gnu packages flex) #:use-module (gnu packages gawk) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -752,6 +753,37 @@ (define-public bpytop @command{bashtop}.") (license license:asl2.0))) +(define-public btop + (package + (name "btop") + (version "1.2.6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aristocratos/btop") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "03nd34q1w01visd2bg7mxrcjn0s6lnbm4s0vsfsj2mfv1rvyjl5b")))) + (native-inputs (list gcc-12)) + (build-system gnu-build-system) + (arguments + (list #:make-flags + #~(list (string-append "PREFIX=3D" #$output)) + #:phases + #~(modify-phases %standard-phases + (delete 'configure)) + #:tests? #f)) + (home-page "https://github.com/aristocratos/btop") + (synopsis "Resource monitor") + (description "Resource monitor that shows usage and stats +for processor, memory, disks, network and processes. + +C++ version and continuation of bashtop and bpytop.") + (license license:asl2.0))) + (define-public pies (package (name "pies") base-commit: 6e9d99f97f15347f44df0518faa5e3b8b9d5184e --=20 2.36.1 [1] "Needs GCC 10 or higher, (GCC 11 or above strongly recommended for better CPU efficiency in the compiled binary)", sayeth the readme [2] Is there a mechanism to flag these packages so a deprecation warning would be shown when they are searched for? (A first look seems to suggest `gexp->derivation' could be used for that, but I'll have read that more thoroughly) If there is I think it would make sense to add a deprecation warning including that reasons why they shouldn't be replaced can be directed to e.g. 54974@debbugs.gnu.org and wait for feedback for some set amount of time before either redefining the package names as aliases for btop or removing them. In both cases I think a message would make sense for those who have installed them. For others, adding something like "replaces its predecessors bashtop and bpytop" to the description seems to be enough.