From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Vollmert Subject: Re: on indentation Date: Sat, 15 Jun 2019 13:23:29 +0200 Message-ID: References: <87d0jgq6pc.fsf@elephly.net> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50541) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc6oP-0005Ag-Mk for guix-devel@gnu.org; Sat, 15 Jun 2019 07:25:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc6md-0008So-NX for guix-devel@gnu.org; Sat, 15 Jun 2019 07:23:45 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:41570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hc6md-0008JI-2A for guix-devel@gnu.org; Sat, 15 Jun 2019 07:23:43 -0400 In-Reply-To: <87d0jgq6pc.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org [ missed the list cc previously ] > On 14. Jun 2019, at 21:59, Ricardo Wurmus wrote: >> * I can run etc/indent-code.el by hand from the guix source >> repo, but it would be much nicer to have it available as a >> regular executable. >=20 > I would not package it. Isn=E2=80=99t it already usable as an = executable? It > is a regular script after all. Well here it starts with #!/usr/bin/emacs --script. And guix environment = guix doesn=E2=80=99t provide emacs. It felt like the right way around that = would be to package it, but perhaps adding emacs to the environment and change the shebang to /usr/bin/env emacs would be a good change then? >> * Most source files aren=E2=80=99t indented according to = etc/indent-code.el, >> presumably because guix import uses (ice-9 pretty-print) which does >> things differently. How to deal with this? >=20 > The importers produce expressions that don=E2=80=99t look the way we = want them > to look. Usually we re-indent the code (with etc/indent-code.el or = the > equivalent manual invocation in Emacs) before committing. >=20 > Some existing code, however, may predate our indentation refinements, > and yet other parts may have been overlooked. When we touch those > sections anyway we may also adjust the indentation, but making purely > cosmetic commits is discouraged. I=E2=80=99m curious, why is that discouraged? In my experience for this = kind of formatting issue, the best approach is to get it over with once and for = all and enforce the standards from that point. >> * Is anyone aware of a different command-line guile/scheme/sexp >> code formatter? etc/indent-code.el is a bit slow, and a tool that >> reformats stdin to stdout would be useful for calling from other >> editors. >=20 > I don=E2=80=99t think such a tool exists, also because we specify = special > indentation rules for certain Guix-specific macros. Emacs allows us = to > do that so etc/indent-code.el uses Emacs. >=20 > Perhaps we can speed it up a little? That would be great! Robert