From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37873)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iVhmB-0002fR-3P
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:01:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iVhmA-0007qG-6n
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:01:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:56839)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iVhmA-0007qC-3T
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:01:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iVhm9-00069w-Uo
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:01:01 -0500
Subject: [bug#38214] [PATCH] gnu: Add minisat.
References: <20191115023401.8126-1-robertsmith@posteo.net>
Resent-Message-ID: <handler.38214.B.157384804023640@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:37839)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <robertsmith@posteo.net>) id 1iVhlk-0002aa-3U
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:00:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <robertsmith@posteo.net>) id 1iVhli-0007cw-Kl
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:00:35 -0500
Received: from mout01.posteo.de ([185.67.36.65]:34228)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <robertsmith@posteo.net>)
 id 1iVhli-0007cf-5i
 for guix-patches@gnu.org; Fri, 15 Nov 2019 15:00:34 -0500
Received: from submission (posteo.de [89.146.220.130])
 by mout01.posteo.de (Postfix) with ESMTPS id DC5B916005E
 for <guix-patches@gnu.org>; Fri, 15 Nov 2019 21:00:31 +0100 (CET)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <87d0dtfago.fsf@gmail.com>
Date: Fri, 15 Nov 2019 21:00:27 +0100
From: "Robert Smith" <robertsmith@posteo.net>
Message-Id: <BYGQKAKTC29H.18B1ACD7YJCT3@amber>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 38214@debbugs.gnu.org
Cc: m.othacehe@gmail.com

On Fri Nov 15, 2019 at 4:03 PM Mathieu Othacehe wrote:
> > +          (search-patches "minisat-friend-declaration.patch"
> > +                          "minisat-mroot-and-install.patch"))))
>=20
> Why are these patch needed? It seems that the last release was a long
> time ago, maybe we should package it from a git commit?

Thanks for the catch, I didn't realize that the git repo was so far
ahead of the last release.

> > +        ("kernel-headers" ,linux-libre-headers)))
>                       ^
>                       Is this really useful? It seems to build without.

I could have sworn that it refused to build without them, but testing
it now seems to work fine. I must have either been confused or it was
some other problem that I fixed.

Thanks for the feedback, I'll work on making the changes and submitting
a new patch.

-Robert