From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <bavier@cray.com>
Subject: RE: 01/01: gnu: fftw: Build SIMD codelets.
Date: Fri, 4 May 2018 14:44:25 +0000
Message-ID: <BN7PR11MB283484F5586C14ACB96E3318B7860@BN7PR11MB2834.namprd11.prod.outlook.com>
References: <20180417212549.1283.62731@vcs0.savannah.gnu.org>
	<20180417212551.BB270208E4@vcs0.savannah.gnu.org>
	<87efisjp91.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=655dd7a7c=bavier@cray.com>) id 1fEbwp-0000JF-AU
	for guix-devel@gnu.org; Fri, 04 May 2018 10:44:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=655dd7a7c=bavier@cray.com>) id 1fEbwm-0002Hj-1o
	for guix-devel@gnu.org; Fri, 04 May 2018 10:44:35 -0400
Received: from esa1.cray.iphmx.com ([68.232.142.33]:60391)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <prvs=655dd7a7c=bavier@cray.com>) id 1fEbwl-0002FS-J4
	for guix-devel@gnu.org; Fri, 04 May 2018 10:44:31 -0400
In-Reply-To: <87efisjp91.fsf@netris.org>
Content-Language: en-US
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: 'Mark H Weaver' <mhw@netris.org>
Cc: "'guix-devel@gnu.org'" <guix-devel@gnu.org>

Hi Mark,

> -----Original Message-----
> From: Mark H Weaver [mailto:mhw@netris.org]
> Sent: Thursday, May 03, 2018 6:26 PM
> To: Eric Bavier
> Cc: guix-devel@gnu.org
> Subject: Re: 01/01: gnu: fftw: Build SIMD codelets.
>=20
> Hi Eric,
>=20
> ericbavier@centurylink.net (Eric Bavier) writes:
>=20
> > bavier pushed a commit to branch core-updates in repository guix.
> >
> > commit 65bb22796f854cbc3eae053a80b1d64365dad376
> > Author: Eric Bavier <bavier@cray.com>
> > Date:   Fri Apr 6 10:53:06 2018 -0500
> >
> >     gnu: fftw: Build SIMD codelets.
> >
> >     * gnu/packages/algebra.scm (fftw)[arguments]: Remove 'no-native
> phase; use
> >     configure cache value instead.  Add configure flags for SIMD codele=
ts.
> >     (fftwf)[arguments]: Add neon configuration flag for 32-bit arm.
> >     (fftw-avx): Remove variable.
>=20
> [...]
>=20
> > @@ -560,7 +569,10 @@ cosine/ sine transforms or DCT/DST).")
> >      (arguments
> >       (substitute-keyword-arguments (package-arguments fftw)
> >         ((#:configure-flags cf)
> > -        `(cons "--enable-float" ,cf))))
> > +        (if (string-prefix? "arm" (or (%current-target-system)
> > +                                      (%current-system)))
> > +            `(cons "--enable-neon" ,cf)
> > +            cf))))
>=20
> Did you intend to remove the "--enable-float" configure flag in fftwf?
> You didn't mention this change in the commit log.

Indeed, I think this was unintentional.

> Can you take a look?

Yes, thanks for checking.

`~Eric