From: fis trivial <ybbs.daans@hotmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: "32860@debbugs.gnu.org" <32860@debbugs.gnu.org>
Subject: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 01:26:03 +0000 [thread overview]
Message-ID: <BLUPR16MB050004AD4F7BF3B27F5831F592ED0@BLUPR16MB0500.namprd16.prod.outlook.com> (raw)
In-Reply-To: <20180928144149.GA31414@jasmine.lan>
Leo Famulari writes:
> On Fri, Sep 28, 2018 at 10:06:30AM +0000, fis trivial wrote:
>> * gnu/packages/opencl.scm (pocl): Update to 1.2.
>
> Thanks!
>
>> (source
>> (origin
>> - (method git-fetch)
>> - (uri (git-reference
>> - (url "https://github.com/pocl/pocl.git")
>> - (commit (string-append "v" version))))
>> - (file-name (git-file-name name version))
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/pocl/pocl/archive/v"
>> + version".tar.gz"))
>
> Is there a particular reason to use the tarball instead of the Git repo
> here? I ask because Github's autogenerated tarballs are subject to
> change [0], which is annoying, whereas the Git repo should be
> bit-identical forever.
>
> [0] https://github.com/libgit2/libgit2/issues/4343
Oh, sorry I didn't know about that. Tarball feels cleaner than setting up a
git repo (just a feeling). I will send another patch using git soon.
But isn't those tarball now everywhere in Guix? It would be a huge headache.
--
Jiaming
next prev parent reply other threads:[~2018-09-29 1:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 10:06 [bug#32860] [PATCH] gnu: pocl: Update to 1.2 fis trivial
2018-09-28 14:41 ` Leo Famulari
2018-09-29 1:26 ` fis trivial [this message]
2018-09-29 14:57 ` Leo Famulari
2018-09-30 1:17 ` fis trivial
2018-09-29 4:05 ` fis trivial
2018-09-29 15:17 ` bug#32860: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR16MB050004AD4F7BF3B27F5831F592ED0@BLUPR16MB0500.namprd16.prod.outlook.com \
--to=ybbs.daans@hotmail.com \
--cc=32860@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.