From: Eric Bavier <ericbavier@openmailbox.org>
To: Alex Griffin <a@ajgrf.com>,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv.
Date: Thu, 07 Jul 2016 12:07:01 -0500 [thread overview]
Message-ID: <BB20B4AE-F7AE-4391-9E68-38C0C7FF77AE@openmailbox.org> (raw)
In-Reply-To: <1467902388.677813.659579777.62341118@webmail.messagingengine.com>
On July 7, 2016 9:39:48 AM CDT, Alex Griffin <a@ajgrf.com> wrote:
>On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
>> > + (uri (string-append
>"https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
>> > + version "/gnome-mpv-" version
>".tar.xz"))
>>
>> This line looks a bit long to me. Have you checked with “guix lint
>> gnome-mpv”?
>
>Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
>linter?
The linter is slightly tolerant and will accept lines under 90 characters IIRC.
>Anyway, here's an updated patch. In addition to correcting the long
>line, I also tweaked the synopsis and description to make clear that
>this is a media player, for the benefit of anyone who hasn't heard of
>mpv.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2016-07-07 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 0:04 [PATCH 2/2] gnu: Add gnome-mpv Alex Griffin
2016-07-07 7:10 ` Ricardo Wurmus
2016-07-07 14:39 ` Alex Griffin
2016-07-07 17:07 ` Eric Bavier [this message]
2016-07-07 17:17 ` Efraim Flashner
2016-07-10 4:13 ` Efraim Flashner
2016-07-12 15:34 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB20B4AE-F7AE-4391-9E68-38C0C7FF77AE@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=a@ajgrf.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.