From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +LT+Os8h72OcYAAAbAwnHQ (envelope-from ) for ; Fri, 17 Feb 2023 07:42:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SD7fOs8h72MkUAAAauVa8A (envelope-from ) for ; Fri, 17 Feb 2023 07:42:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C84E0C2FF for ; Fri, 17 Feb 2023 07:42:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=IBjYkRu8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676616143; a=rsa-sha256; cv=none; b=E53sjEBOX1rgjerCjieYLyTnF/PxpT58psGcoQD6VWDOK1mfHahJ1ku4wuxQdcG0Sl1Dmh KEQ5k0BUEOLLjsfvoU3aWQWB+Bfo4SCzPjKIg/+pTtpkV54PWzLpdPsmKVjIoW5YRUkOfv ju/a8F6Bta80/SzkrGdr1/1B6G9BhFLXoxmIAs451+sJfxK4Pex+yJ47CCMhXRI21YlSW1 QKmrn7mym889VwxpeC6vnR5FTED3lpFWM4mCtdCn7hCsaxSGIT5yIMEuK2tAk+gPAWsjrZ GkcPYc8Ikj+uC+jDFOLZN135otgand7Li7aIJCe43/cTLL86HYvgtD1weWoWjg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=IBjYkRu8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676616143; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZQO9XC6kDWtJ6qjHvWiuV6pleYqmM8EIuS1XC1UIRB0=; b=jBjnjxnyA371lkkYpzdnb/yaejPhaBdRu8uHVUgl3D0SkAhntmm47Jnz64V1Zfe1fOVBJd 5cQuHEK5qEv7SxDjxCuEWaaIdjN/LhurBzg9bgWvLItRf2I+N+0j8F2Q4sPRtpNBoMSD1k a7DYeo4D9+VZuBthaVYiIqrb8deKkvo+6q+PLQab05p+7e+b25KOz1oHQbSVIB2kX304bU 4QxSbM2SZ3AGN4CG0YbCzIGHuI202VVhuEgTDysuXXZ3gY+sfye9csuYD04He7DwRzqFZk AxWMZLjUFdR39Ol3dEXbbUUZbNn2WNqe8w7rRd9oyyExpBcSiYIsoR0eXMZdyQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSuRh-0004Pm-C5; Fri, 17 Feb 2023 01:42:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSuRZ-0004O2-23 for guix-patches@gnu.org; Fri, 17 Feb 2023 01:42:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSuRW-0000GL-HQ for guix-patches@gnu.org; Fri, 17 Feb 2023 01:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSuRW-0001VJ-Ct for guix-patches@gnu.org; Fri, 17 Feb 2023 01:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Feb 2023 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: 60673@debbugs.gnu.org, raingloom@riseup.net, mail@cbaines.net Cc: raingloom@riseup.net X-Debbugs-Original-To: guix-patches@gnu.org, Csepp , Christopher Baines X-Debbugs-Original-Cc: 60673@debbugs.gnu.org, raingloom@riseup.net Received: via spool by 60673-submit@debbugs.gnu.org id=B60673.16766160865718 (code B ref 60673); Fri, 17 Feb 2023 06:42:02 +0000 Received: (at 60673) by debbugs.gnu.org; 17 Feb 2023 06:41:26 +0000 Received: from localhost ([127.0.0.1]:38308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSuQt-0001Tz-Bg for submit@debbugs.gnu.org; Fri, 17 Feb 2023 01:41:26 -0500 Received: from lepiller.eu ([89.234.186.109]:33684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSuQq-0001Tp-Pn for 60673@debbugs.gnu.org; Fri, 17 Feb 2023 01:41:21 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 05f51d82; Fri, 17 Feb 2023 06:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=sNotYyBb3FSf 0JnqKkLHxWaEr13aWsup1KYkIt5zOLQ=; b=IBjYkRu8F5JpDANZm2xCFQLhRDCE PARA7poxpeCsk6TgX04hMtSfmEytB0DejNd8Q6iL5zCfxv/qtSBjrc98D3MgNk5J bO+hah50KQhB2Rxf4nLYtS3mGuoXP5tOdHs+6vG81EiySEqQJnqDQ39eFc4i0xr4 pUVZcJ2oSdNwK48cnQuQCAOoX6rzABMEAHVFEH6tSzQYbEdDn51nXICHTi7enRs1 X1EcBjHyBWZZuk3jqkFYbVG9/ZNhWNh6vPmso/pVzJAkyxmn7IJit/WoeLaJL7lt YIj6mCyvSISItIhnnqzW9wqv6kfOFzNT0IQQSSqRaIlLxO8d42p6FTLFaQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 155fe5dd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 17 Feb 2023 06:41:18 +0000 (UTC) Date: Fri, 17 Feb 2023 07:41:16 +0100 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <87sff5t84l.fsf@riseup.net> References: <20230109003529.23375-1-raingloom@riseup.net> <874jrxdhxi.fsf@cbaines.net> <87wn4t2aik.fsf@riseup.net> <875ycc8v82.fsf@cbaines.net> <87sff5t84l.fsf@riseup.net> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: C84E0C2FF X-Spam-Score: -2.63 X-Migadu-Spam-Score: -2.63 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: 19AGx2LhV/O5 https://qa=2Eguix=2Egnu=2Eorg/issue/60673 has picked it up at least :)=2E W= e still need to wait for a few builds=2E Le 17 f=C3=A9vrier 2023 02:03:46 GMT+01:00, Csepp = a =C3=A9crit=C2=A0: > >Christopher Baines writes: > >> [[PGP Signed Part:Undecided]] >> >> Csepp writes: >> >>> Christopher Baines writes: >>> >>>> [[PGP Signed Part:Undecided]] >>>> Hey, >>>> >>>> While I think the builds look OK for this series, there are quite a f= ew >>>> formatting issues raised by the linter (this can be seen on [1] and [= 2])=2E >>>> >>>> 1: https://qa=2Eguix=2Egnu=2Eorg/issue/60674 >>>> 2: >>>> https://data=2Eqa=2Eguix=2Egnu=2Eorg/compare?base_commit=3D238f965c33= 1990459a69cbc713ca951ad40e6044&target_commit=3D3b5485b9cdaebda127dc040ad67a= 287f39e33519 >>>> >>>> Could you run the linter on the packages you've added here, address t= he >>>> issues it raises and send an updated series? >>>> >>>> Thanks, >>>> >>>> Chris >>>> >>>> [[End of PGP Signed Part]] >>> >>> Those are all URL constants, can't really do much about them other tha= n slice >>> them up with string-append, which I'm not sure really helps with >>> readability or ease of editing=2E They were not an issue while I was >>> editing the code and gnu/packages/ocaml=2Escm already has a lot of lin= es >>> that whitespace-mode highlights as too long, so I thought it wouldn't >>> matter much and my time would be better spent elsewhere=2E >> >> You're right that there are quite a few other instances of lines that >> are too long in that module, but I don't think that's a reason not to >> add more=2E I think splitting the long URL strings with string-append i= s a >> good approach and can help with readability=2E >> >> [[End of PGP Signed Part]] > >Alright, got around to sending the updated patch series=2E Hopefully I >got the send-email arguments right=2E > > >