all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaelyn via Guix-patches via <guix-patches@gnu.org>
To: "72451@debbugs.gnu.org" <72451@debbugs.gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#72451] fixing the gsl test failures on i686
Date: Sun, 18 Aug 2024 17:44:09 +0000	[thread overview]
Message-ID: <AjI8cbW3PjJvv3wF1tQnJTlG446yYgI0AL-wMrkXuYRh9RnQTLY2fRnzW4KqcznqmH3_rYh9hwfwa26O9jOrHVYo6de9ZXVEQbxaPxPRPxs=@protonmail.com> (raw)
In-Reply-To: <71397042b223b98e0937b56018749c89eeb638e2.1722715149.git.kaelyn.alexi@protonmail.com>

Hi Ludo,

I noticed this morning that you recently pushed commit fa8dbbe59d to fix the i686-linux gsl test failures. I'd submitted a similar fix about two weeks ago (along with a couple of other i686-linux fixes that affect building wine64), and I wanted to mention that I don't think your commit does the right thing with CFLAGS. When I figured out the error, I noticed a side-effect of passing CFLAGS=-fPIC as the #:make-flags is that it disables the optimized build (or at least relies on whatever optimizations the compiler defaults to, which AFAIK is little to none). While your patch also cleans up the definition a bit by no longer disabling some tests, I think the correct approach is to include the package's default CFLAGS as part of the #:make-flags as I did in issue 72451 so that optimizations aren't unintentionally disabled.

Cheers,
Kaelyn




  reply	other threads:[~2024-08-18 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 20:01 [bug#72451] [PATCH core-updates] gnu: gsl: Fix build on i686 Kaelyn Takata via Guix-patches via
2024-08-18 17:44 ` Kaelyn via Guix-patches via [this message]
2024-08-20 12:42   ` [bug#72451] fixing the gsl test failures " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AjI8cbW3PjJvv3wF1tQnJTlG446yYgI0AL-wMrkXuYRh9RnQTLY2fRnzW4KqcznqmH3_rYh9hwfwa26O9jOrHVYo6de9ZXVEQbxaPxPRPxs=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=72451@debbugs.gnu.org \
    --cc=kaelyn.alexi@protonmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.