all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: 37744@debbugs.gnu.org, ludo@gnu.org, me@tobias.gr
Cc: guix-security@gnu.org
Subject: bug#37744: Per-user profile directory hijack (CVE-2019-17365 for Nix)
Date: Wed, 16 Oct 2019 18:28:08 +0200	[thread overview]
Message-ID: <AA3C1975-800B-4D2E-A260-20E9DC95D0F0@lepiller.eu> (raw)
In-Reply-To: <87tv89rnva.fsf@gnu.org>

Le 16 octobre 2019 12:22:33 GMT+02:00, "Ludovic Courtès" <ludo@gnu.org> a écrit :
>Hello!
>
>Here’s a patch that fixes the issue, partly based on what the Nix folks
>did.
>
>For the client-connecting-over-TCP case, I added special handling:
>‘set-build-options’ now passes a “user-name” property, potentially
>allowing to create ‘per-user/$USER’ at that point (like you suggested,
>Tobias.)
>
>In a cluster setup, it means that the machine that runs ‘guix-daemon’
>must see the same users as the machines where its clients run, but
>that’s basically already what we expect:
><https://hpc.guix.info/blog/2017/11/installing-guix-on-a-cluster/>.
>
>There’s one case that won’t be correctly handled: in a cluster setup,
>an
>old client talking to a new daemon won’t provide info to create
>‘per-user/$USER’, and thus ‘guix package’ & co. won’t be able to create
>the user’s profile it it doesn’t already exist.  I think that’s hard to
>avoid though.
>
>Thoughts?
>
>Thanks,
>Ludo’.

We could advise people to restart the service too, with e.g. systemctl restart guix-daemon

      parent reply	other threads:[~2019-10-16 16:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  7:47 bug#37744: Per-user profile directory hijack (CVE-2019-17365 for Nix) Ludovic Courtès
2019-10-14  7:58 ` Ludovic Courtès
2019-10-14 11:53   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-14 16:37     ` Maxim Cournoyer
2019-10-15 12:34     ` Ludovic Courtès
2019-10-15 14:31       ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16  6:57         ` Ludovic Courtès
2019-10-16 10:22           ` Ludovic Courtès
2019-10-16 13:25             ` Ludovic Courtès
2019-10-16 14:22               ` pelzflorian (Florian Pelz)
2019-10-16 15:16                 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 15:19                   ` pelzflorian (Florian Pelz)
2019-10-16 15:23                     ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 17:05                       ` Ludovic Courtès
2019-10-16 19:50                         ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 19:55                           ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 21:40                             ` Ludovic Courtès
2019-10-16 21:41                             ` Ludovic Courtès
2019-10-16 19:58                         ` Julien Lepiller
2019-10-16 21:38                           ` Ludovic Courtès
2019-10-16 15:37                 ` pelzflorian (Florian Pelz)
2019-10-16 21:39                   ` Ludovic Courtès
2019-10-17  2:58                     ` pelzflorian (Florian Pelz)
2019-10-17  3:01                       ` pelzflorian (Florian Pelz)
2019-10-16 20:28               ` Ludovic Courtès
2019-10-17 16:18               ` Ludovic Courtès
2019-10-17 19:01                 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-17 20:25                   ` Ludovic Courtès
2019-10-18  2:21                     ` Bengt Richter
2019-10-18 14:36                       ` Ludovic Courtès
2019-10-19  1:32                         ` Bengt Richter
2019-10-16 14:12             ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 20:01               ` Ludovic Courtès
2019-10-16 16:28             ` Julien Lepiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AA3C1975-800B-4D2E-A260-20E9DC95D0F0@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=37744@debbugs.gnu.org \
    --cc=guix-security@gnu.org \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.