From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41936) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTCO3-0007mO-FA for guix-patches@gnu.org; Mon, 27 Apr 2020 18:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTCO2-0007Uq-Fz for guix-patches@gnu.org; Mon, 27 Apr 2020 18:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTCO2-0007Ul-1T for guix-patches@gnu.org; Mon, 27 Apr 2020 18:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTCO1-0005BN-VB for guix-patches@gnu.org; Mon, 27 Apr 2020 18:38:01 -0400 Subject: [bug#40835] [PATCH] Update to use panfrost for graphics hardware acceleration Resent-Message-ID: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) From: Brian Woodcox In-Reply-To: <87ftcovbkn.fsf@ponder> Date: Mon, 27 Apr 2020 16:36:39 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54EFA16B-27F2-40F4-8FF0-F59BC65BF8AB@inskydata.com> <87lfmgvlqx.fsf@ponder> <65E1BABE-56D0-4F84-92A3-7C4238722FC3@inskydata.com> <87ftcovbkn.fsf@ponder> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian Cc: 40835@debbugs.gnu.org > On Apr 27, 2020, at 3:54 PM, Vagrant Cascadian = wrote: >=20 >=20 >>> On Apr 27, 2020, at 12:15 PM, Vagrant Cascadian = wrote: >>> On 2020-04-24, Brian Woodcox wrote: >>>> You need to edit the /boot/extlinux/extlinux.conf file on the SD = card and alter the FDTDIR line. >>>>=20 >>>> I changed mine from >>>>=20 >>>> FDTDIR = /gnu/store/ls1byzmapi911cylh4s6044x0cmc61c8-linux-libre-pinebook-pro-5.6.0= /lib/dtbs >>>>=20 >>>> to >>>>=20 >>>> FDTDIR = /gnu/store/ls1byzmapi911cylh4s6044x0cmc61c8-linux-libre-pinebook-pro-5.6.0= /lib/dtbs/rockchip >>>=20 >>> The u-boot-pinebook-pro-rk3399 on guix master works correctly as = well as >>> the one from wip-pinebook-pro (should be the same). >=20 > Oops, my bad. I've been merging master and core-updates locally and > forgot the status of wip-pinebook-pro... I think I was waiting for the > core-updates merge, but it's probably worth merging master just to get > the updated u-boot-pinebook-pro-rk3399 based more closely on upstream > u-boot! I would be happy to test that out when done! >=20 >=20 >> I=E2=80=99m not sure what this problem is exactly. For some reason = the >> rockchip folder is not being added to the end of the patch for the >> FDTFILE, also, you do not need to actually specify the file as u-boot >> will find it as long as it=E2=80=99s on the directory. >=20 > It's probably a bug in the u-boot fork that's still in = wip-pinebook-pro. >=20 >=20 >>>> diff --git a/gnu/packages/patches/mesa-skip-disk-cache-test.patch = b/gnu/packages/patches/mesa-skip-disk-cache-test.patch >>>> index 190f6b6ee1..585bf4f648 100644 >>>> --- a/gnu/packages/patches/mesa-skip-disk-cache-test.patch >>>> +++ b/gnu/packages/patches/mesa-skip-disk-cache-test.patch >>>> @@ -1,11 +1,6 @@ >>>> -disk_cache_create() here looks up the users home directory from = >>>> -which resolves to "/" in the build environment. I could not find = an easy >>>> -way to set the home directory to something else, so we disable = this test >>>> -for now. >>>> - >>>> --- a/src/compiler/glsl/tests/cache_test.c >>>> +++ b/src/compiler/glsl/tests/cache_test.c >>>> -@@ -170,11 +170,6 @@ >>>> +@@ -219,11 +219,6 @@ >>>> unsetenv("MESA_GLSL_CACHE_DIR"); >>>> unsetenv("XDG_CACHE_HOME"); >>>=20 >>> This removes a comment from the refreshed patch; I presume the = comment >>> is still appropriate, though? >>=20 >> Yes, Patch should have been applied to = d4c6e06f369024efc63e11de1a5bacd3fe9f7e8d as stated above. >=20 > Regardless of which branch it applies to, the comment in this patch > should probably be kept, unless it's no longer relevent. Okay, I have to admit I was confused by this. Turns out when I was = debugging, I accidentally removed the comment (or at least my fingers did). I didn=E2=80=99t = realize that and now I know why it appeared in the patch set. Thus my comment about being applied to the = correct commit. That=E2=80=99s what happens when you don=E2=80=99t think things through = enough. >=20 >=20 >>>> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm >>>> index 8696dc4bb6..a1e7684964 100644 >>>> --- a/gnu/packages/qt.scm >>>> +++ b/gnu/packages/qt.scm >>>> @@ -15,6 +15,7 @@ >>>> ;;; Copyright =C2=A9 2018 John Soo >>>> ;;; Copyright =C2=A9 2020 Mike Rosset >>>> ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka = >>>> +;;; Copyright =C2=A9 2020 Brian C. Woodcox >>>> ;;; >>>> ;;; This file is part of GNU Guix. >>>> ;;; >>>> @@ -485,6 +486,7 @@ developers using C++ or QML, a CSS & JavaScript = like language.") >>>> "-no-compile-examples" >>>> ;; Most "-system-..." are automatic, but some use >>>> ;; the bundled copy by default. >>>> + "-opengl" "es2" >>>> "-system-sqlite" >>>> "-system-harfbuzz" >>>> "-system-pcre" >>>=20 >>> This might break some things where a different opengl is the = default, >>> some architectures or platforms may require a different opengl >>> implementation. >>>=20 >>> I seem to recall some conversations in Debian about the complexities >>> around which opengl to enable per-architecture or per-platform or = ... a >>> complicated matrix of concerns. >>=20 >> Open to suggestions. >=20 > =46rom what I remember there were no *good* options; to fix things for = one > platforms, you break things for another. In guix it might be slightly > better off in that you can have variant pacakges more easily, though = for > libraries this would mean variants for everything that uses it, > too... :/ =46rom the different configuration files I=E2=80=99ve look at from other = people, it appears the patch could be done when the system is configured. Does that sound like a better place to put it? I don=E2=80=99t know how else to keep things from getting messy. >=20 >=20 > Thanks for joining the guix on pinebook pro adventures! >=20 >=20 > live well, > vagrant