From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cGEjBl7JW2KuewAAgWs5BA (envelope-from ) for ; Sun, 17 Apr 2022 10:01:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mHJlOl3JW2IdGAEAG6o9tA (envelope-from ) for ; Sun, 17 Apr 2022 10:01:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83494CE43 for ; Sun, 17 Apr 2022 10:01:33 +0200 (CEST) Received: from localhost ([::1]:59042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfzqe-000368-5x for larch@yhetil.org; Sun, 17 Apr 2022 04:01:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfzqA-00034Y-4z for guix-patches@gnu.org; Sun, 17 Apr 2022 04:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfzq9-0007oe-Qt for guix-patches@gnu.org; Sun, 17 Apr 2022 04:01:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nfzq9-00019c-Nr for guix-patches@gnu.org; Sun, 17 Apr 2022 04:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53765] [PATCH v4 1/2] gnu: clojure-tools-deps-alpha: Patch unpackageable Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 Apr 2022 08:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Reily Siegel , 53765@debbugs.gnu.org Received: via spool by 53765-submit@debbugs.gnu.org id=B53765.16501824024259 (code B ref 53765); Sun, 17 Apr 2022 08:01:01 +0000 Received: (at 53765) by debbugs.gnu.org; 17 Apr 2022 08:00:02 +0000 Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfzpB-00016Q-6A for submit@debbugs.gnu.org; Sun, 17 Apr 2022 04:00:01 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:36792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfzp9-00015y-5F for 53765@debbugs.gnu.org; Sun, 17 Apr 2022 04:00:00 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id Kjzw2700G4UW6Th01jzxkM; Sun, 17 Apr 2022 09:59:57 +0200 Message-ID: <9fd69fba6708a6846d09bb0817d8586ff0ffdee0.camel@telenet.be> From: Maxime Devos Date: Sun, 17 Apr 2022 09:59:49 +0200 In-Reply-To: <3981f1dd891e8cd863dc9fecffe30c97235ce643.1650150000.git.mail@reilysiegel.com> References: <3981f1dd891e8cd863dc9fecffe30c97235ce643.1650150000.git.mail@reilysiegel.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6XhqXHB/20pnjriC4+mz" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650182397; bh=Pd+U2ySfAVKTauY17v75ht1cwcP5Qb+itAjVudMIXJc=; h=Subject:From:To:Date:In-Reply-To:References; b=WU/HMkL8R6z0E0Cd3Z6DML8qhVD9w52MJyeUOJR9bb3NXcydY3c8QEE6X/vKdxcxb m/a33/sMBTKW9rGVXAeM/nPoLAseeIwNAuQ0N1mx3iFo8YPxCTSPxmjiOReI+gwhhE 6UssKW1RoAJBw71KOhaECFNdnBW3JRhDpaTegRec3XpRNFS3v/lXEeM4n1K/AF4mD8 6E5CiTFy9PjkoNaE/XHNpNKxLM3VDMuc+OvtvHMS+QGrtIBCfTwowavLSDnNroSjpv 5pJL8Z/tAAuaJb7yIez+FgWoOJr0A7QqTd5SrQ84o4McyWzJx0cmADAlJSVcb29RdI arKLhH3OYUN6g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650182493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Pd+U2ySfAVKTauY17v75ht1cwcP5Qb+itAjVudMIXJc=; b=JKfSLLOlgbE0T5wIoUmOGEl8aDS2aqXyJg6HCN1V1SsTT4a8i/IeIfeZX2nZO+wWTbIs0M FohmVlN5QoCRxgxlVkygLEMq8xy1tLQ+RyTjTvNhSsEdg9939b24rQS3QzakmNRqHbczzx m8gqfa1RkUhkLTttficfhC2BK9Jp0sB1ESoTYRKmeXGGl1JxeNHNHV+lCShhz7ZMJO8t3K CzV/4EKGhtO5epkMAR/PIF0c4USp4xh7FOmn45lAPAvjP6+YrgcKJ2GW1+zdxmA8a/4UNU jPLvgSzBurutmLzc1SljF3fR1Jt/VSmJeWjjV6p1YGkNvdH7U7EWoboSb1iPOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650182493; a=rsa-sha256; cv=none; b=PTlPxoERcBsNDY4bNCJh+Y+rqKPChqvxFATAoqL6vsUn9tPDDYnbCJNKhycH8vZCSAWdj3 CqjM1c9ppeHmSwd3zMyW0dCnn/2Hjzz1GK0G4SU+y8Wc3pD2ypclX+lsK8ei41hUpKAR9C iUVPa7nXOhNBomYNpaEbbA/wGi62hOrc2FdhSoTvFVxcfuuBd1WoN6y6LUU8JXvNR2PMCZ N4v6FkL8RxsSzNKKAFmabxpj29apz584my6IUda0lnGrRxEz2fKCoOo8+iup4UcMsN87Th EjJPlqTAmaa4RZu443T5+DTObDz1PS8Hpm/Afe6Bv6hzYJ4cOOeK9wgirFqe1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="WU/HMkL8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="WU/HMkL8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 83494CE43 X-Spam-Score: 3.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: IVsdNecOeqLC --=-6XhqXHB/20pnjriC4+mz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, While you can choose to not include the library packages that were eventually unused, you don't have to exclude them just because they are -- they might be useful to other people or yourself, for non-clojure- tools things, or for clojure-tools if(when?) Cognitect decides to make the compiler free software. Reily Siegel schreef op za 16-04-2022 om 23:59 [+0200]: > --- > =C2=A0gnu/packages/clojure.scm | 15 ++++++++------- > =C2=A01 file changed, 8 insertions(+), 7 deletions(-) >=20 Changelog message is missing, maybe: * gnu/packages/clojure.scm (clojure-tools-deps- alpha)[arguments]<#:phases>{remove-s3-transporter}: Remove warning that is emitted even when S3 is unused. > diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm > index e6eb749501..0d9e984bd6 100644 > --- a/gnu/packages/clojure.scm > +++ b/gnu/packages/clojure.scm > @@ -501,11 +501,11 @@ (define-public clojure-tools-deps-alpha > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:tests? #f > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phases > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modify-phases %standard-phase= s > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; FIXME: Currently, th= e S3 transporter depends on ClojureScript, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; which is very diffic= ult to package due to dependencies on Java > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; libraries with non-s= tandard build systems. Instead of actually > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; packaging these libr= aries, we just remove the S3 transporter that > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; depends on them. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; Currently, the S3 tr= ansporter depends on com.cognitect.aws/s3, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; which is built from = Amazon's aws-sdk-js using a closed-source > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; script. For more inf= ormation see: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; https://issues.guix.= gnu.org/53765 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; https://github.com/c= ognitect-labs/aws-api/issues/116 Guix (and more generally, GNU) is more a free software thing than an open source thing, it requires the software it includes to be free software but it doesn't seem to require it to be open-source (though in practice they seem to describe the same software ...). Also still looks like a FIXME to me, personally I'd keep the =E2=80=98FIXME= :=E2=80=99 prefix. > --- > gnu/packages/clojure.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Likewise (about the commit message). Possible example (from another package): * gnu/packages/web.scm (python-feedparser) [propagated-inputs]: Add python-sgmllib3k. Otherwise, LGTM, thanks. Greetings, Maxime. --=-6XhqXHB/20pnjriC4+mz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYlvI9RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7n/lAQCVotE4kU8EB0uluZ7osVt8TYyJ Jlq+f9hdmxVkt7/7yQEAtb6p7goS0fGc3TL1UkqOb5BfFl9DetveYTskaUGP5gc= =/e/8 -----END PGP SIGNATURE----- --=-6XhqXHB/20pnjriC4+mz--