From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wNjnH+czuGKvHAAAbAwnHQ (envelope-from ) for ; Sun, 26 Jun 2022 12:24:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yDzrHuczuGJihQAAG6o9tA (envelope-from ) for ; Sun, 26 Jun 2022 12:24:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 369293AEAB for ; Sun, 26 Jun 2022 12:24:39 +0200 (CEST) Received: from localhost ([::1]:47368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5PRV-0000jj-Tc for larch@yhetil.org; Sun, 26 Jun 2022 06:24:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5PQw-0000jQ-Ga for guix-patches@gnu.org; Sun, 26 Jun 2022 06:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5PQw-0002OA-2Y for guix-patches@gnu.org; Sun, 26 Jun 2022 06:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5PQv-0000dN-Sp for guix-patches@gnu.org; Sun, 26 Jun 2022 06:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49898] [PATCH v5] gnu: Add spectre-meltdown-checker. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Jun 2022 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49898 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49898@debbugs.gnu.org Received: via spool by 49898-submit@debbugs.gnu.org id=B49898.16562390242411 (code B ref 49898); Sun, 26 Jun 2022 10:24:01 +0000 Received: (at 49898) by debbugs.gnu.org; 26 Jun 2022 10:23:44 +0000 Received: from localhost ([127.0.0.1]:46767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5PQe-0000cp-Ea for submit@debbugs.gnu.org; Sun, 26 Jun 2022 06:23:44 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:35656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5PQZ-0000cX-VJ for 49898@debbugs.gnu.org; Sun, 26 Jun 2022 06:23:42 -0400 Received: by mail-ej1-f65.google.com with SMTP id pk21so13340739ejb.2 for <49898@debbugs.gnu.org>; Sun, 26 Jun 2022 03:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=D9v3f1uTrWhzhf+yJGf8MB/rBDqn8ksX6BjDaDTAFcs=; b=MINLXxz1z6cZk1WVf6pM4oqGXygQv06O8Ks6VDm6i37mcSGWVXIQG8in443cqbHLAI qasg7KWcagzSRJt3PqyCqC/Xfbd0JthnkAt0VWGkv6Xt6MWTjMai/UoHX9Fbb3yHWm7H 47/u7Z3JtVvKHonvsWPN4aUrRsxOATZQcFdjQ/kMRU4LWhuN1mCE1Zz6Rcy/jj1fUC0t wIpLkgvcvG0DDNaU5sLx/NnGlEZb7KSDQEHUh/k7tzSK4glgDunwCMB+Bf14W9dfzBaK Bz+fTcdql3IVUBLHIvGpjnpsQv3YB8oxAhM1z4PRecxQN6RFa+o4BiBRrdxaO3VKxOxh jVVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=D9v3f1uTrWhzhf+yJGf8MB/rBDqn8ksX6BjDaDTAFcs=; b=XhPXYwLQBJH0ya390BDIlJrq28MhPtZ//aU50OKJ+H/Q5ydrsSgyMi0bzaShe0ZdQg d9OOst0CVrRHYYQQ5jGzuc9SVqcYlN3zKsKRx3IBgB+OFFEeYSqo021QTsiHd3KZkf+7 T1I9zMlbybT0VHwMlfA68T3PWZFTW5DQks8mxEI3T/rxxeKbkRy+pBpi4uOuDxhLmMc3 uhO9ajCM3y4aqjkfHNLP5otDS+BiqhwtNa/D+2soz/CWUvVEWG1QXDJq3EO4AWHeCzjh yXsNs6/BmtaDebRQp8xuNvGE1SlWJoTUb9Ya+TvB1T18wmvbgfuDnTKM/KsbBWOUNfW1 qGZQ== X-Gm-Message-State: AJIora95OZuNTKzePUdirmCpSfRAVJ+9DJwQSkrHm0eDHY3KLRBQpIRq l1sSGxrKai+Kfuttj5Na864= X-Google-Smtp-Source: AGRyM1tCVtKkuGPAJdKx332I7u/CIi1t+vCOZUShVdLoFu9k+RMlvGlGMcJOmjFYZHOQr91rJ+Wl2Q== X-Received: by 2002:a17:907:58e:b0:726:9e67:e7cc with SMTP id vw14-20020a170907058e00b007269e67e7ccmr1224122ejb.740.1656239013982; Sun, 26 Jun 2022 03:23:33 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id e13-20020a170906c00d00b007262b7afa05sm3592566ejz.213.2022.06.26.03.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 03:23:33 -0700 (PDT) Message-ID: <9fb60e57ba5ed684c5ad113c3b9861e7d2e922e0.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 26 Jun 2022 12:23:32 +0200 In-Reply-To: References: <0611f164235f06ffdfaa3eb4fa5a7915210df134.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656239079; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D9v3f1uTrWhzhf+yJGf8MB/rBDqn8ksX6BjDaDTAFcs=; b=Nrgc4esBBHRXDJrQKDekrDx9HuRwPqT63wx9YjtBOfQ9J8nSPbOIrc3a5b1YMMk4hNMReH 0bmhMLb/cp6xnDxWcfTCy+KevyRxeiMz1vDwWR5lVjWQC1Ju1vFgqVfNUPsBmbJGwDL+CM 7W8bZ6qijZ5SPmATGdE1tzZgzi4hwsuoMYMf1l2SvPIx5YsoxF00YpfrZKEZHi+eHpnsE4 rjSWsbZmJaE8nzxI8DMHqjqFD0EYRvfolyhSTmPCdPzzA6FhIlQ6sQ4dw8+k+0sRL7xZ+Q 3JFs6f2ADthNz2FrMGO+DJTiqUixrEQUFiRY2YZ59dwVQKGeBrMd63cK6DGwCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656239079; a=rsa-sha256; cv=none; b=r3X3x3L3UaIrq2JUAUdhWkKjfTp/9rW2gYuDDsmSQkkrV/BY8aXTdCTTNSeUSB1TrSYNkd kmR1LSoCnjx380FbGnyQijlfCdlKVV+40ALJ/EFo01TxrkDwx5qjRaQPIGYTm245FHehJX cu5Jy5zVo4Fbh9UBWybZTCRiX+MjJ3zVg5ro0aENViRTeaR19N2BvF1aQGFnh88j4WMsAR 3PGsNgYyyN8qoHYE6nAHc48e3jRB/NAdPjTueua9/DRigaMM8+iZ/LZHmVn8UK7XZiuAZs zmK2uQiFEiTL5sxKvSvUgnd7faATecHbAuvugxgSM7N1tMKkFvvNPcxbaChLQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MINLXxz1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MINLXxz1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 369293AEAB X-Spam-Score: 7.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1cvA04E/xZA+ Hi Petr, sorry for the very late reply. Are you still interested in adding spectre-meltdown-checker? If so, there's a new version out. Also... Am Dienstag, dem 07.12.2021 um 22:04 +0000 schrieb phodina: > I've used the wrap-program as an alternative to the your suggested > solution. That does work, but remains quite inelegant. > Going through the program there is a function update_fwdb [1] that > downloads and updates database files when the script is executed with > the --update-fwdb argument. > > I've added both files [2][3] in question to the lists of inputs. > > However, since they are supposed to be updated at runtime (stored in > $HOME) I don't know to represent this in the package definition. > > Could you please suggest how to proceed? I'd suggest removing that functionality as well as the associated inputs (i.e. curl etc., not the databases). Even if it's treated as "just data", users should be able to specify on their own the data to check against. Perhaps you could suggest to upstream that adding -- fwdb /path/to/fwdb might be useful? Since this patch is rather old, there are a few style-related changes that should also be incorporated: > + (arguments > + `(...)) Use a list of G-Expressions. > + (paths (map > + (lambda (input) > + (string-append (assoc-ref inputs input) > "/bin")) > + '("coreutils" "grep" "util-linux" > "iucode-tool" > + "util-linux-with-udev" "gawk" "gzip" > "lzop" > + "lzop" "perl" "procps" "sqlite" "wget" > "which" "xz" "zstd")))) You can use (search-input-file inputs "/bin/CMD") to search CMD from inputs. > + (inputs `(("binutils" ,binutils) > + ("coreutils",coreutils) > + [...]) You can drop the input labels, but you'll have to find another way to pass the firmware databases. Speaking of which, is anything even done with those? Could we add (a) separate package(s) with those databases instead? Cheers